Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(profiling): cleanup add/remove interrupts #1906

Merged
merged 2 commits into from
Feb 6, 2023
Merged

refactor(profiling): cleanup add/remove interrupts #1906

merged 2 commits into from
Feb 6, 2023

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Feb 3, 2023 •
edited
Loading

Description

Simplifies the add/remove interrupt code by using the Iterator::position function.

Also fixes a very minor mistake in a warning log where index and interrupt were swapped.

Readiness checklist

  • Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.

@morrisonlevi morrisonlevi added the profiling Relates to the Continuous Profiler label Feb 3, 2023
@morrisonlevi morrisonlevi added this to the 0.85.0 milestone Feb 3, 2023
@morrisonlevi morrisonlevi requested a review from a team as a code owner February 3, 2023 17:23
@realFlowControl realFlowControl merged commit f2039e0 into master Feb 6, 2023
@realFlowControl realFlowControl deleted the levi/refactor-profiling branch February 6, 2023 09:09
@bwoebi bwoebi mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees
No one assigned
Labels
profiling Relates to the Continuous Profiler
Projects
None yet
Milestone
0.85.0
Development

Successfully merging this pull request may close these issues.
2 participants
@morrisonlevi @realFlowControl