Add a DDTrace\generate_distributed_tracing_headers() function #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/generate_distributed_tracing_headers
branch
from
4d368d7 to
d0bb07f
Compare
It's a direct opposite function to consume_distributed_tracing_headers, thereby trivially enabling users to use it for custom propoagation and later consumption. Also needed for easy testing of parametric tests. And force phpunit < 10 to fix tests.
bwoebi
force-pushed
the
bob/generate_distributed_tracing_headers
branch
from
d0bb07f to
8c8c475
Compare
morrisonlevi
approved these changes
Feb 3, 2023
Comment on lines
+2014
to
+2015
| if (get_DD_TRACE_ENABLED()) { | ||
| ddtrace_inject_distributed_headers(Z_ARR_P(return_value), true); |
There was a problem hiding this comment.
If a given request had distributed headers passed to it, do we need to pass on those headers in outgoing requests even if the tracer is disabled? My memory isn't clear here, but IIRC there's something like that we should be doing.
There was a problem hiding this comment.
If the tracer is disabled, we don't even read the distributed headers. So, here, no, we should not do now.
Maybe, if it's something we should do, we need to refactor a couple things, but that should be separate work.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's a direct opposite function to consume_distributed_tracing_headers, thereby trivially enabling users to use it for custom propoagation and later consumption.
Also needed for easy testing of parametric tests.
Readiness checklist
Reviewer checklist