Add hooking for Closures #1904
Merged
Add hooking for Closures #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/closure-hooking
branch
3 times, most recently
from
3365ebf to
1762539
Compare
morrisonlevi
reviewed
Feb 7, 2023
morrisonlevi
reviewed
Feb 7, 2023
morrisonlevi
reviewed
Feb 7, 2023
bwoebi
force-pushed
the
bob/closure-hooking
branch
from
1762539 to
510eeee
Compare
morrisonlevi
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
We reviewed the code together over Zoom. There are some things like leaving code comments, but overall it looks good, as far as I can tell.
The ability to trace closures in important, so unless the overhead of doing this is too high, I don't see a reason to block this.
bwoebi
force-pushed
the
bob/closure-hooking
branch
3 times, most recently
from
0078907 to
58f2bfd
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
bwoebi
force-pushed
the
bob/closure-hooking
branch
2 times, most recently
from
e3c710b to
dad7ebe
Compare
bwoebi
force-pushed
the
bob/closure-hooking
branch
from
dad7ebe to
bdcd0e3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from my experiments with revolt; the DDTrace\install_hook() API now got proper instrumentation for Closures. Note that hooks applied to closures only apply to the lifetime of the specific hooked closure.
This makes it trivial to check with a WeakMap whether the Closure already has been hooked.
Additionally the DDTrace\HookData API got a span() method which must be called in the begin handler at least once if the hook is to be traced.
Readiness checklist
Reviewer checklist