Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export ddtrace_flush_tracer and allow flushing during request startup #1901

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Export ddtrace_flush_tracer and allow flushing during request startup #1901

merged 4 commits into from
Feb 2, 2023

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Feb 1, 2023

Description

Export ddtrace_flush_tracer and allow flushing during request startup. Currently appsec blocks the request primarily on RINIT, which results in no traces in the backend, this should allow the ASM extension to flush the traces before blocking.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@Anilm3 Anilm3 added this to the 0.84.0 milestone Feb 1, 2023
@Anilm3 Anilm3 marked this pull request as ready for review February 1, 2023 16:43
@Anilm3 Anilm3 requested a review from a team as a code owner February 1, 2023 16:43
bwoebi
bwoebi approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we will need it - but we always can remove it later on.

@bwoebi bwoebi merged commit f85fbdb into master Feb 2, 2023
@bwoebi bwoebi deleted the anilm3/export_flush_tracer branch February 2, 2023 12:10
@bwoebi bwoebi mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.84.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Anilm3 @bwoebi