Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(datadog-setup.php): reformat file #1869

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

morrisonlevi
Copy link
Collaborator

@morrisonlevi morrisonlevi commented Jan 18, 2023

Description

Reformat datadog-setup.php in preparation for further work. Mostly this changed long strings, string concatenation, and multi- line ternary expressions.

Readiness checklist

  • Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.

Mostly this changed long strings, string concatenation, and multi-
line ternary expressions.
@morrisonlevi morrisonlevi added this to the 0.84.0 milestone Jan 18, 2023
@morrisonlevi morrisonlevi requested a review from a team as a code owner January 18, 2023 04:22
@morrisonlevi morrisonlevi added the cat:installation Issues while installing the tracer label Jan 18, 2023
@morrisonlevi morrisonlevi changed the title style: reformat datadog-setup.php style(datadog-setup.php): reformat file Jan 18, 2023
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
(seal of approval)

@morrisonlevi
Copy link
Collaborator Author

FYI, the CI checks passed: https://app.circleci.com/pipelines/github/DataDog/dd-trace-php/9687. For whatever reason, GitHub UI is not reflecting this pipeline (it's showing an earlier pipeline).

@morrisonlevi morrisonlevi merged commit 056139d into master Jan 18, 2023
@morrisonlevi morrisonlevi deleted the levi/style-setup branch January 18, 2023 16:21
@bwoebi bwoebi mentioned this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:installation Issues while installing the tracer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants