Improve extension matching in installer #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
force-pushed
the
bob/better-extension-match
branch
from
6587e4a to
5c01a63
Compare
As suggested in #1846.
bwoebi
force-pushed
the
bob/better-extension-match
branch
from
5c01a63 to
74c2990
Compare
|
What does this improve, exactly? Are there specific examples of what we're trying to match? If so I'd put those in as code comments in case someone ever needs to change or refactor this section. |
morrisonlevi
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Be less sensitive to the actual filepath; as suggested in #1846.
Readiness checklist
[ ] Tests added for this feature/bug.Reviewer checklist