Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PHP 7) Fix memory leak with custom CURLOPT_READFUNCTION #1841

Merged
merged 1 commit into from
Jan 3, 2023
Merged

(PHP 7) Fix memory leak with custom CURLOPT_READFUNCTION #1841

merged 1 commit into from
Jan 3, 2023

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Jan 3, 2023 •
edited by morrisonlevi
Loading

Description

Used the wrong function to clean the object.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi
Properly destruct curl wrapper to free readfunc
94c1589 
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi added this to the 0.83.0 milestone Jan 3, 2023
@bwoebi bwoebi requested a review from a team as a code owner January 3, 2023 12:24
@morrisonlevi morrisonlevi added 🐛 bug Something isn't working c-extension Apply this label to issues and prs related to the C-extension Overhead Relates to latency, CPU, or memory overhead labels Jan 3, 2023
@bwoebi bwoebi merged commit 6c32b0e into master Jan 3, 2023
@bwoebi bwoebi deleted the bob/fix-curl-readfunc-free branch January 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrisonlevi morrisonlevi morrisonlevi approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working c-extension Apply this label to issues and prs related to the C-extension Overhead Relates to latency, CPU, or memory overhead
Projects
None yet
Milestone
0.83.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bwoebi @morrisonlevi