Support Symfony 3.4 #181
Merged
Support Symfony 3.4 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
labbati/symfony-3.4
branch
from
3845add to
1e616c7
Compare
…operly configured
pawelchcki
reviewed
Dec 11, 2018
labbati
force-pushed
the
labbati/symfony-3.4
branch
from
f61ec93 to
4b311b7
Compare
labbati
force-pushed
the
labbati/symfony-3.4
branch
from
4b311b7 to
aeaa79d
Compare
pawelchcki
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Looks good!
While there seems to be some overlap with symfony v4 and it looks like there could be some low hanging fruits for some code reuse between the two.
But since the layout might get changed a bit with upcoming changes on C level. I'm not supper hanged up on making that reuse happen now :)
|
They surely need a refactor and can share some code, but as you said, given the soon to be happening changes to the C extension, we can leave a little bit of code duplication for now. |
bwoebi
pushed a commit
that referenced
this pull request
Sep 15, 2023
Generate runtime_id if not provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Readiness checklist