Fix misbehaviour with 256+ hooks on a same function #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
pierotibou
reviewed
Nov 21, 2022
| @@ -0,0 +1,26 @@ | |||
| --TEST-- | |||
| The tracer should not crash when many hooks are installed | |||
There was a problem hiding this comment.
Out of curiosity, did this test failed consistently before fixing?
There was a problem hiding this comment.
Yes. (it did not crash, but create two spans)
| @@ -184,12 +184,13 @@ void ddtrace_open_span(ddtrace_span_data *span) { | |||
| ddtrace_set_global_span_properties(span); | |||
| } | |||
|
|
|||
| // += 2 increment to avoid zval type ever being 0 | |||
There was a problem hiding this comment.
That looks like magic :)
There was a problem hiding this comment.
Yes, I don't like it very much, but it works. But that's why there's a comment.
morrisonlevi
approved these changes
Nov 22, 2022
morrisonlevi
added
🐛 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Might also crash sometimes.
Readiness checklist
Reviewer checklist