Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix $integration->setError() to also accept \Error instances #1802

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix $integration->setError() to also accept \Error instances #1802

merged 1 commit into from
Nov 17, 2022

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 17, 2022

Description

We got a report that sometimes Symfony may emit \Error objects, which then emits another TypeError here.

I'm not sure exactly on how we get there, so, no test attached.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.82.0 milestone Nov 17, 2022
@bwoebi bwoebi requested a review from a team as a code owner November 17, 2022 11:48
realFlowControl
realFlowControl approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@bwoebi bwoebi merged commit 472335a into master Nov 17, 2022
@bwoebi bwoebi deleted the bob/integration-set-error branch November 17, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realFlowControl realFlowControl realFlowControl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.82.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bwoebi @realFlowControl