-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support to DD_AGENT_HOST #1707
Conversation
I just noticed I wasn't getting APM logs, and I found this in the phpinfo() logs:
datadog.agent_host is set to 2a05:d01c:0000:0000:0000:0000:44d5:56b0 So the URL isn't being formatted correctly, even after this patch? I verified with the latest 0.81.1 as well. |
@NickStallman Note that this patch wasn't merged. We still want to, but we need to update the profiler too (using the same configs). I haven't gotten to it yet. |
Ahh I just noticed that. It'll be good once it's merged as right now I can't (very easily) use APM on a new Kubernetes cluster. Thanks |
Fixes #1667 Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
7e44393
to
4af8837
Compare
4af8837
to
60c3eb3
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
60c3eb3
to
6d0ff43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some tests for the detect_uri_from_config()
function in the profiler.
LGTM 🚀
Description
Fixes #1667.
Readiness checklist
Reviewer checklist