Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to DD_AGENT_HOST #1707

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Aug 22, 2022

Description

Fixes #1667.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added this to the 0.78.0 milestone Aug 22, 2022
@bwoebi bwoebi requested a review from a team as a code owner August 22, 2022 16:16
@bwoebi bwoebi modified the milestones: 0.78.0, future Aug 22, 2022
@krakjoe krakjoe modified the milestones: future, 0.79.0 Aug 24, 2022
@bwoebi bwoebi modified the milestones: 0.79.0, future Sep 6, 2022
@NickStallman
Copy link

I just noticed I wasn't getting APM logs, and I found this in the phpinfo() logs:

{
  "date": "2022-11-08T01:55:34Z",
  "os_name": "Linux app-7fc989d984-6pddh 5.4.196-108.356.amzn2.x86_64 #1 SMP Thu May 26 12:49:47 UTC 2022 x86_64",
  "os_version": "5.4.196-108.356.amzn2.x86_64",
  "version": "0.81.1",
  "lang": "php",
  "lang_version": "7.4.30",
  "env": "produk",
  "enabled": true,
  "service": "app",
  "enabled_cli": false,
  "agent_url": "http://2a05:d01c:0000:0000:0000:0000:44d5:56b0:8126",
  "debug": false,
  "analytics_enabled": false,
  "sample_rate": 1,
  "sampling_rules": [],
  "tags": [],
  "service_mapping": [],
  "distributed_tracing_enabled": true,
  "priority_sampling_enabled": true,
  "dd_version": "27c7ce36",
  "architecture": "x86_64",
  "sapi": "apache2handler",
  "datadog.trace.request_init_hook": "/opt/datadog-php/dd-trace-sources/bridge/dd_wrap_autoloader.php",
  "open_basedir_configured": false,
  "uri_fragment_regex": null,
  "uri_mapping_incoming": null,
  "uri_mapping_outgoing": null,
  "auto_flush_enabled": false,
  "generate_root_span": true,
  "http_client_split_by_domain": true,
  "measure_compile_time": true,
  "report_hostname_on_root_span": false,
  "traced_internal_functions": null,
  "auto_prepend_file_configured": false,
  "integrations_disabled": "default",
  "enabled_from_env": true,
  "opcache.file_cache": null,
  "agent_error": "URL using bad/illegal format or missing URL"
}

datadog.agent_host is set to 2a05:d01c:0000:0000:0000:0000:44d5:56b0

So the URL isn't being formatted correctly, even after this patch? I verified with the latest 0.81.1 as well.

@bwoebi
Copy link
Collaborator Author

bwoebi commented Nov 8, 2022

@NickStallman Note that this patch wasn't merged. We still want to, but we need to update the profiler too (using the same configs). I haven't gotten to it yet.

@NickStallman
Copy link

Ahh I just noticed that. It'll be good once it's merged as right now I can't (very easily) use APM on a new Kubernetes cluster. Thanks

@bwoebi bwoebi modified the milestones: future, 0.85.0 Feb 3, 2023
Fixes #1667

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/agent_host-ipv6 branch from 7e44393 to 4af8837 Compare February 9, 2023 23:50
@bwoebi bwoebi requested a review from a team as a code owner February 9, 2023 23:50
@bwoebi bwoebi force-pushed the bob/agent_host-ipv6 branch from 4af8837 to 60c3eb3 Compare February 9, 2023 23:51
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/agent_host-ipv6 branch from 60c3eb3 to 6d0ff43 Compare February 9, 2023 23:52
Copy link
Member

@realFlowControl realFlowControl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some tests for the detect_uri_from_config() function in the profiler.
LGTM 🚀

@realFlowControl realFlowControl merged commit df8acfd into master Feb 16, 2023
@realFlowControl realFlowControl deleted the bob/agent_host-ipv6 branch February 16, 2023 12:31
@bwoebi bwoebi mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] agent_url issue with ipv6 only Kubernetes
4 participants