Laravel pipelines tracer supporting configurable handler method. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
changed the title
labbati
commented
Nov 30, 2018
SammyK
previously approved these changes
Nov 30, 2018
|
|
||
| /** | ||
| */ | ||
| class PipelineTracingTest extends TestCase |
There was a problem hiding this comment.
The file name PipeTracingTest.php doesn't match the class name. :)
|
@SammyK I fixed the class name, whenever you are available I would like to have your final approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to #157 for an explanation of the issue.
Readiness checklist