[Integration] Add Guzzle v5 integration #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyK
force-pushed
the
integration-guzzle-v5
branch
from
7829665 to
4801264
Compare
labbati
requested changes
Nov 28, 2018
| public static function setDefaultTags(Span $span, $method) | ||
| { | ||
| parent::setDefaultTags($span, $method); | ||
| $span->setTag(Tags\SPAN_TYPE, Types\GUZZLE); |
There was a problem hiding this comment.
The type should be http for consistency with what other languages do for http client integrations
SammyK
force-pushed
the
integration-guzzle-v5
branch
from
11e1b1d to
b2bdc04
Compare
labbati
reviewed
Nov 28, 2018
| { | ||
| self::traceMethod('send', function (Span $span, array $args) { | ||
| $span->setTag('http.method', $args[0]->getMethod()); | ||
| $span->setTag('http.url', $args[0]->getUrl()); |
There was a problem hiding this comment.
This I forgot to mention: you can use DDTrace\Http\Urls::sanitize() to sanitize the url before putting it in the tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Guzzle integration for v5. I also created an abstract
Integrationclass that takes on the majority of the boilerplate for the integration without using instances of objects like in #133. If we'd rather not do this change on this PR, let me know and I'll refactor it out. Then we can just try this abstraction in a separate PR. :)