-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SymfonyBundle: Use getenv() to get env variable #143
Conversation
It is common on servers to not populate $_ENV, so `getenv()` is a more reliable way to check an env var. See: https://stackoverflow.com/questions/3780866/why-is-my-env-empty/27077452#27077452
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hinrik thanks for the PR. It is definitely a good idea to not rely on $_ENV
to read values of envs. I suggested minimal changes to the code, then we are ready to merge.
Thanks
Co-Authored-By: hinrik <hinrik.sig@gmail.com>
Co-Authored-By: hinrik <hinrik.sig@gmail.com>
@labbati can we merge now ? When will the next version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this change. Thanks @hinrik!
0.4.2 should be out today unless we found any issue. |
It is common on servers to not populate $_ENV, so
getenv()
is a morereliable way to check an env var.
See: https://stackoverflow.com/questions/3780866/why-is-my-env-empty/27077452#27077452