Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymfonyBundle: Use getenv() to get env variable #143

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

hinrik
Copy link
Contributor

@hinrik hinrik commented Nov 23, 2018

It is common on servers to not populate $_ENV, so getenv() is a more
reliable way to check an env var.

See: https://stackoverflow.com/questions/3780866/why-is-my-env-empty/27077452#27077452

It is common on servers to not populate $_ENV, so `getenv()` is a more
reliable way to check an env var.

See: https://stackoverflow.com/questions/3780866/why-is-my-env-empty/27077452#27077452
Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hinrik thanks for the PR. It is definitely a good idea to not rely on $_ENV to read values of envs. I suggested minimal changes to the code, then we are ready to merge.
Thanks

src/DDTrace/Integrations/Symfony/V4/SymfonyBundle.php Outdated Show resolved Hide resolved
src/DDTrace/Integrations/Symfony/V4/SymfonyBundle.php Outdated Show resolved Hide resolved
labbati and others added 2 commits November 26, 2018 10:40
Co-Authored-By: hinrik <hinrik.sig@gmail.com>
Co-Authored-By: hinrik <hinrik.sig@gmail.com>
@mariuscoto
Copy link

@labbati can we merge now ? When will the next version of dd-trace-php be released ?

Copy link
Member

@labbati labbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this change. Thanks @hinrik!

@labbati labbati added this to the 0.4.2 milestone Nov 26, 2018
@labbati labbati added 🏘 community Contributions from the general community 🎉 new-integration A new integration labels Nov 26, 2018
@labbati
Copy link
Member

labbati commented Nov 26, 2018

@labbati can we merge now ? When will the next version of dd-trace-php be released ?

0.4.2 should be out today unless we found any issue.

@labbati labbati merged commit 455a3ab into DataDog:master Nov 26, 2018
@hinrik hinrik deleted the use_getenv_for_env_var branch November 26, 2018 17:41
bwoebi pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏘 community Contributions from the general community 🎉 new-integration A new integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants