Fix Laravel service name reading from env variable #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Cyvoct <pcyvoct@assessfirst.com>
|
@labbati could this be added to the 0.3 ? |
labbati
reviewed
Nov 15, 2018
docs/getting_started.md
Outdated
| |-----------------------|--------------------|-----------------------------------------| | ||
| | `DD_AGENT_HOST` | `localhost` | The agent host name | | ||
| | `DD_TRACE_AGENT_PORT` | `8126` | The trace agent port number | | ||
| | `ddtrace_app_name` | `framework's name` | The service name (Laravel and Symphony) | |
There was a problem hiding this comment.
We are still having a conversation about how to name the variable, please remove from here for now, while we are still supporting it in the code
|
Please remove that line gtom the main table as that will change almost for sure, our changes will be backward compatible, thugh. |
|
@labbati done 👍 |
Signed-off-by: Patrik Cyvoct <pcyvoct@assessfirst.com>
|
Thanks @Sh4d1 , merging the PR |
labbati
changed the title
labbati
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$_ENVdoes not seem to work, usinggetenvworks better.Signed-off-by: Patrik Cyvoct pcyvoct@assessfirst.com