Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support service split by host in Predis integration #1094

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Support service split by host in Predis integration #1094

merged 4 commits into from
Nov 13, 2020

Conversation

labbati
Copy link
Member

@labbati labbati commented Nov 12, 2020 •
edited by SammyK
Loading

Description

This PR brings the same functionality as implemented for PHPredis #1084 to Predis integration.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati linked an issue Nov 13, 2020 that may be closed by this pull request
[Feature] Allow splitting of Redis services integrations by hostname #1052
Closed
@labbati labbati added this to the 0.51.0 milestone Nov 13, 2020
@labbati labbati added the 🎉 new-integration A new integration label Nov 13, 2020
@labbati labbati changed the title Predis split by host Support service split by host in Predis integration Nov 13, 2020
@labbati labbati marked this pull request as ready for review November 13, 2020 17:22
SammyK
SammyK approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@labbati
Copy link
Member Author

labbati commented Nov 13, 2020

Thanks @SammyK

@labbati labbati merged commit 684578c into master Nov 13, 2020
@labbati labbati deleted the labbati/predis-split-by-host branch November 13, 2020 18:11
This was referenced Jan 26, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SammyK SammyK SammyK approved these changes

Assignees
No one assigned
Labels
🎉 new-integration A new integration
Projects
None yet
Milestone
0.51.0
Development

Successfully merging this pull request may close these issues.

[Feature] Allow splitting of Redis services integrations by hostname
2 participants
@labbati @SammyK