Rename withTracer test method to isolateTracer #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labbati
force-pushed
the
test/refactor-withTracer-method-name
branch
from
ab6b420 to
f9764b3
Compare
Merged
labbati
force-pushed
the
test/refactor-withTracer-method-name
branch
from
f9764b3 to
6074e70
Compare
pawelchcki
requested changes
Nov 9, 2018
|
Assigning back to @pawelchcki as the requested fix has been implemented in the original branch that intended to remove the holds: #102 |
pawelchcki
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #102
This PR just rename the integration tests base method
withTracertoisolateTracerto make naming more expressive. At the same time, after rebasing on master, we also adapted a few lines of code to be compatible with php 5.4.