Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.10.0] Missing file in pecl archive #249

Closed
remicollet opened this issue Jan 22, 2019 · 2 comments · Fixed by #252
Closed

[0.10.0] Missing file in pecl archive #249

remicollet opened this issue Jan 22, 2019 · 2 comments · Fixed by #252
Assignees
@SammyK
Labels
🐛 bug Something isn't working 🥒 PECL Changes related to PECL deployments
Milestone
0.11.0

Comments

@remicollet
Copy link
Contributor 

/dev/shm/BUILD/php-pecl-datadog-trace-0.10.0/NTS/src/ext/ddtrace.c:18:10: fatal error: request_hooks.h: No such file or directory
 #include "request_hooks.h"
          ^~~~~~~~~~~~~~~~~
compilation terminated.
@remicollet
Copy link
Contributor Author

Missing files are:

  • request_hooks.c
  • request_hooks.h

@remicollet remicollet changed the title [0.10.0@ Missing file in pecl archive [0.10.0] Missing file in pecl archive Jan 22, 2019
@SammyK
Copy link
Contributor

SammyK commented Jan 22, 2019

Doh! Thanks for reporting this @remicollet! Working on a fix. :)

@SammyK SammyK mentioned this issue Jan 22, 2019
Closed
@SammyK SammyK added 🐛 bug Something isn't working 🥒 PECL Changes related to PECL deployments labels Jan 22, 2019
@SammyK SammyK self-assigned this Jan 22, 2019
@SammyK SammyK added this to the 0.10.1 milestone Jan 22, 2019
@SammyK SammyK mentioned this issue Jan 22, 2019
Merged
2 tasks
@SammyK SammyK modified the milestone: 0.10.1 Jan 22, 2019
bwoebi pushed a commit that referenced this issue Sep 15, 2023
@estringana
Handle request atomically (#249)
f9fb3c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SammyK SammyK

Labels
🐛 bug Something isn't working 🥒 PECL Changes related to PECL deployments
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Add missing files to PECL releases DataDog/dd-trace-php
2 participants
@remicollet @SammyK