Updating to not run redact code if value is empty

DataDog · Oct 21, 2024 · 9bf828c · 9bf828c
1 parent b7a0f6f
commit 9bf828c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/ext/serializer.c b/ext/serializer.c
@@ -407,8 +407,9 @@ static void dd_add_post_fields_to_meta_recursive(zend_array *meta, const char *t
                 zend_string *postvalconcat = zend_strpprintf(0, "%s=%s", ZSTR_VAL(postkey), ZSTR_VAL(postvalstr));
                 zend_string_release(postvalstr);
 
-                // Match it with the regex to redact if needed
-                if (zai_match_regex(get_DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP(), postvalconcat)) {
+                // Match it with the regex to redact if needed and value is not an empty string
+                zend_string *regex_pattern = get_DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXP();
+                if (strlen(regex_pattern) > 0 && zai_match_regex(regex_pattern, postvalconcat)) {
                     zend_string *replacement = zend_string_init(ZEND_STRL("<redacted>"), 0);
                     dd_add_post_fields_to_meta(meta, type, postkey, replacement);
                     zend_string_release(replacement);