Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent #5223

Merged
merged 8 commits into from
Feb 19, 2025

Conversation

khanayan123
Copy link
Collaborator

@khanayan123 khanayan123 commented Feb 6, 2025

What does this PR do?

Introduces modifications to the DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED extraction logic to ensure all associated system tests successfully pass.

Motivation

Address issues where certain system tests were failing or being skipped due to incorrect behavior of DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED feature

Copy link

github-actions bot commented Feb 6, 2025

Overall package size

Self size: 8.76 MB
Deduped: 94.96 MB
No deduping: 95.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (f06fb27) to head (306434f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5223      +/-   ##
==========================================
- Coverage   82.24%   80.93%   -1.32%     
==========================================
  Files         440      488      +48     
  Lines       19751    21837    +2086     
==========================================
+ Hits        16245    17674    +1429     
- Misses       3506     4163     +657     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 6, 2025

Datadog Report

Branch report: khanayan123/trace-128-bit-consistency
Commit report: bcf6b9d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 669 Passed, 0 Skipped, 16m 23.99s Total Time

@khanayan123 khanayan123 force-pushed the khanayan123/trace-128-bit-consistency branch from 0e831ac to de59f68 Compare February 11, 2025 16:22
@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-19 21:31:38

Comparing candidate commit 306434f in PR branch khanayan123/trace-128-bit-consistency with baseline commit f06fb27 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@khanayan123 khanayan123 changed the title init Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent Feb 11, 2025
@khanayan123 khanayan123 marked this pull request as ready for review February 11, 2025 19:14
@khanayan123 khanayan123 requested a review from a team as a code owner February 11, 2025 19:14
@khanayan123 khanayan123 merged commit 3582be4 into master Feb 19, 2025
395 checks passed
@khanayan123 khanayan123 deleted the khanayan123/trace-128-bit-consistency branch February 19, 2025 21:43
sabrenner pushed a commit that referenced this pull request Feb 24, 2025
* Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent
@sabrenner sabrenner mentioned this pull request Feb 24, 2025
sabrenner pushed a commit that referenced this pull request Feb 24, 2025
* Make DD_TRACE_128_BIT_TRACEID_GENERATION_ENABLED consistent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants