Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test optimization] [SDTEST-1243] Add tag whenever the test service is provided by the user #5191

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 3, 2025

What does this PR do?

Set '_dd.test.is_user_provided_service' to "true" or "false" depending on whether the service tag is user provided or the default one.

Motivation

We want a way to know whether the service that's being sent by the library is user configured or not.

Plugin Checklist

  • Unit tests.

@juan-fernandez juan-fernandez changed the title [test optimization] Add tag whenever the test service is provided by the user [test optimization] [SDTEST-1243] Add tag whenever the test service is provided by the user Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Overall package size

Self size: 8.63 MB
Deduped: 95.03 MB
No deduping: 95.54 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (1b7c421) to head (a505b3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5191   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         482      482           
  Lines       21522    21525    +3     
=======================================
+ Hits        17468    17471    +3     
  Misses       4054     4054           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 3, 2025

Datadog Report

Branch report: juan-fernandez/set-is-user-provided-service
Commit report: 9593901
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 625 Passed, 0 Skipped, 12m 45.1s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2025

Benchmarks

Benchmark execution time: 2025-02-05 13:57:25

Comparing candidate commit a505b3a in PR branch juan-fernandez/set-is-user-provided-service with baseline commit 1b7c421 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 905 metrics, 27 unstable metrics.

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-84.378MB; -66.602MB] or [-8.952%; -7.066%]

@juan-fernandez juan-fernandez marked this pull request as ready for review February 5, 2025 13:43
@juan-fernandez juan-fernandez requested review from a team as code owners February 5, 2025 13:43
@juan-fernandez juan-fernandez merged commit cde9361 into master Feb 5, 2025
355 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/set-is-user-provided-service branch February 5, 2025 14:06
rochdev pushed a commit that referenced this pull request Feb 7, 2025
@rochdev rochdev mentioned this pull request Feb 7, 2025
rochdev pushed a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants