fix(llmobs): tagger reads propogated mlApp and sessionId from registry tags #5102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes tagger logic to read from tagger registry for checking
mlApp
andsessionId
from the parent span instead of from its tags directly (as we did not implement storing tags on the span when we first released the SDK). This change must have been missed in the initial release of the SDK.Additionally, removes a test related to explicit
enable
/disable
calls. We want to move away from that behavior (although it is not documented anyways), and it interferes a bit with this code change (ie, ismlApp
read from a change inenable
or from the parent'smlApp
? This is a bit out of scope and we don't want to advertise thisenable
/disable
behavior anyways).Motivation
Noticed this issue browsing the code for a different issue. No reports for this issue.