[DSM] Set checkpoints for DSM even when there is no context if the service is instrumented and fix typo #4851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In investigating this support ticket, I found an issue with the SQS instrumentation for DSM. There were two issues, one is that if the messages were already parsed, we weren't using that because of a typo. Secondarily, we were not sending DSM checkpoints unless there was a context, which is not what we want to do. If a service is instrumented, we want to send checkpoints, as sometimes customers will instrument their consumers before their producers and we want them to see that DSM is working (even if its less useful without the producers being present)
Motivation
Additional Notes