Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] v4.x iast perf reg #4797

Closed
wants to merge 17 commits into from
Closed

[Do not merge] v4.x iast perf reg #4797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6459067
Upgrade iast rewriter to 2.5.0 (#4761)
iunanua Oct 8, 2024
d281039
try get a dump --cpu-prof
iunanua Oct 18, 2024
10dc8cc
pfff
iunanua Oct 18, 2024
c4ac25e
try
iunanua Oct 21, 2024
6d78a3f
try
iunanua Oct 21, 2024
2574621
try teardown
iunanua Oct 21, 2024
0b72300
try teardown
iunanua Oct 21, 2024
f3a9623
try
iunanua Oct 21, 2024
8bef8a8
try
iunanua Oct 21, 2024
33e3f28
print more info
iunanua Oct 21, 2024
0b17cc4
restore
iunanua Oct 21, 2024
4fdea78
restore meta.json
iunanua Oct 21, 2024
9f94edc
here we go again
iunanua Oct 21, 2024
463d812
try
iunanua Oct 21, 2024
c18cafa
try
iunanua Oct 21, 2024
2de07fc
try
iunanua Oct 21, 2024
f929bfb
Revert "Upgrade iast rewriter to 2.5.0 (#4761)"
iunanua Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions benchmark/sirun/appsec-iast/insecure-bank.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@
app.set('port', port)
const server = http.createServer(app)

process.on('uncaughtException', console.error)

Check failure on line 9 in benchmark/sirun/appsec-iast/insecure-bank.js

View workflow job for this annotation

GitHub Actions / lint 

Unexpected console statement
process.on('unhandledRejection', console.error)

Check failure on line 10 in benchmark/sirun/appsec-iast/insecure-bank.js

View workflow job for this annotation

GitHub Actions / lint 

Unexpected console statement

server.listen(port, () => { server.close() })
70 changes: 6 additions & 64 deletions benchmark/sirun/appsec-iast/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,77 +1,19 @@
{
"name": "appsec-iast",
"cachegrind": false,
"instructions": true,
"iterations": 15,
"instructions": false,
"iterations": 1,
"variants": {
"no-vulnerability-control": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-without-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-without-vulnerability.js\"",
"env": {
"DD_IAST_ENABLED": "0"
}
},
"no-vulnerability-iast-enabled-default-config": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-without-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-without-vulnerability.js\"",
"baseline": "no-vulnerability-control",
"env": {
"DD_IAST_ENABLED": "1"
}
},
"no-vulnerability-iast-enabled-always-active": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-without-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-without-vulnerability.js\"",
"baseline": "no-vulnerability-control",
"env": {
"DD_IAST_ENABLED": "1",
"DD_IAST_REQUEST_SAMPLING": "100",
"DD_IAST_MAX_CONCURRENT_REQUESTS": "1000",
"DD_IAST_MAX_CONTEXT_OPERATIONS": "100"
}
},
"with-vulnerability-control": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-with-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-with-vulnerability.js\"",
"env": {
"DD_IAST_ENABLED": "0"
}
},
"with-vulnerability-iast-enabled-default-config": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-with-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-with-vulnerability.js\"",
"baseline": "with-vulnerability-control",
"env": {
"DD_IAST_ENABLED": "1"
}
},
"with-vulnerability-iast-enabled-always-active": {
"setup": "bash -c \"nohup node client.js >/dev/null 2>&1 &\"",
"run": "node --require ../../../init.js server-with-vulnerability.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js server-with-vulnerability.js\"",
"baseline": "with-vulnerability-control",
"env": {
"DD_IAST_ENABLED": "1",
"DD_IAST_REQUEST_SAMPLING": "100",
"DD_IAST_MAX_CONCURRENT_REQUESTS": "1000",
"DD_IAST_MAX_CONTEXT_OPERATIONS": "100"
}
},
"startup-time-control": {
"run": "node --require ../../../init.js insecure-bank.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js insecure-bank.js\"",
"run": "node --cpu-prof --require ../../../init.js insecure-bank.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --cpu-prof --cpu-prof-name control.cpuprofile --cpu-prof-dir /go/src/github.com/DataDog/apm-reliability/dd-trace-js/platform/artifacts/ --require ../../../init.js insecure-bank.js\"",
"env": {
"DD_IAST_ENABLED": "0"
}
},
"startup-time-iast-enabled": {
"run": "node --require ../../../init.js insecure-bank.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --require ../../../init.js insecure-bank.js\"",
"run": "node --cpu-prof --require ../../../init.js insecure-bank.js",
"run_with_affinity": "bash -c \"taskset -c $CPU_AFFINITY node --cpu-prof --cpu-prof-name iast.cpuprofile --cpu-prof-dir /go/src/github.com/DataDog/apm-reliability/dd-trace-js/platform/artifacts/ --require ../../../init.js insecure-bank.js\"",
"baseline": "startup-time-control",
"env": {
"DD_IAST_ENABLED": "1"
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sirun/run-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function exec (...args) {
if (code === 0) {
resolve()
} else {
reject(new Error('Process exited with non-zero code.'))
reject(new Error(`Process exited with non-zero code. ${code}`))
}
})
})
Expand Down
Loading