Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic userID tracking and blocking + automatic session tracking #4670

Draft
wants to merge 16 commits into
base: new_user_collection
Choose a base branch
from

Conversation

simon-id
Copy link
Member

@simon-id simon-id commented Sep 11, 2024

// TODO: This user ID collection mode must not be limited to user login events and must be applied to automated user tracing if implemented (automated “tracer.set_user(id)”).

What does this PR do?

Motivation

Plugin Checklist

Additional Notes

@simon-id simon-id self-assigned this Sep 11, 2024
@simon-id simon-id changed the title instrument passport Automatic userID blocking Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Overall package size

Self size: 7.86 MB
Deduped: 64.88 MB
No deduping: 65.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2024

Benchmarks

Benchmark execution time: 2024-11-01 01:13:17

Comparing candidate commit 01c8240 in PR branch automatic_userid_blocking with baseline commit d4345ef in branch new_user_collection.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 9 unstable metrics.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (new_user_collection@d4345ef). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ackages/dd-trace/src/appsec/user_tracking/index.js 0.00% 5 Missing ⚠️
packages/dd-trace/src/appsec/sdk/set_user.js 25.00% 3 Missing ⚠️
packages/dd-trace/src/appsec/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             new_user_collection    #4670   +/-   ##
======================================================
  Coverage                       ?   69.71%           
======================================================
  Files                          ?      117           
  Lines                          ?     3821           
  Branches                       ?        0           
======================================================
  Hits                           ?     2664           
  Misses                         ?     1157           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon-id simon-id changed the base branch from master to new_user_collection October 31, 2024 22:59
@simon-id simon-id changed the title Automatic userID blocking Automatic userID blocking + automatic session tracking Nov 1, 2024
@simon-id simon-id changed the title Automatic userID blocking + automatic session tracking Automatic userID tracking and blocking + automatic session tracking Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant