-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nextjs tests flakyness #4411
Conversation
Overall package sizeSelf size: 6.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4411 +/- ##
==========================================
- Coverage 80.42% 71.43% -9.00%
==========================================
Files 3 116 +113
Lines 373 4162 +3789
Branches 33 33
==========================================
+ Hits 300 2973 +2673
- Misses 73 1189 +1116 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-18 16:07:31 Comparing candidate commit 74ac253 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics. |
What does this PR do?
In nextjs tests, instead of start the tests with the first log message, it waits until the message with port number or
Ready in
.It is done in this way because different tests shows different messages when the server has been started:
Motivation
Improve nextjs tests flakyness
Plugin Checklist
Additional Notes