Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nextjs tests flakyness #4411

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Improve nextjs tests flakyness #4411

merged 8 commits into from
Jun 19, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Jun 18, 2024

What does this PR do?

In nextjs tests, instead of start the tests with the first log message, it waits until the message with port number or Ready in.
It is done in this way because different tests shows different messages when the server has been started:

> { address: '127.0.0.1', family: 'IPv4', port: 35947 }

> Listening on port 45469 url: http://127.0.0.1:45469/

>  ✓ Ready in 75ms

Motivation

Improve nextjs tests flakyness

Plugin Checklist

Additional Notes

@uurien uurien changed the title Ignore tests Fixing nextjs flaky tests Jun 18, 2024
Copy link

github-actions bot commented Jun 18, 2024

Overall package size

Self size: 6.71 MB
Deduped: 61.96 MB
No deduping: 62.24 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (5278b1c) to head (2027226).
Report is 4 commits behind head on master.

Current head 2027226 differs from pull request most recent head 74ac253

Please upload reports for the commit 74ac253 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4411      +/-   ##
==========================================
- Coverage   80.42%   71.43%   -9.00%     
==========================================
  Files           3      116     +113     
  Lines         373     4162    +3789     
  Branches       33       33              
==========================================
+ Hits          300     2973    +2673     
- Misses         73     1189    +1116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jun 18, 2024

Benchmarks

Benchmark execution time: 2024-06-18 16:07:31

Comparing candidate commit 74ac253 in PR branch ugaitz/fixing-next-flaky-test with baseline commit 3b479d0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@uurien uurien changed the title Fixing nextjs flaky tests Improve nextjs tests flakyness Jun 18, 2024
@uurien uurien marked this pull request as ready for review June 18, 2024 16:25
@uurien uurien requested review from a team as code owners June 18, 2024 16:25
@uurien uurien merged commit ddb22b0 into master Jun 19, 2024
135 checks passed
@uurien uurien deleted the ugaitz/fixing-next-flaky-test branch June 19, 2024 07:33
tlhunter pushed a commit that referenced this pull request Jun 20, 2024
tlhunter pushed a commit that referenced this pull request Jun 20, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 10, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants