PROF-9791: Recognize DD_PROFILING_ENABLED=auto as an alternative for SSI profiling #4375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 6.62 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-06-05 11:38:25 Comparing candidate commit f07fee9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 4 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
…_ENABLED=profiler
szegedi
force-pushed
the
szegedi/profiling-heuristics-2
branch
from
b4c54ff
to
c5d4970
Compare
szegedi
changed the title
nsavoire
reviewed
Jun 5, 2024
| this._setBoolean(env, 'profiling.ssi', true) | ||
| if (DD_INJECTION_ENABLED.split(',').includes('profiler')) { | ||
| if (DD_PROFILING_ENABLED === 'auto' || DD_INJECTION_ENABLED.split(',').includes('profiler')) { |
There was a problem hiding this comment.
Is it profiler or profiling that must be present in DD_INJECTION_ENABLED ?
There is a profiling here.
There was a problem hiding this comment.
It is 'profiler'. 'profiling' was a bug on my part. I can quickly fix it in this PR.
…eady established env properties.
nsavoire
approved these changes
Jun 5, 2024
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
…SSI profiling (#4375) * Recognize DD_PROFILING_ENABLED=auto as an alternative to DD_INJECTION_ENABLED=profiler * Fix incorrect use of 'profiling' in DD_INJECTION_ENABLED, rely on already established env properties.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
…SSI profiling (#4375) * Recognize DD_PROFILING_ENABLED=auto as an alternative to DD_INJECTION_ENABLED=profiler * Fix incorrect use of 'profiling' in DD_INJECTION_ENABLED, rely on already established env properties.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
…SSI profiling (#4375) * Recognize DD_PROFILING_ENABLED=auto as an alternative to DD_INJECTION_ENABLED=profiler * Fix incorrect use of 'profiling' in DD_INJECTION_ENABLED, rely on already established env properties.
juan-fernandez
pushed a commit
that referenced
this pull request
Jun 5, 2024
…SSI profiling (#4375) * Recognize DD_PROFILING_ENABLED=auto as an alternative to DD_INJECTION_ENABLED=profiler * Fix incorrect use of 'profiling' in DD_INJECTION_ENABLED, rely on already established env properties.
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Library recognizes
DD_PROFILING_ENABLED=autoas an alternative forDD_INJECTION_ENABLED=profiler.Motivation
This will allow us to add
DD_PROFILING_ENABLED=autothrough the agent Linux install script to enable it for testing and private beta users. This is meant to be used until agent can be properly configured to sendDD_INJECTION_ENABLED=profiler