Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Fix selenium when run outside of a supported test framework #4330

Conversation

juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented May 20, 2024

What does this PR do?

  • Check whether traceId is defined before trying to set the cookie used by RUM: traceId will be undefined whenever selenium code is run outside of a test framework.
  • Check whether there are listeners to ciSeleniumDriverGetStartCh: this is unrelated with the bug but it's good practice.

Motivation

Fixes #4329

Plugin Checklist

  • Unit tests.

Copy link

github-actions bot commented May 20, 2024

Overall package size

Self size: 6.48 MB
Deduped: 60.62 MB
No deduping: 60.9 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@juan-fernandez juan-fernandez marked this pull request as ready for review May 20, 2024 10:47
@juan-fernandez juan-fernandez requested review from a team as code owners May 20, 2024 10:47
@pr-commenter
Copy link

pr-commenter bot commented May 20, 2024

Benchmarks

Benchmark execution time: 2024-05-20 11:07:55

Comparing candidate commit ecbb057 in PR branch juan-fernandez/fix-selenium-when-not-used-in-test-framework with baseline commit 3f6ad7e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

tonyredondo
tonyredondo previously approved these changes May 20, 2024
@juan-fernandez juan-fernandez force-pushed the juan-fernandez/fix-selenium-when-not-used-in-test-framework branch from 66cfab7 to ecbb057 Compare May 20, 2024 11:00
@juan-fernandez juan-fernandez merged commit 8f9e558 into master May 20, 2024
113 of 115 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-selenium-when-not-used-in-test-framework branch May 20, 2024 14:43
This was referenced Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with selenium instrumentation
3 participants