-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci-visibility] Add browser name as test configuration in playwright #4048
[ci-visibility] Add browser name as test configuration in playwright #4048
Conversation
Overall package sizeSelf size: 6.03 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4048 +/- ##
=======================================
Coverage 85.29% 85.29%
=======================================
Files 243 243
Lines 10558 10559 +1
Branches 33 33
=======================================
+ Hits 9005 9006 +1
Misses 1553 1553 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-02-12 13:33:15 Comparing candidate commit 0ad113c in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 6 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
What does this PR do?
Add the browser used by playwright as metadata in the test.
Motivation
Other than letting the user know what browser was used and allowing them to filter / query by it, it's important for our definition of test fingerprint: if we don't add this piece of metadata, the same test run for multiple browsers will not be distinguishable in our UI.
Plugin Checklist
Security
Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!