-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the list of env vars for profiler config #4040
Conversation
Overall package sizeSelf size: 6 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-02-08 16:01:02 Comparing candidate commit d63c351 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 257 metrics, 8 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4040 +/- ##
==========================================
- Coverage 85.20% 85.17% -0.03%
==========================================
Files 243 243
Lines 10544 10544
Branches 33 33
==========================================
- Hits 8984 8981 -3
- Misses 1560 1563 +3 ☔ View full report in Codecov by Sentry. |
What does this PR do?
Increases readability of the (large list) of env vars by sorting them alphabetically.
Motivation
There's a lot of them by now, so for readability – and to make it trivial to figure out where to add new ones – we should keep them sorted.
Security
Datadog employees:
@DataDog/security-design-and-guidance
.