Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb-core: fix serialization of BigInt values in query #3575

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Aug 23, 2023

What does this PR do?

Motivation

  • dd-trace attempts to pass a BigInt instance to JSON.stringify() which then throws an error

Plugin Checklist

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Overall package size

Self size: 5.1 MB
Deduped: 59 MB
No deduping: 59.1 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.2.0 10.8 MB 11.64 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@tlhunter tlhunter changed the title Pr/3550 mongodb-core: fix serialization of BigInt values in query Aug 23, 2023
@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2023

Benchmarks

Benchmark execution time: 2023-08-23 20:45:23

Comparing candidate commit ea2901c in PR branch pr/3550 with baseline commit 244a0ea in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 477 metrics, 15 unstable metrics.

@tlhunter tlhunter merged commit ab10fe0 into master Aug 23, 2023
101 checks passed
@tlhunter tlhunter deleted the pr/3550 branch August 23, 2023 20:55
ida613 pushed a commit that referenced this pull request Aug 25, 2023
* fixing the BigInt mongo sanitization issue
* mongodb-core: adding a test for the BigInt fix

---------

Co-authored-by: Amjad Mahfoud <amjad.mahfoud@neofinancial.com>
@ida613 ida613 mentioned this pull request Aug 25, 2023
ida613 pushed a commit that referenced this pull request Aug 25, 2023
* fixing the BigInt mongo sanitization issue
* mongodb-core: adding a test for the BigInt fix

---------

Co-authored-by: Amjad Mahfoud <amjad.mahfoud@neofinancial.com>
@ida613 ida613 mentioned this pull request Aug 25, 2023
tlhunter added a commit that referenced this pull request Aug 25, 2023
* fixing the BigInt mongo sanitization issue
* mongodb-core: adding a test for the BigInt fix

---------

Co-authored-by: Amjad Mahfoud <amjad.mahfoud@neofinancial.com>
tlhunter added a commit that referenced this pull request Aug 25, 2023
* fixing the BigInt mongo sanitization issue
* mongodb-core: adding a test for the BigInt fix

---------

Co-authored-by: Amjad Mahfoud <amjad.mahfoud@neofinancial.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB BigInt query
3 participants