Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in http2 plugin when instrumented mid-request #3488

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 29, 2023

What does this PR do?

Fix error in http2 plugin when instrumented mid-request.

Motivation

Fixes #3451

@github-actions
Copy link

Overall package size

Self size: 4.98 MB
Deduped: 58.74 MB
No deduping: 58.83 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.1.0 10.66 MB 11.5 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.1 40.97 kB 704.35 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #3488 (37cab4d) into master (5562378) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3488   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files         218      218           
  Lines        8636     8636           
  Branches       33       33           
=======================================
  Hits         7291     7291           
  Misses       1345     1345           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jul 29, 2023

Benchmarks

Benchmark execution time: 2023-07-29 17:45:48

Comparing candidate commit 37cab4d in PR branch fix-http2-async-start-without-start with baseline commit 5562378 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 470 metrics, 22 unstable metrics.

@rochdev rochdev merged commit ec0f3dc into master Jul 31, 2023
102 of 103 checks passed
@rochdev rochdev deleted the fix-http2-async-start-without-start branch July 31, 2023 14:35
This was referenced Aug 25, 2023
@wconti27 wconti27 mentioned this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dd-trace >= 4.7.0 crashes with TypeError: Cannot read properties of undefined (reading 'span')
2 participants