Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate CI tags before sending them #3310

Merged
merged 19 commits into from
Jul 10, 2023
Merged

Conversation

ericlaz
Copy link
Contributor

@ericlaz ericlaz commented Jun 29, 2023

What does this PR do?

Validate that URL tags are valid before sending them in order to prevent undefined errors

Motivation

Multiple undefined instances of CI span tags of Git Repo URL type specifically

@ericlaz ericlaz requested a review from a team as a code owner June 29, 2023 10:16
@ericlaz ericlaz changed the title prevent CI tags before sending them validate CI tags before sending them Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Overall package size

Self size: 4.81 MB
Deduped: 61.55 MB
No deduping: 61.64 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3310 (7d8d26b) into master (a629586) will decrease coverage by 13.17%.
The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           master    #3310       +/-   ##
===========================================
- Coverage   84.18%   71.01%   -13.17%     
===========================================
  Files         205      199        -6     
  Lines        8061     7608      -453     
  Branches       33       33               
===========================================
- Hits         6786     5403     -1383     
- Misses       1275     2205      +930     
Impacted Files Coverage Δ
packages/dd-trace/src/plugins/util/ci.js 97.52% <0.00%> (ø)
packages/dd-trace/src/plugins/util/test.js 73.49% <100.00%> (+3.63%) ⬆️
...ges/dd-trace/src/plugins/util/user-provided-git.js 100.00% <100.00%> (+10.81%) ⬆️

... and 53 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juan-fernandez juan-fernandez self-requested a review June 29, 2023 10:31
@juan-fernandez juan-fernandez marked this pull request as draft June 29, 2023 10:32
@pr-commenter
Copy link

pr-commenter bot commented Jun 29, 2023

Benchmarks

Comparing candidate commit d1c3bc0 in PR branch eric-navarro/remove-invalid-values with baseline commit a629586 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 465 metrics, 27 unstable metrics.

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/ci.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
ericlaz and others added 12 commits June 30, 2023 17:05
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! Left some minor comments

packages/dd-trace/src/plugins/util/ci.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
packages/dd-trace/src/plugins/util/test.js Outdated Show resolved Hide resolved
juan-fernandez and others added 2 commits July 7, 2023 10:29
Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
@juan-fernandez juan-fernandez marked this pull request as ready for review July 7, 2023 15:20
@ericlaz ericlaz merged commit fc3d0ea into master Jul 10, 2023
@ericlaz ericlaz deleted the eric-navarro/remove-invalid-values branch July 10, 2023 08:45
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
This was referenced Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 11, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 14, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 14, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Qard pushed a commit that referenced this pull request Jul 14, 2023
* ciapp-3571: add url validator

* ciapp-3571: add url validator and change tests from ci-spec

* fix variables to follow camelcase

* Remove valid import

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Remove unnecessary check for CI_PIPELINE_URL

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Format typo

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Use validateMetadata return directly

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* use new ci-spec JSONs

* fix spacing and sort imports

* add test to validateMetadata

* Update JSONs and refactor URL checking

* Update JSONs and refactor URL checking

* Add URL validation tests

* Apply suggestions from code review

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>

* Add tag to test suite

---------

Co-authored-by: Juan Antonio Fernández de Alba <juan.fernandezdealba@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants