Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix s3 package upload #3218

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix s3 package upload #3218

merged 2 commits into from
Jun 23, 2023

Conversation

randomanderson
Copy link
Contributor

What does this PR do?

The package upload to s3 fails because the product name auto_inject-node is inconsistent with the package name datadog-apm-library-js.

This PR relies on https://github.com/DataDog/auto_inject/pull/68

@randomanderson randomanderson requested a review from a team as a code owner June 7, 2023 13:22
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Overall package size

Self size: 4.41 MB
Deduped: 60.87 MB
No deduping: 60.92 MB

Dependency sizes

name version self size total size
@datadog/pprof 2.2.3 14.25 MB 15.13 MB
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
protobufjs 7.1.2 2.76 MB 6.55 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #3218 (8ad7447) into master (4e46109) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
+ Coverage   85.71%   85.75%   +0.03%     
==========================================
  Files         196      196              
  Lines        7572     7572              
  Branches       33       33              
==========================================
+ Hits         6490     6493       +3     
+ Misses       1082     1079       -3     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pr-commenter
Copy link

pr-commenter bot commented Jun 7, 2023

Benchmarks

Comparing candidate commit 8ad7447 in PR branch landerson/fix-package-upload with baseline commit 4e46109 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 466 metrics, 26 unstable metrics.

@tlhunter
Copy link
Member

follow up to #3189

@tlhunter tlhunter merged commit d59cd30 into master Jun 23, 2023
@tlhunter tlhunter deleted the landerson/fix-package-upload branch June 23, 2023 18:36
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 29, 2023
This was referenced Jun 29, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
tlhunter pushed a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants