Skip to content

Commit

Permalink
add comment for later
Browse files Browse the repository at this point in the history
  • Loading branch information
simon-id authored Oct 31, 2024
1 parent cceac23 commit 654d260
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/datadog-instrumentations/src/passport.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ function wrapDone (done) {
return function wrappedDone (err, user) {
if (user) {
const abortController = new AbortController()

// express-session middleware sets req.sessionID, it's required to use passport sessions anyway so might as well use it ?

Check failure on line 24 in packages/datadog-instrumentations/src/passport.js

View workflow job for this annotation

GitHub Actions / lint

This line has a length of 127. Maximum allowed is 120

Check failure on line 25 in packages/datadog-instrumentations/src/passport.js

View workflow job for this annotation

GitHub Actions / lint

Trailing spaces not allowed
channel.publish({ req, user, abortController })

Check failure on line 26 in packages/datadog-instrumentations/src/passport.js

View workflow job for this annotation

GitHub Actions / lint

'channel' is not defined

Check failure on line 26 in packages/datadog-instrumentations/src/passport.js

View workflow job for this annotation

GitHub Actions / lint

'req' is not defined

Expand Down

0 comments on commit 654d260

Please sign in to comment.