-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable API Security by default #8511
Draft
smola
wants to merge
1
commit into
master
Choose a base branch
from
smola/enable-api-security-by-default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040399
Total [baseline] (10.471 s) : 0, 10470606
Agent [candidate] (1.04 s) : 0, 1039795
Total [candidate] (10.495 s) : 0, 10494895
section appsec
Agent [baseline] (1.182 s) : 0, 1181739
Total [baseline] (10.774 s) : 0, 10774410
Agent [candidate] (1.186 s) : 0, 1185876
Total [candidate] (10.7 s) : 0, 10700161
section iast
Agent [baseline] (1.187 s) : 0, 1186859
Total [baseline] (10.978 s) : 0, 10978108
Agent [candidate] (1.181 s) : 0, 1180744
Total [candidate] (10.984 s) : 0, 10984305
section profiling
Agent [baseline] (1.266 s) : 0, 1265672
Total [baseline] (10.874 s) : 0, 10874428
Agent [candidate] (1.262 s) : 0, 1261907
Total [candidate] (10.968 s) : 0, 10967697
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.01 ms) : 0, 717010
BytebuddyAgent [candidate] (717.307 ms) : 0, 717307
GlobalTracer [baseline] (240.205 ms) : 0, 240205
GlobalTracer [candidate] (239.729 ms) : 0, 239729
AppSec [baseline] (55.954 ms) : 0, 55954
AppSec [candidate] (55.544 ms) : 0, 55544
Remote Config [baseline] (694.279 µs) : 0, 694
Remote Config [candidate] (694.183 µs) : 0, 694
Telemetry [baseline] (11.551 ms) : 0, 11551
Telemetry [candidate] (11.548 ms) : 0, 11548
section appsec
BytebuddyAgent [baseline] (733.972 ms) : 0, 733972
BytebuddyAgent [candidate] (736.736 ms) : 0, 736736
GlobalTracer [baseline] (236.022 ms) : 0, 236022
GlobalTracer [candidate] (236.732 ms) : 0, 236732
AppSec [baseline] (177.022 ms) : 0, 177022
AppSec [candidate] (177.64 ms) : 0, 177640
Remote Config [baseline] (659.864 µs) : 0, 660
Remote Config [candidate] (663.366 µs) : 0, 663
Telemetry [baseline] (8.301 ms) : 0, 8301
Telemetry [candidate] (8.339 ms) : 0, 8339
IAST [baseline] (21.696 ms) : 0, 21696
IAST [candidate] (21.533 ms) : 0, 21533
section iast
BytebuddyAgent [baseline] (848.152 ms) : 0, 848152
BytebuddyAgent [candidate] (842.149 ms) : 0, 842149
GlobalTracer [baseline] (232.446 ms) : 0, 232446
GlobalTracer [candidate] (232.822 ms) : 0, 232822
AppSec [baseline] (58.107 ms) : 0, 58107
AppSec [candidate] (57.031 ms) : 0, 57031
Remote Config [baseline] (633.524 µs) : 0, 634
Remote Config [candidate] (633.81 µs) : 0, 634
Telemetry [baseline] (8.944 ms) : 0, 8944
Telemetry [candidate] (8.936 ms) : 0, 8936
IAST [baseline] (23.335 ms) : 0, 23335
IAST [candidate] (24.022 ms) : 0, 24022
section profiling
BytebuddyAgent [baseline] (711.441 ms) : 0, 711441
BytebuddyAgent [candidate] (710.7 ms) : 0, 710700
GlobalTracer [baseline] (351.566 ms) : 0, 351566
GlobalTracer [candidate] (350.538 ms) : 0, 350538
AppSec [baseline] (55.668 ms) : 0, 55668
AppSec [candidate] (54.601 ms) : 0, 54601
Remote Config [baseline] (682.506 µs) : 0, 683
Remote Config [candidate] (682.047 µs) : 0, 682
Telemetry [baseline] (9.113 ms) : 0, 9113
Telemetry [candidate] (9.066 ms) : 0, 9066
ProfilingAgent [baseline] (96.577 ms) : 0, 96577
ProfilingAgent [candidate] (95.978 ms) : 0, 95978
Profiling [baseline] (96.603 ms) : 0, 96603
Profiling [candidate] (96.002 ms) : 0, 96002
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047150
Total [baseline] (8.656 s) : 0, 8655598
Agent [candidate] (1.039 s) : 0, 1038855
Total [candidate] (8.652 s) : 0, 8651794
section iast
Agent [baseline] (1.176 s) : 0, 1175671
Total [baseline] (9.226 s) : 0, 9225796
Agent [candidate] (1.172 s) : 0, 1172500
Total [candidate] (9.247 s) : 0, 9247491
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172240
Total [baseline] (9.209 s) : 0, 9209460
Agent [candidate] (1.171 s) : 0, 1170753
Total [candidate] (9.218 s) : 0, 9218413
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173557
Total [baseline] (9.248 s) : 0, 9247556
Agent [candidate] (1.164 s) : 0, 1164431
Total [candidate] (9.24 s) : 0, 9239866
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.167 ms) : 0, 725167
BytebuddyAgent [candidate] (715.949 ms) : 0, 715949
GlobalTracer [baseline] (239.99 ms) : 0, 239990
GlobalTracer [candidate] (239.386 ms) : 0, 239386
AppSec [baseline] (55.532 ms) : 0, 55532
AppSec [candidate] (55.677 ms) : 0, 55677
Remote Config [baseline] (690.282 µs) : 0, 690
Remote Config [candidate] (684.92 µs) : 0, 685
Telemetry [baseline] (10.722 ms) : 0, 10722
Telemetry [candidate] (12.242 ms) : 0, 12242
section iast
BytebuddyAgent [baseline] (840.489 ms) : 0, 840489
BytebuddyAgent [candidate] (836.704 ms) : 0, 836704
GlobalTracer [baseline] (231.033 ms) : 0, 231033
GlobalTracer [candidate] (231.212 ms) : 0, 231212
IAST [baseline] (22.642 ms) : 0, 22642
IAST [candidate] (22.763 ms) : 0, 22763
AppSec [baseline] (57.173 ms) : 0, 57173
AppSec [candidate] (57.493 ms) : 0, 57493
Remote Config [baseline] (612.047 µs) : 0, 612
Remote Config [candidate] (610.775 µs) : 0, 611
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.694 ms) : 0, 8694
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.061 ms) : 0, 838061
BytebuddyAgent [candidate] (835.456 ms) : 0, 835456
GlobalTracer [baseline] (230.031 ms) : 0, 230031
GlobalTracer [candidate] (230.803 ms) : 0, 230803
IAST [baseline] (22.742 ms) : 0, 22742
IAST [candidate] (22.854 ms) : 0, 22854
AppSec [baseline] (57.083 ms) : 0, 57083
AppSec [candidate] (57.332 ms) : 0, 57332
Remote Config [baseline] (600.976 µs) : 0, 601
Remote Config [candidate] (618.388 µs) : 0, 618
Telemetry [baseline] (8.709 ms) : 0, 8709
Telemetry [candidate] (8.666 ms) : 0, 8666
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (838.471 ms) : 0, 838471
BytebuddyAgent [candidate] (831.677 ms) : 0, 831677
GlobalTracer [baseline] (231.28 ms) : 0, 231280
GlobalTracer [candidate] (229.904 ms) : 0, 229904
IAST [baseline] (24.655 ms) : 0, 24655
IAST [candidate] (24.443 ms) : 0, 24443
AppSec [baseline] (54.858 ms) : 0, 54858
AppSec [candidate] (53.615 ms) : 0, 53615
Remote Config [baseline] (616.958 µs) : 0, 617
Remote Config [candidate] (597.905 µs) : 0, 598
Telemetry [baseline] (8.643 ms) : 0, 8643
Telemetry [candidate] (8.51 ms) : 0, 8510
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section baseline
no_agent (386.386 µs) : 366, 407
. : milestone, 386,
iast (515.971 µs) : 494, 538
. : milestone, 516,
iast_FULL (735.335 µs) : 713, 758
. : milestone, 735,
iast_GLOBAL (570.791 µs) : 549, 593
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (522.132 µs) : 501, 544
. : milestone, 522,
iast_INACTIVE (468.513 µs) : 447, 490
. : milestone, 469,
iast_TELEMETRY_OFF (503.482 µs) : 480, 526
. : milestone, 503,
tracing (470.896 µs) : 450, 492
. : milestone, 471,
section candidate
no_agent (383.038 µs) : 362, 404
. : milestone, 383,
iast (521.623 µs) : 499, 544
. : milestone, 522,
iast_FULL (736.819 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (574.592 µs) : 553, 596
. : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (521.349 µs) : 500, 543
. : milestone, 521,
iast_INACTIVE (470.396 µs) : 448, 492
. : milestone, 470,
iast_TELEMETRY_OFF (509.667 µs) : 487, 532
. : milestone, 510,
tracing (462.247 µs) : 441, 484
. : milestone, 462,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section baseline
no_agent (1.364 ms) : 1345, 1384
. : milestone, 1364,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.736 ms) : 1711, 1760
. : milestone, 1736,
code_origins (1.712 ms) : 1678, 1747
. : milestone, 1712,
iast (1.534 ms) : 1510, 1558
. : milestone, 1534,
profiling (1.518 ms) : 1494, 1541
. : milestone, 1518,
tracing (1.478 ms) : 1453, 1504
. : milestone, 1478,
section candidate
no_agent (1.368 ms) : 1347, 1388
. : milestone, 1368,
appsec (1.761 ms) : 1737, 1784
. : milestone, 1761,
appsec_no_iast (1.763 ms) : 1739, 1787
. : milestone, 1763,
code_origins (1.684 ms) : 1651, 1716
. : milestone, 1684,
iast (1.519 ms) : 1495, 1543
. : milestone, 1519,
profiling (1.531 ms) : 1508, 1554
. : milestone, 1531,
tracing (1.495 ms) : 1470, 1520
. : milestone, 1495,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.335 ms) : 2292, 2379
. : milestone, 2335,
iast (2.116 ms) : 2061, 2171
. : milestone, 2116,
iast_GLOBAL (2.152 ms) : 2097, 2208
. : milestone, 2152,
profiling (2.454 ms) : 2272, 2635
. : milestone, 2454,
tracing (1.943 ms) : 1902, 1985
. : milestone, 1943,
section candidate
no_agent (1.473 ms) : 1462, 1484
. : milestone, 1473,
appsec (2.346 ms) : 2303, 2390
. : milestone, 2346,
iast (2.11 ms) : 2055, 2165
. : milestone, 2110,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (1.982 ms) : 1937, 2026
. : milestone, 1982,
tracing (1.959 ms) : 1917, 2001
. : milestone, 1959,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~70381c5e78, baseline=1.47.0-SNAPSHOT~7787c9ddf9
dateFormat X
axisFormat %s
section baseline
no_agent (14.82 s) : 14820000, 14820000
. : milestone, 14820000,
appsec (15.312 s) : 15312000, 15312000
. : milestone, 15312000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (18.179 s) : 18179000, 18179000
. : milestone, 18179000,
profiling (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
tracing (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
section candidate
no_agent (15.61 s) : 15610000, 15610000
. : milestone, 15610000,
appsec (15.09 s) : 15090000, 15090000
. : milestone, 15090000,
iast (18.364 s) : 18364000, 18364000
. : milestone, 18364000,
iast_GLOBAL (18.286 s) : 18286000, 18286000
. : milestone, 18286000,
profiling (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
tracing (15.055 s) : 15055000, 15055000
. : milestone, 15055000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]