Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add In-Product Enablement (#8461)" #8509

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Revert "Add In-Product Enablement (#8461)" #8509

merged 2 commits into from
Mar 4, 2025

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Mar 4, 2025

This reverts commit dceca28.

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@jpbempel jpbempel requested review from a team as code owners March 4, 2025 20:32
@jpbempel jpbempel requested review from evanchooly and smola and removed request for a team March 4, 2025 20:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mcculls mcculls added the comp: debugger Dynamic Instrumentation label Mar 4, 2025
@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2025

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1741121253 1741121623
end_time 2025-03-04T20:48:51 2025-03-04T20:55:01
git_branch master jpbempel/revert-inproduct
git_commit_sha 951960b 0e7e060
start_time 2025-03-04T20:47:34 2025-03-04T20:53:44
See matching parameters
Baseline Candidate
ci_job_id 832677389 832677389
ci_pipeline_id 57710054 57710054
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1741120665 1741120665

Summary

Found 0 performance improvements and 5 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop worse
[+1.313ms; +1.341ms] or [+13.168%; +13.453%]		 worse
[+1.331ms; +1.405ms] or [+13.143%; +13.876%]		 worse
[+1.278ms; +1.385ms] or [+12.493%; +13.542%]		 worse
[+1.147ms; +2.033ms] or [+10.827%; +19.185%]		 worse
[-12.170op/s; -9.591op/s] or [-12.535%; -9.879%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-37.828µs; +33.481µs] or [-13.500%; +11.949%]		 unstable
[-56.273µs; +43.910µs] or [-17.347%; +13.536%]		 unstable
[-66.642µs; +55.423µs] or [-19.660%; +16.351%]		 unstable
[-461.301µs; +215.518µs] or [-63.174%; +29.514%]		 same
scenario:basic same same same unstable
[-54.448µs; +47.091µs] or [-10.251%; +8.866%]		 unstable
[-236.034op/s; +107.829op/s] or [-9.205%; +4.205%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (324.395 µs) : 269, 380
.   : milestone, 324,
basic (307.207 µs) : 292, 322
.   : milestone, 307,
loop (10.123 ms) : 10087, 10159
.   : milestone, 10123,
section candidate
noprobe (318.214 µs) : 280, 357
.   : milestone, 318,
basic (310.222 µs) : 301, 319
.   : milestone, 310,
loop (11.491 ms) : 11458, 11523
.   : milestone, 11491,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 324.395 µs [268.827 µs, 379.964 µs]
basic 307.207 µs [292.166 µs, 322.248 µs]
loop 10.123 ms [10.087 ms, 10.159 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 318.214 µs [279.891 µs, 356.536 µs]
basic 310.222 µs [301.493 µs, 318.951 µs]
loop 11.491 ms [11.458 ms, 11.523 ms]

@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/revert-inproduct
git_commit_date 1741112077 1741120665
git_commit_sha 951960b 0e7e060
release_version 1.47.0-SNAPSHOT~951960b795 1.47.0-SNAPSHOT~0e7e06075a
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741123176 1741123176
ci_job_id 832677383 832677383
ci_pipeline_id 57710054 57710054
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tlq2fia6-project-304-concurrent-0-co4ttt6w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tlq2fia6-project-304-concurrent-0-co4ttt6w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 21 performance improvements and 6 performance regressions! Performance is the same for 28 metrics, 8 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast:Agent better
[-687.164ms; -592.624ms] or [-6.955%; -5.998%]		 9.241s 9.881s
scenario:startup:insecure-bank:iast:Agent.start better
[-92.289ms; -57.852ms] or [-7.364%; -4.616%]		 1.178s 1.253s
scenario:startup:insecure-bank:iast:Remote Config worse
[+88.147µs; +128.106µs] or [+17.278%; +25.110%]		 618.297µs 510.171µs
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Agent better
[-695.984ms; -614.612ms] or [-7.068%; -6.241%]		 9.192s 9.847s
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Agent.start better
[-92.453ms; -82.118ms] or [-7.369%; -6.545%]		 1.167s 1.255s
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Remote Config worse
[+91.073µs; +128.945µs] or [+17.816%; +25.225%]		 621.186µs 511.177µs
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Agent better
[-718.480ms; -535.530ms] or [-7.249%; -5.403%]		 9.284s 9.911s
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Agent.start better
[-111.028ms; -77.234ms] or [-8.815%; -6.132%]		 1.165s 1.260s
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config worse
[+84.377µs; +123.317µs] or [+16.189%; +23.660%]		 625.050µs 521.202µs
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Telemetry better
[-3.553ms; -3.123ms] or [-29.360%; -25.809%]		 8.763ms 12.101ms
scenario:startup:insecure-bank:tracing:Agent better
[-700.133ms; -546.893ms] or [-7.529%; -5.881%]		 8.676s 9.299s
scenario:startup:insecure-bank:tracing:Agent.start better
[-106.041ms; -90.335ms] or [-9.342%; -7.959%]		 1.037s 1.135s
scenario:startup:insecure-bank:tracing:Remote Config worse
[+99.007µs; +142.326µs] or [+16.935%; +24.345%]		 705.286µs 584.620µs
scenario:startup:petclinic:appsec:Agent better
[-1001.570ms; -777.730ms] or [-8.605%; -6.682%]		 10.750s 11.640s
scenario:startup:petclinic:appsec:Agent.start better
[-97.669ms; -81.796ms] or [-7.680%; -6.432%]		 1.182s 1.272s
scenario:startup:petclinic:appsec:Telemetry better
[-4.233ms; -3.877ms] or [-34.245%; -31.358%]		 8.307ms 12.362ms
scenario:startup:petclinic:iast:Agent better
[-1.102s; -0.931s] or [-9.220%; -7.790%]		 10.933s 11.949s
scenario:startup:petclinic:iast:Agent.start better
[-94.560ms; -83.633ms] or [-7.512%; -6.644%]		 1.170s 1.259s
scenario:startup:petclinic:iast:Remote Config worse
[+70.345µs; +102.649µs] or [+13.409%; +19.567%]		 611.102µs 524.605µs
scenario:startup:petclinic:profiling:Agent better
[-1050.550ms; -825.748ms] or [-8.900%; -6.996%]		 10.865s 11.804s
scenario:startup:petclinic:profiling:Agent.start better
[-121.917ms; -106.723ms] or [-8.852%; -7.749%]		 1.263s 1.377s
scenario:startup:petclinic:profiling:ProfilingAgent better
[-28.475ms; -24.239ms] or [-23.154%; -19.710%]		 96.622ms 122.979ms
scenario:startup:petclinic:profiling:Telemetry better
[-3.674ms; -3.145ms] or [-29.308%; -25.082%]		 9.128ms 12.538ms
scenario:startup:petclinic:profiling:Profiling better
[-28.471ms; -24.233ms] or [-23.147%; -19.702%]		 96.648ms 123.000ms
scenario:startup:petclinic:tracing:Agent better
[-1.203s; -0.943s] or [-10.444%; -8.183%]		 10.449s 11.522s
scenario:startup:petclinic:tracing:Agent.start better
[-104.250ms; -75.570ms] or [-9.183%; -6.656%]		 1.045s 1.135s
scenario:startup:petclinic:tracing:Remote Config worse
[+98.300µs; +131.506µs] or [+16.885%; +22.588%]		 697.085µs 582.182µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1135305
Total [baseline] (11.522 s) : 0, 11521842
Agent [candidate] (1.045 s) : 0, 1045395
Total [candidate] (10.449 s) : 0, 10448732
section appsec
Agent [baseline] (1.272 s) : 0, 1271688
Total [baseline] (11.64 s) : 0, 11639740
Agent [candidate] (1.182 s) : 0, 1181956
Total [candidate] (10.75 s) : 0, 10750090
section iast
Agent [baseline] (1.259 s) : 0, 1258758
Total [baseline] (11.949 s) : 0, 11949318
Agent [candidate] (1.17 s) : 0, 1169662
Total [candidate] (10.933 s) : 0, 10933036
section profiling
Agent [baseline] (1.377 s) : 0, 1377252
Total [baseline] (11.804 s) : 0, 11803527
Agent [candidate] (1.263 s) : 0, 1262932
Total [candidate] (10.865 s) : 0, 10865378
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.135 s -
Agent appsec 1.272 s 136.383 ms (12.0%)
Agent iast 1.259 s 123.453 ms (10.9%)
Agent profiling 1.377 s 241.947 ms (21.3%)
Total tracing 11.522 s -
Total appsec 11.64 s 117.898 ms (1.0%)
Total iast 11.949 s 427.476 ms (3.7%)
Total profiling 11.804 s 281.685 ms (2.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.182 s 136.561 ms (13.1%)
Agent iast 1.17 s 124.267 ms (11.9%)
Agent profiling 1.263 s 217.537 ms (20.8%)
Total tracing 10.449 s -
Total appsec 10.75 s 301.358 ms (2.9%)
Total iast 10.933 s 484.304 ms (4.6%)
Total profiling 10.865 s 416.646 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.798 ms) : 0, 716798
BytebuddyAgent [candidate] (720.829 ms) : 0, 720829
GlobalTracer [baseline] (239.147 ms) : 0, 239147
GlobalTracer [candidate] (240.773 ms) : 0, 240773
AppSec [baseline] (55.86 ms) : 0, 55860
AppSec [candidate] (55.84 ms) : 0, 55840
Remote Config [baseline] (582.182 µs) : 0, 582
Remote Config [candidate] (697.085 µs) : 0, 697
Telemetry [baseline] (12.547 ms) : 0, 12547
Telemetry [candidate] (12.286 ms) : 0, 12286
Debugger [baseline] (95.441 ms) : 0, 95441
section appsec
BytebuddyAgent [baseline] (734.097 ms) : 0, 734097
BytebuddyAgent [candidate] (734.151 ms) : 0, 734151
GlobalTracer [baseline] (236.471 ms) : 0, 236471
GlobalTracer [candidate] (236.126 ms) : 0, 236126
IAST [baseline] (21.493 ms) : 0, 21493
IAST [candidate] (21.537 ms) : 0, 21537
AppSec [baseline] (178.127 ms) : 0, 178127
AppSec [candidate] (177.041 ms) : 0, 177041
Remote Config [baseline] (639.873 µs) : 0, 640
Remote Config [candidate] (670.29 µs) : 0, 670
Telemetry [baseline] (12.362 ms) : 0, 12362
Telemetry [candidate] (8.307 ms) : 0, 8307
Debugger [baseline] (84.292 ms) : 0, 84292
section iast
BytebuddyAgent [baseline] (835.898 ms) : 0, 835898
BytebuddyAgent [candidate] (835.295 ms) : 0, 835295
GlobalTracer [baseline] (229.956 ms) : 0, 229956
GlobalTracer [candidate] (229.907 ms) : 0, 229907
IAST [baseline] (22.575 ms) : 0, 22575
IAST [candidate] (22.965 ms) : 0, 22965
AppSec [baseline] (57.257 ms) : 0, 57257
AppSec [candidate] (57.258 ms) : 0, 57258
Remote Config [baseline] (524.605 µs) : 0, 525
Remote Config [candidate] (611.102 µs) : 0, 611
Telemetry [baseline] (14.314 ms) : 0, 14314
Telemetry [candidate] (8.693 ms) : 0, 8693
Debugger [baseline] (83.183 ms) : 0, 83183
section profiling
BytebuddyAgent [baseline] (707.32 ms) : 0, 707320
BytebuddyAgent [candidate] (708.819 ms) : 0, 708819
GlobalTracer [baseline] (349.744 ms) : 0, 349744
GlobalTracer [candidate] (352.278 ms) : 0, 352278
AppSec [baseline] (55.162 ms) : 0, 55162
AppSec [candidate] (54.965 ms) : 0, 54965
Remote Config [baseline] (635.997 µs) : 0, 636
Remote Config [candidate] (677.238 µs) : 0, 677
Telemetry [baseline] (12.538 ms) : 0, 12538
Telemetry [candidate] (9.128 ms) : 0, 9128
Debugger [baseline] (88.476 ms) : 0, 88476
ProfilingAgent [baseline] (122.979 ms) : 0, 122979
ProfilingAgent [candidate] (96.622 ms) : 0, 96622
Profiling [baseline] (123.0 ms) : 0, 123000
Profiling [candidate] (96.648 ms) : 0, 96648
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1135071
Total [baseline] (9.299 s) : 0, 9299223
Agent [candidate] (1.037 s) : 0, 1036883
Total [candidate] (8.676 s) : 0, 8675710
section iast
Agent [baseline] (1.253 s) : 0, 1253272
Total [baseline] (9.881 s) : 0, 9880595
Agent [candidate] (1.178 s) : 0, 1178201
Total [candidate] (9.241 s) : 0, 9240701
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.255 s) : 0, 1254623
Total [baseline] (9.847 s) : 0, 9847407
Agent [candidate] (1.167 s) : 0, 1167338
Total [candidate] (9.192 s) : 0, 9192109
section iast_TELEMETRY_OFF
Agent [baseline] (1.26 s) : 0, 1259558
Total [baseline] (9.911 s) : 0, 9910843
Agent [candidate] (1.165 s) : 0, 1165427
Total [candidate] (9.284 s) : 0, 9283838
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.135 s -
Agent iast 1.253 s 118.2 ms (10.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.255 s 119.552 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.26 s 124.487 ms (11.0%)
Total tracing 9.299 s -
Total iast 9.881 s 581.372 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.847 s 548.184 ms (5.9%)
Total iast_TELEMETRY_OFF 9.911 s 611.62 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.037 s -
Agent iast 1.178 s 141.318 ms (13.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.167 s 130.455 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.165 s 128.544 ms (12.4%)
Total tracing 8.676 s -
Total iast 9.241 s 564.991 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.192 s 516.399 ms (6.0%)
Total iast_TELEMETRY_OFF 9.284 s 608.128 ms (7.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.532 ms) : 0, 717532
BytebuddyAgent [candidate] (715.451 ms) : 0, 715451
GlobalTracer [baseline] (239.401 ms) : 0, 239401
GlobalTracer [candidate] (239.977 ms) : 0, 239977
AppSec [baseline] (55.447 ms) : 0, 55447
AppSec [candidate] (55.776 ms) : 0, 55776
Remote Config [baseline] (584.62 µs) : 0, 585
Remote Config [candidate] (705.286 µs) : 0, 705
Telemetry [baseline] (12.402 ms) : 0, 12402
Telemetry [candidate] (10.095 ms) : 0, 10095
Debugger [baseline] (94.688 ms) : 0, 94688
section iast
BytebuddyAgent [baseline] (832.459 ms) : 0, 832459
BytebuddyAgent [candidate] (842.161 ms) : 0, 842161
GlobalTracer [baseline] (229.651 ms) : 0, 229651
GlobalTracer [candidate] (231.097 ms) : 0, 231097
IAST [baseline] (22.537 ms) : 0, 22537
IAST [candidate] (23.131 ms) : 0, 23131
AppSec [baseline] (56.528 ms) : 0, 56528
AppSec [candidate] (57.403 ms) : 0, 57403
Remote Config [baseline] (510.171 µs) : 0, 510
Remote Config [candidate] (618.297 µs) : 0, 618
Telemetry [baseline] (13.58 ms) : 0, 13580
Telemetry [candidate] (8.792 ms) : 0, 8792
Debugger [baseline] (83.092 ms) : 0, 83092
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.253 ms) : 0, 832253
BytebuddyAgent [candidate] (833.581 ms) : 0, 833581
GlobalTracer [baseline] (229.908 ms) : 0, 229908
GlobalTracer [candidate] (229.707 ms) : 0, 229707
IAST [baseline] (22.773 ms) : 0, 22773
IAST [candidate] (22.79 ms) : 0, 22790
AppSec [baseline] (57.079 ms) : 0, 57079
AppSec [candidate] (57.06 ms) : 0, 57060
Remote Config [baseline] (511.177 µs) : 0, 511
Remote Config [candidate] (621.186 µs) : 0, 621
Telemetry [baseline] (13.519 ms) : 0, 13519
Telemetry [candidate] (8.668 ms) : 0, 8668
Debugger [baseline] (83.597 ms) : 0, 83597
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.671 ms) : 0, 836671
BytebuddyAgent [candidate] (831.678 ms) : 0, 831678
GlobalTracer [baseline] (231.219 ms) : 0, 231219
GlobalTracer [candidate] (229.639 ms) : 0, 229639
IAST [baseline] (24.28 ms) : 0, 24280
IAST [candidate] (24.662 ms) : 0, 24662
AppSec [baseline] (55.698 ms) : 0, 55698
AppSec [candidate] (55.108 ms) : 0, 55108
Remote Config [baseline] (521.202 µs) : 0, 521
Remote Config [candidate] (625.05 µs) : 0, 625
Telemetry [baseline] (12.101 ms) : 0, 12101
Telemetry [candidate] (8.763 ms) : 0, 8763
Debugger [baseline] (83.989 ms) : 0, 83989
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-04T20:48:46 2025-03-04T20:56:41
git_branch master jpbempel/revert-inproduct
git_commit_date 1741112077 1741120665
git_commit_sha 951960b 0e7e060
release_version 1.47.0-SNAPSHOT~951960b795 1.47.0-SNAPSHOT~0e7e06075a
start_time 2025-03-04T20:48:32 2025-03-04T20:56:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741122202 1741122202
ci_job_id 832677384 832677384
ci_pipeline_id 57710054 57710054
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-oxfzpu-project-304-concurrent-2-qkt4mlxx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-oxfzpu-project-304-concurrent-2-qkt4mlxx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795
    dateFormat X
    axisFormat %s
section baseline
no_agent (396.778 µs) : 377, 417
.   : milestone, 397,
iast (520.539 µs) : 498, 543
.   : milestone, 521,
iast_FULL (738.566 µs) : 716, 761
.   : milestone, 739,
iast_GLOBAL (579.791 µs) : 555, 604
.   : milestone, 580,
iast_HARDCODED_SECRET_DISABLED (514.722 µs) : 493, 537
.   : milestone, 515,
iast_INACTIVE (473.442 µs) : 452, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (510.459 µs) : 488, 533
.   : milestone, 510,
tracing (465.36 µs) : 444, 487
.   : milestone, 465,
section candidate
no_agent (388.118 µs) : 368, 408
.   : milestone, 388,
iast (518.983 µs) : 497, 541
.   : milestone, 519,
iast_FULL (737.274 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (572.339 µs) : 549, 596
.   : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (516.625 µs) : 494, 539
.   : milestone, 517,
iast_INACTIVE (478.907 µs) : 457, 500
.   : milestone, 479,
iast_TELEMETRY_OFF (514.259 µs) : 492, 536
.   : milestone, 514,
tracing (459.48 µs) : 439, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 396.778 µs [377.028 µs, 416.528 µs] -
iast 520.539 µs [498.231 µs, 542.847 µs] 123.761 µs (31.2%)
iast_FULL 738.566 µs [716.364 µs, 760.768 µs] 341.788 µs (86.1%)
iast_GLOBAL 579.791 µs [555.234 µs, 604.347 µs] 183.012 µs (46.1%)
iast_HARDCODED_SECRET_DISABLED 514.722 µs [492.934 µs, 536.509 µs] 117.943 µs (29.7%)
iast_INACTIVE 473.442 µs [451.993 µs, 494.891 µs] 76.663 µs (19.3%)
iast_TELEMETRY_OFF 510.459 µs [488.037 µs, 532.881 µs] 113.68 µs (28.7%)
tracing 465.36 µs [443.611 µs, 487.11 µs] 68.582 µs (17.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 388.118 µs [368.405 µs, 407.832 µs] -
iast 518.983 µs [497.379 µs, 540.588 µs] 130.865 µs (33.7%)
iast_FULL 737.274 µs [715.345 µs, 759.204 µs] 349.156 µs (90.0%)
iast_GLOBAL 572.339 µs [548.914 µs, 595.765 µs] 184.221 µs (47.5%)
iast_HARDCODED_SECRET_DISABLED 516.625 µs [493.931 µs, 539.319 µs] 128.507 µs (33.1%)
iast_INACTIVE 478.907 µs [457.393 µs, 500.421 µs] 90.789 µs (23.4%)
iast_TELEMETRY_OFF 514.259 µs [492.197 µs, 536.321 µs] 126.141 µs (32.5%)
tracing 459.48 µs [438.962 µs, 479.999 µs] 71.362 µs (18.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0e7e06075a, baseline=1.47.0-SNAPSHOT~951960b795
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1390
.   : milestone, 1370,
appsec (1.742 ms) : 1718, 1765
.   : milestone, 1742,
appsec_no_iast (1.752 ms) : 1728, 1775
.   : milestone, 1752,
code_origins (1.695 ms) : 1661, 1729
.   : milestone, 1695,
iast (1.522 ms) : 1497, 1546
.   : milestone, 1522,
profiling (1.508 ms) : 1483, 1532
.   : milestone, 1508,
tracing (1.504 ms) : 1480, 1527
.   : milestone, 1504,
section candidate
no_agent (1.365 ms) : 1346, 1385
.   : milestone, 1365,
appsec (1.727 ms) : 1702, 1751
.   : milestone, 1727,
appsec_no_iast (1.73 ms) : 1703, 1756
.   : milestone, 1730,
code_origins (1.674 ms) : 1640, 1708
.   : milestone, 1674,
iast (1.514 ms) : 1491, 1538
.   : milestone, 1514,
profiling (1.518 ms) : 1495, 1541
.   : milestone, 1518,
tracing (1.509 ms) : 1485, 1534
.   : milestone, 1509,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.351 ms, 1.39 ms] -
appsec 1.742 ms [1.718 ms, 1.765 ms] 371.17 µs (27.1%)
appsec_no_iast 1.752 ms [1.728 ms, 1.775 ms] 381.523 µs (27.8%)
code_origins 1.695 ms [1.661 ms, 1.729 ms] 324.807 µs (23.7%)
iast 1.522 ms [1.497 ms, 1.546 ms] 151.23 µs (11.0%)
profiling 1.508 ms [1.483 ms, 1.532 ms] 137.18 µs (10.0%)
tracing 1.504 ms [1.48 ms, 1.527 ms] 133.453 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.385 ms] -
appsec 1.727 ms [1.702 ms, 1.751 ms] 361.263 µs (26.5%)
appsec_no_iast 1.73 ms [1.703 ms, 1.756 ms] 364.271 µs (26.7%)
code_origins 1.674 ms [1.64 ms, 1.708 ms] 308.316 µs (22.6%)
iast 1.514 ms [1.491 ms, 1.538 ms] 149.07 µs (10.9%)
profiling 1.518 ms [1.495 ms, 1.541 ms] 152.749 µs (11.2%)
tracing 1.509 ms [1.485 ms, 1.534 ms] 144.188 µs (10.6%)

Dacapo

@jpbempel jpbempel merged commit 7787c9d into master Mar 4, 2025
213 of 214 checks passed
@jpbempel jpbempel deleted the jpbempel/revert-inproduct branch March 4, 2025 21:43
@github-actions github-actions bot added this to the 1.47.0 milestone Mar 4, 2025
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

@smola smola Awaiting requested review from smola smola is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @mcculls