-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable debugger by default if CI Visibility is enabled #8506
Disable debugger by default if CI Visibility is enabled #8506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on perf issue? because there is no reason for this AFAIK
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.134 s) : 0, 1134144
Total [baseline] (9.231 s) : 0, 9230797
Agent [candidate] (1.133 s) : 0, 1133197
Total [candidate] (9.267 s) : 0, 9267417
section iast
Agent [baseline] (1.266 s) : 0, 1266190
Total [baseline] (9.902 s) : 0, 9901549
Agent [candidate] (1.256 s) : 0, 1256267
Total [candidate] (9.868 s) : 0, 9867782
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.262 s) : 0, 1261938
Total [baseline] (9.84 s) : 0, 9840367
Agent [candidate] (1.259 s) : 0, 1259338
Total [candidate] (9.88 s) : 0, 9880431
section iast_TELEMETRY_OFF
Agent [baseline] (1.252 s) : 0, 1251669
Total [baseline] (9.875 s) : 0, 9875316
Agent [candidate] (1.263 s) : 0, 1262532
Total [candidate] (9.91 s) : 0, 9909654
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.295 ms) : 0, 716295
BytebuddyAgent [candidate] (716.014 ms) : 0, 716014
GlobalTracer [baseline] (239.18 ms) : 0, 239180
GlobalTracer [candidate] (239.457 ms) : 0, 239457
AppSec [baseline] (55.45 ms) : 0, 55450
AppSec [candidate] (55.221 ms) : 0, 55221
Debugger [baseline] (95.145 ms) : 0, 95145
Debugger [candidate] (94.538 ms) : 0, 94538
Remote Config [baseline] (610.245 µs) : 0, 610
Remote Config [candidate] (602.501 µs) : 0, 603
Telemetry [baseline] (12.485 ms) : 0, 12485
Telemetry [candidate] (12.36 ms) : 0, 12360
section iast
BytebuddyAgent [baseline] (842.101 ms) : 0, 842101
BytebuddyAgent [candidate] (834.604 ms) : 0, 834604
GlobalTracer [baseline] (230.74 ms) : 0, 230740
GlobalTracer [candidate] (230.061 ms) : 0, 230061
IAST [baseline] (22.86 ms) : 0, 22860
IAST [candidate] (22.71 ms) : 0, 22710
AppSec [baseline] (57.553 ms) : 0, 57553
AppSec [candidate] (56.506 ms) : 0, 56506
Debugger [baseline] (83.487 ms) : 0, 83487
Debugger [candidate] (83.439 ms) : 0, 83439
Remote Config [baseline] (523.91 µs) : 0, 524
Remote Config [candidate] (515.775 µs) : 0, 516
Telemetry [baseline] (13.773 ms) : 0, 13773
Telemetry [candidate] (13.491 ms) : 0, 13491
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.966 ms) : 0, 839966
BytebuddyAgent [candidate] (834.703 ms) : 0, 834703
GlobalTracer [baseline] (230.428 ms) : 0, 230428
GlobalTracer [candidate] (230.546 ms) : 0, 230546
IAST [baseline] (22.767 ms) : 0, 22767
IAST [candidate] (22.912 ms) : 0, 22912
AppSec [baseline] (56.801 ms) : 0, 56801
AppSec [candidate] (57.584 ms) : 0, 57584
Debugger [baseline] (83.479 ms) : 0, 83479
Debugger [candidate] (83.906 ms) : 0, 83906
Remote Config [baseline] (514.28 µs) : 0, 514
Remote Config [candidate] (521.708 µs) : 0, 522
Telemetry [baseline] (12.98 ms) : 0, 12980
Telemetry [candidate] (14.181 ms) : 0, 14181
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.505 ms) : 0, 831505
BytebuddyAgent [candidate] (841.123 ms) : 0, 841123
GlobalTracer [baseline] (229.696 ms) : 0, 229696
GlobalTracer [candidate] (231.261 ms) : 0, 231261
IAST [baseline] (22.421 ms) : 0, 22421
IAST [candidate] (25.681 ms) : 0, 25681
AppSec [baseline] (57.255 ms) : 0, 57255
AppSec [candidate] (53.535 ms) : 0, 53535
Debugger [baseline] (83.326 ms) : 0, 83326
Debugger [candidate] (83.259 ms) : 0, 83259
Remote Config [baseline] (514.235 µs) : 0, 514
Remote Config [candidate] (527.748 µs) : 0, 528
Telemetry [baseline] (12.026 ms) : 0, 12026
Telemetry [candidate] (12.061 ms) : 0, 12061
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.14 s) : 0, 1140380
Total [baseline] (11.537 s) : 0, 11537139
Agent [candidate] (1.153 s) : 0, 1153384
Total [candidate] (11.444 s) : 0, 11443947
section appsec
Agent [baseline] (1.273 s) : 0, 1273479
Total [baseline] (11.588 s) : 0, 11588167
Agent [candidate] (1.274 s) : 0, 1273840
Total [candidate] (11.688 s) : 0, 11687630
section iast
Agent [baseline] (1.266 s) : 0, 1266262
Total [baseline] (11.914 s) : 0, 11914101
Agent [candidate] (1.257 s) : 0, 1256574
Total [candidate] (11.982 s) : 0, 11981645
section profiling
Agent [baseline] (1.393 s) : 0, 1392642
Total [baseline] (11.879 s) : 0, 11879499
Agent [candidate] (1.378 s) : 0, 1378209
Total [candidate] (11.737 s) : 0, 11737101
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.214 ms) : 0, 720214
BytebuddyAgent [candidate] (728.415 ms) : 0, 728415
GlobalTracer [baseline] (240.806 ms) : 0, 240806
GlobalTracer [candidate] (243.459 ms) : 0, 243459
AppSec [baseline] (55.825 ms) : 0, 55825
AppSec [candidate] (56.365 ms) : 0, 56365
Debugger [baseline] (95.318 ms) : 0, 95318
Debugger [candidate] (96.786 ms) : 0, 96786
Remote Config [baseline] (603.594 µs) : 0, 604
Remote Config [candidate] (601.149 µs) : 0, 601
Telemetry [baseline] (12.513 ms) : 0, 12513
Telemetry [candidate] (12.655 ms) : 0, 12655
section appsec
BytebuddyAgent [baseline] (735.831 ms) : 0, 735831
BytebuddyAgent [candidate] (735.96 ms) : 0, 735960
GlobalTracer [baseline] (236.886 ms) : 0, 236886
GlobalTracer [candidate] (236.941 ms) : 0, 236941
AppSec [baseline] (177.705 ms) : 0, 177705
AppSec [candidate] (177.905 ms) : 0, 177905
Debugger [baseline] (84.359 ms) : 0, 84359
Debugger [candidate] (84.371 ms) : 0, 84371
Remote Config [baseline] (631.21 µs) : 0, 631
Remote Config [candidate] (630.889 µs) : 0, 631
Telemetry [baseline] (12.351 ms) : 0, 12351
Telemetry [candidate] (12.314 ms) : 0, 12314
IAST [baseline] (21.486 ms) : 0, 21486
IAST [candidate] (21.495 ms) : 0, 21495
section iast
BytebuddyAgent [baseline] (840.9 ms) : 0, 840900
BytebuddyAgent [candidate] (834.224 ms) : 0, 834224
GlobalTracer [baseline] (231.43 ms) : 0, 231430
GlobalTracer [candidate] (230.076 ms) : 0, 230076
AppSec [baseline] (57.57 ms) : 0, 57570
AppSec [candidate] (56.862 ms) : 0, 56862
Debugger [baseline] (83.352 ms) : 0, 83352
Debugger [candidate] (83.409 ms) : 0, 83409
Remote Config [baseline] (530.553 µs) : 0, 531
Remote Config [candidate] (522.155 µs) : 0, 522
Telemetry [baseline] (14.285 ms) : 0, 14285
Telemetry [candidate] (13.773 ms) : 0, 13773
IAST [baseline] (22.919 ms) : 0, 22919
IAST [candidate] (22.781 ms) : 0, 22781
section profiling
BytebuddyAgent [baseline] (717.188 ms) : 0, 717188
BytebuddyAgent [candidate] (708.096 ms) : 0, 708096
GlobalTracer [baseline] (352.801 ms) : 0, 352801
GlobalTracer [candidate] (350.443 ms) : 0, 350443
AppSec [baseline] (55.939 ms) : 0, 55939
AppSec [candidate] (54.26 ms) : 0, 54260
Debugger [baseline] (89.055 ms) : 0, 89055
Debugger [candidate] (88.385 ms) : 0, 88385
Remote Config [baseline] (614.603 µs) : 0, 615
Remote Config [candidate] (625.125 µs) : 0, 625
Telemetry [baseline] (12.731 ms) : 0, 12731
Telemetry [candidate] (12.647 ms) : 0, 12647
ProfilingAgent [baseline] (123.418 ms) : 0, 123418
ProfilingAgent [candidate] (123.415 ms) : 0, 123415
Profiling [baseline] (123.439 ms) : 0, 123439
Profiling [candidate] (123.437 ms) : 0, 123437
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
. : milestone, 1355,
appsec (1.751 ms) : 1727, 1774
. : milestone, 1751,
appsec_no_iast (1.723 ms) : 1698, 1747
. : milestone, 1723,
code_origins (1.683 ms) : 1649, 1716
. : milestone, 1683,
iast (1.523 ms) : 1497, 1549
. : milestone, 1523,
profiling (1.495 ms) : 1471, 1520
. : milestone, 1495,
tracing (1.496 ms) : 1472, 1520
. : milestone, 1496,
section candidate
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.725 ms) : 1700, 1749
. : milestone, 1725,
appsec_no_iast (1.732 ms) : 1708, 1755
. : milestone, 1732,
code_origins (1.657 ms) : 1623, 1692
. : milestone, 1657,
iast (1.511 ms) : 1486, 1535
. : milestone, 1511,
profiling (1.512 ms) : 1488, 1535
. : milestone, 1512,
tracing (1.485 ms) : 1462, 1509
. : milestone, 1485,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (378.654 µs) : 358, 399
. : milestone, 379,
iast (511.954 µs) : 490, 534
. : milestone, 512,
iast_FULL (728.298 µs) : 706, 750
. : milestone, 728,
iast_GLOBAL (562.354 µs) : 540, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (509.812 µs) : 488, 532
. : milestone, 510,
iast_INACTIVE (462.395 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (510.959 µs) : 489, 533
. : milestone, 511,
tracing (461.896 µs) : 439, 484
. : milestone, 462,
section candidate
no_agent (375.649 µs) : 354, 397
. : milestone, 376,
iast (515.977 µs) : 494, 538
. : milestone, 516,
iast_FULL (723.996 µs) : 702, 746
. : milestone, 724,
iast_GLOBAL (554.638 µs) : 532, 577
. : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (504.358 µs) : 483, 526
. : milestone, 504,
iast_INACTIVE (464.547 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (494.149 µs) : 473, 516
. : milestone, 494,
tracing (451.771 µs) : 431, 473
. : milestone, 452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.948 s) : 18948000, 18948000
. : milestone, 18948000,
iast_GLOBAL (18.16 s) : 18160000, 18160000
. : milestone, 18160000,
profiling (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
tracing (14.768 s) : 14768000, 14768000
. : milestone, 14768000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
iast (18.915 s) : 18915000, 18915000
. : milestone, 18915000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
. : milestone, 18105000,
profiling (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
tracing (15.06 s) : 15060000, 15060000
. : milestone, 15060000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.341 ms) : 2297, 2385
. : milestone, 2341,
iast (2.118 ms) : 2063, 2174
. : milestone, 2118,
iast_GLOBAL (2.156 ms) : 2101, 2212
. : milestone, 2156,
profiling (2.457 ms) : 2269, 2645
. : milestone, 2457,
tracing (1.947 ms) : 1905, 1990
. : milestone, 1947,
section candidate
no_agent (1.469 ms) : 1458, 1480
. : milestone, 1469,
appsec (2.32 ms) : 2277, 2363
. : milestone, 2320,
iast (2.109 ms) : 2054, 2164
. : milestone, 2109,
iast_GLOBAL (2.155 ms) : 2099, 2211
. : milestone, 2155,
profiling (1.961 ms) : 1918, 2004
. : milestone, 1961,
tracing (1.937 ms) : 1896, 1979
. : milestone, 1937,
|
What Does This Do
This is related to #8461 which enabled remote debugging by default.
When CI Visibility is enabled, we'd like to keep the existing behaviour: only enable remote debugger if the user has explicitly configured the tracer to do so.
Motivation
Our performance tests have shown that in some cases remote debugger adds significant overhead (sometimes up to 15-20% additional overhead).
CI Visibility is used in short-lived VMs that run the tests and then die, remote config is hardly applicable there.
We do plan to integrate with remote debugger in the future, but for now we'd like to have it disabled by default for our users.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: DEBUG-3455