Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debugger by default if CI Visibility is enabled #8506

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Mar 4, 2025

What Does This Do

This is related to #8461 which enabled remote debugging by default.
When CI Visibility is enabled, we'd like to keep the existing behaviour: only enable remote debugger if the user has explicitly configured the tracer to do so.

Motivation

Our performance tests have shown that in some cases remote debugger adds significant overhead (sometimes up to 15-20% additional overhead).
CI Visibility is used in short-lived VMs that run the tests and then die, remote config is hardly applicable there.

We do plan to integrate with remote debugger in the future, but for now we'd like to have it disabled by default for our users.

Contributor Checklist

Jira ticket: DEBUG-3455

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility comp: debugger Dynamic Instrumentation labels Mar 4, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review March 4, 2025 16:24
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner March 4, 2025 16:24
Copy link
Member

@jpbempel jpbempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on perf issue? because there is no reason for this AFAIK

@pr-commenter
Copy link

pr-commenter bot commented Mar 4, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/ci-vis-disable-debugger-by-default
git_commit_date 1741108009 1741108173
git_commit_sha 9966995 d4436e5
release_version 1.47.0-SNAPSHOT~9966995dd4 1.47.0-SNAPSHOT~d4436e5018
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741110675 1741110675
ci_job_id 832293227 832293227
ci_pipeline_id 57677068 57677068
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-wxnla8-s-project-304-concurrent-0-gh2z9dlo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-wxnla8-s-project-304-concurrent-0-gh2z9dlo 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.134 s) : 0, 1134144
Total [baseline] (9.231 s) : 0, 9230797
Agent [candidate] (1.133 s) : 0, 1133197
Total [candidate] (9.267 s) : 0, 9267417
section iast
Agent [baseline] (1.266 s) : 0, 1266190
Total [baseline] (9.902 s) : 0, 9901549
Agent [candidate] (1.256 s) : 0, 1256267
Total [candidate] (9.868 s) : 0, 9867782
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.262 s) : 0, 1261938
Total [baseline] (9.84 s) : 0, 9840367
Agent [candidate] (1.259 s) : 0, 1259338
Total [candidate] (9.88 s) : 0, 9880431
section iast_TELEMETRY_OFF
Agent [baseline] (1.252 s) : 0, 1251669
Total [baseline] (9.875 s) : 0, 9875316
Agent [candidate] (1.263 s) : 0, 1262532
Total [candidate] (9.91 s) : 0, 9909654
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.134 s -
Agent iast 1.266 s 132.046 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.262 s 127.793 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.252 s 117.524 ms (10.4%)
Total tracing 9.231 s -
Total iast 9.902 s 670.752 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.84 s 609.569 ms (6.6%)
Total iast_TELEMETRY_OFF 9.875 s 644.519 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.133 s -
Agent iast 1.256 s 123.07 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.259 s 126.141 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.263 s 129.336 ms (11.4%)
Total tracing 9.267 s -
Total iast 9.868 s 600.366 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.88 s 613.015 ms (6.6%)
Total iast_TELEMETRY_OFF 9.91 s 642.237 ms (6.9%)
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.295 ms) : 0, 716295
BytebuddyAgent [candidate] (716.014 ms) : 0, 716014
GlobalTracer [baseline] (239.18 ms) : 0, 239180
GlobalTracer [candidate] (239.457 ms) : 0, 239457
AppSec [baseline] (55.45 ms) : 0, 55450
AppSec [candidate] (55.221 ms) : 0, 55221
Debugger [baseline] (95.145 ms) : 0, 95145
Debugger [candidate] (94.538 ms) : 0, 94538
Remote Config [baseline] (610.245 µs) : 0, 610
Remote Config [candidate] (602.501 µs) : 0, 603
Telemetry [baseline] (12.485 ms) : 0, 12485
Telemetry [candidate] (12.36 ms) : 0, 12360
section iast
BytebuddyAgent [baseline] (842.101 ms) : 0, 842101
BytebuddyAgent [candidate] (834.604 ms) : 0, 834604
GlobalTracer [baseline] (230.74 ms) : 0, 230740
GlobalTracer [candidate] (230.061 ms) : 0, 230061
IAST [baseline] (22.86 ms) : 0, 22860
IAST [candidate] (22.71 ms) : 0, 22710
AppSec [baseline] (57.553 ms) : 0, 57553
AppSec [candidate] (56.506 ms) : 0, 56506
Debugger [baseline] (83.487 ms) : 0, 83487
Debugger [candidate] (83.439 ms) : 0, 83439
Remote Config [baseline] (523.91 µs) : 0, 524
Remote Config [candidate] (515.775 µs) : 0, 516
Telemetry [baseline] (13.773 ms) : 0, 13773
Telemetry [candidate] (13.491 ms) : 0, 13491
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.966 ms) : 0, 839966
BytebuddyAgent [candidate] (834.703 ms) : 0, 834703
GlobalTracer [baseline] (230.428 ms) : 0, 230428
GlobalTracer [candidate] (230.546 ms) : 0, 230546
IAST [baseline] (22.767 ms) : 0, 22767
IAST [candidate] (22.912 ms) : 0, 22912
AppSec [baseline] (56.801 ms) : 0, 56801
AppSec [candidate] (57.584 ms) : 0, 57584
Debugger [baseline] (83.479 ms) : 0, 83479
Debugger [candidate] (83.906 ms) : 0, 83906
Remote Config [baseline] (514.28 µs) : 0, 514
Remote Config [candidate] (521.708 µs) : 0, 522
Telemetry [baseline] (12.98 ms) : 0, 12980
Telemetry [candidate] (14.181 ms) : 0, 14181
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.505 ms) : 0, 831505
BytebuddyAgent [candidate] (841.123 ms) : 0, 841123
GlobalTracer [baseline] (229.696 ms) : 0, 229696
GlobalTracer [candidate] (231.261 ms) : 0, 231261
IAST [baseline] (22.421 ms) : 0, 22421
IAST [candidate] (25.681 ms) : 0, 25681
AppSec [baseline] (57.255 ms) : 0, 57255
AppSec [candidate] (53.535 ms) : 0, 53535
Debugger [baseline] (83.326 ms) : 0, 83326
Debugger [candidate] (83.259 ms) : 0, 83259
Remote Config [baseline] (514.235 µs) : 0, 514
Remote Config [candidate] (527.748 µs) : 0, 528
Telemetry [baseline] (12.026 ms) : 0, 12026
Telemetry [candidate] (12.061 ms) : 0, 12061
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.14 s) : 0, 1140380
Total [baseline] (11.537 s) : 0, 11537139
Agent [candidate] (1.153 s) : 0, 1153384
Total [candidate] (11.444 s) : 0, 11443947
section appsec
Agent [baseline] (1.273 s) : 0, 1273479
Total [baseline] (11.588 s) : 0, 11588167
Agent [candidate] (1.274 s) : 0, 1273840
Total [candidate] (11.688 s) : 0, 11687630
section iast
Agent [baseline] (1.266 s) : 0, 1266262
Total [baseline] (11.914 s) : 0, 11914101
Agent [candidate] (1.257 s) : 0, 1256574
Total [candidate] (11.982 s) : 0, 11981645
section profiling
Agent [baseline] (1.393 s) : 0, 1392642
Total [baseline] (11.879 s) : 0, 11879499
Agent [candidate] (1.378 s) : 0, 1378209
Total [candidate] (11.737 s) : 0, 11737101
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.14 s -
Agent appsec 1.273 s 133.1 ms (11.7%)
Agent iast 1.266 s 125.883 ms (11.0%)
Agent profiling 1.393 s 252.262 ms (22.1%)
Total tracing 11.537 s -
Total appsec 11.588 s 51.028 ms (0.4%)
Total iast 11.914 s 376.961 ms (3.3%)
Total profiling 11.879 s 342.36 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.153 s -
Agent appsec 1.274 s 120.456 ms (10.4%)
Agent iast 1.257 s 103.19 ms (8.9%)
Agent profiling 1.378 s 224.825 ms (19.5%)
Total tracing 11.444 s -
Total appsec 11.688 s 243.682 ms (2.1%)
Total iast 11.982 s 537.698 ms (4.7%)
Total profiling 11.737 s 293.153 ms (2.6%)
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.214 ms) : 0, 720214
BytebuddyAgent [candidate] (728.415 ms) : 0, 728415
GlobalTracer [baseline] (240.806 ms) : 0, 240806
GlobalTracer [candidate] (243.459 ms) : 0, 243459
AppSec [baseline] (55.825 ms) : 0, 55825
AppSec [candidate] (56.365 ms) : 0, 56365
Debugger [baseline] (95.318 ms) : 0, 95318
Debugger [candidate] (96.786 ms) : 0, 96786
Remote Config [baseline] (603.594 µs) : 0, 604
Remote Config [candidate] (601.149 µs) : 0, 601
Telemetry [baseline] (12.513 ms) : 0, 12513
Telemetry [candidate] (12.655 ms) : 0, 12655
section appsec
BytebuddyAgent [baseline] (735.831 ms) : 0, 735831
BytebuddyAgent [candidate] (735.96 ms) : 0, 735960
GlobalTracer [baseline] (236.886 ms) : 0, 236886
GlobalTracer [candidate] (236.941 ms) : 0, 236941
AppSec [baseline] (177.705 ms) : 0, 177705
AppSec [candidate] (177.905 ms) : 0, 177905
Debugger [baseline] (84.359 ms) : 0, 84359
Debugger [candidate] (84.371 ms) : 0, 84371
Remote Config [baseline] (631.21 µs) : 0, 631
Remote Config [candidate] (630.889 µs) : 0, 631
Telemetry [baseline] (12.351 ms) : 0, 12351
Telemetry [candidate] (12.314 ms) : 0, 12314
IAST [baseline] (21.486 ms) : 0, 21486
IAST [candidate] (21.495 ms) : 0, 21495
section iast
BytebuddyAgent [baseline] (840.9 ms) : 0, 840900
BytebuddyAgent [candidate] (834.224 ms) : 0, 834224
GlobalTracer [baseline] (231.43 ms) : 0, 231430
GlobalTracer [candidate] (230.076 ms) : 0, 230076
AppSec [baseline] (57.57 ms) : 0, 57570
AppSec [candidate] (56.862 ms) : 0, 56862
Debugger [baseline] (83.352 ms) : 0, 83352
Debugger [candidate] (83.409 ms) : 0, 83409
Remote Config [baseline] (530.553 µs) : 0, 531
Remote Config [candidate] (522.155 µs) : 0, 522
Telemetry [baseline] (14.285 ms) : 0, 14285
Telemetry [candidate] (13.773 ms) : 0, 13773
IAST [baseline] (22.919 ms) : 0, 22919
IAST [candidate] (22.781 ms) : 0, 22781
section profiling
BytebuddyAgent [baseline] (717.188 ms) : 0, 717188
BytebuddyAgent [candidate] (708.096 ms) : 0, 708096
GlobalTracer [baseline] (352.801 ms) : 0, 352801
GlobalTracer [candidate] (350.443 ms) : 0, 350443
AppSec [baseline] (55.939 ms) : 0, 55939
AppSec [candidate] (54.26 ms) : 0, 54260
Debugger [baseline] (89.055 ms) : 0, 89055
Debugger [candidate] (88.385 ms) : 0, 88385
Remote Config [baseline] (614.603 µs) : 0, 615
Remote Config [candidate] (625.125 µs) : 0, 625
Telemetry [baseline] (12.731 ms) : 0, 12731
Telemetry [candidate] (12.647 ms) : 0, 12647
ProfilingAgent [baseline] (123.418 ms) : 0, 123418
ProfilingAgent [candidate] (123.415 ms) : 0, 123415
Profiling [baseline] (123.439 ms) : 0, 123439
Profiling [candidate] (123.437 ms) : 0, 123437
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-04T17:19:06 2025-03-04T17:27:00
git_branch master nikita-tkachenko/ci-vis-disable-debugger-by-default
git_commit_date 1741108009 1741108173
git_commit_sha 9966995 d4436e5
release_version 1.47.0-SNAPSHOT~9966995dd4 1.47.0-SNAPSHOT~d4436e5018
start_time 2025-03-04T17:18:52 2025-03-04T17:26:46
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741109624 1741109624
ci_job_id 832293229 832293229
ci_pipeline_id 57677068 57677068
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-wxnla8-s-project-304-concurrent-2-oqnhdxou 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-wxnla8-s-project-304-concurrent-2-oqnhdxou 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.751 ms) : 1727, 1774
.   : milestone, 1751,
appsec_no_iast (1.723 ms) : 1698, 1747
.   : milestone, 1723,
code_origins (1.683 ms) : 1649, 1716
.   : milestone, 1683,
iast (1.523 ms) : 1497, 1549
.   : milestone, 1523,
profiling (1.495 ms) : 1471, 1520
.   : milestone, 1495,
tracing (1.496 ms) : 1472, 1520
.   : milestone, 1496,
section candidate
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.725 ms) : 1700, 1749
.   : milestone, 1725,
appsec_no_iast (1.732 ms) : 1708, 1755
.   : milestone, 1732,
code_origins (1.657 ms) : 1623, 1692
.   : milestone, 1657,
iast (1.511 ms) : 1486, 1535
.   : milestone, 1511,
profiling (1.512 ms) : 1488, 1535
.   : milestone, 1512,
tracing (1.485 ms) : 1462, 1509
.   : milestone, 1485,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.374 ms] -
appsec 1.751 ms [1.727 ms, 1.774 ms] 396.121 µs (29.2%)
appsec_no_iast 1.723 ms [1.698 ms, 1.747 ms] 368.03 µs (27.2%)
code_origins 1.683 ms [1.649 ms, 1.716 ms] 328.025 µs (24.2%)
iast 1.523 ms [1.497 ms, 1.549 ms] 168.41 µs (12.4%)
profiling 1.495 ms [1.471 ms, 1.52 ms] 140.59 µs (10.4%)
tracing 1.496 ms [1.472 ms, 1.52 ms] 141.524 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.725 ms [1.7 ms, 1.749 ms] 369.835 µs (27.3%)
appsec_no_iast 1.732 ms [1.708 ms, 1.755 ms] 376.816 µs (27.8%)
code_origins 1.657 ms [1.623 ms, 1.692 ms] 302.708 µs (22.3%)
iast 1.511 ms [1.486 ms, 1.535 ms] 155.879 µs (11.5%)
profiling 1.512 ms [1.488 ms, 1.535 ms] 156.91 µs (11.6%)
tracing 1.485 ms [1.462 ms, 1.509 ms] 130.589 µs (9.6%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (378.654 µs) : 358, 399
.   : milestone, 379,
iast (511.954 µs) : 490, 534
.   : milestone, 512,
iast_FULL (728.298 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (562.354 µs) : 540, 585
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (509.812 µs) : 488, 532
.   : milestone, 510,
iast_INACTIVE (462.395 µs) : 441, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (510.959 µs) : 489, 533
.   : milestone, 511,
tracing (461.896 µs) : 439, 484
.   : milestone, 462,
section candidate
no_agent (375.649 µs) : 354, 397
.   : milestone, 376,
iast (515.977 µs) : 494, 538
.   : milestone, 516,
iast_FULL (723.996 µs) : 702, 746
.   : milestone, 724,
iast_GLOBAL (554.638 µs) : 532, 577
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (504.358 µs) : 483, 526
.   : milestone, 504,
iast_INACTIVE (464.547 µs) : 443, 486
.   : milestone, 465,
iast_TELEMETRY_OFF (494.149 µs) : 473, 516
.   : milestone, 494,
tracing (451.771 µs) : 431, 473
.   : milestone, 452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.654 µs [358.48 µs, 398.827 µs] -
iast 511.954 µs [489.645 µs, 534.264 µs] 133.3 µs (35.2%)
iast_FULL 728.298 µs [706.212 µs, 750.384 µs] 349.644 µs (92.3%)
iast_GLOBAL 562.354 µs [539.601 µs, 585.107 µs] 183.7 µs (48.5%)
iast_HARDCODED_SECRET_DISABLED 509.812 µs [487.969 µs, 531.654 µs] 131.158 µs (34.6%)
iast_INACTIVE 462.395 µs [440.538 µs, 484.252 µs] 83.741 µs (22.1%)
iast_TELEMETRY_OFF 510.959 µs [488.67 µs, 533.247 µs] 132.305 µs (34.9%)
tracing 461.896 µs [439.386 µs, 484.405 µs] 83.242 µs (22.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.649 µs [354.147 µs, 397.152 µs] -
iast 515.977 µs [493.548 µs, 538.405 µs] 140.327 µs (37.4%)
iast_FULL 723.996 µs [701.76 µs, 746.232 µs] 348.347 µs (92.7%)
iast_GLOBAL 554.638 µs [532.433 µs, 576.842 µs] 178.988 µs (47.6%)
iast_HARDCODED_SECRET_DISABLED 504.358 µs [482.556 µs, 526.161 µs] 128.709 µs (34.3%)
iast_INACTIVE 464.547 µs [443.101 µs, 485.993 µs] 88.897 µs (23.7%)
iast_TELEMETRY_OFF 494.149 µs [472.553 µs, 515.746 µs] 118.5 µs (31.5%)
tracing 451.771 µs [430.793 µs, 472.749 µs] 76.121 µs (20.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/ci-vis-disable-debugger-by-default
git_commit_date 1741108009 1741108173
git_commit_sha 9966995 d4436e5
release_version 1.47.0-SNAPSHOT~9966995dd4 1.47.0-SNAPSHOT~d4436e5018
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741110194 1741110194
ci_job_id 832293230 832293230
ci_pipeline_id 57677068 57677068
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-awbh27yp-project-304-concurrent-1-8jsm9n6h 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-awbh27yp-project-304-concurrent-1-8jsm9n6h 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.946 s) : 14946000, 14946000
.   : milestone, 14946000,
appsec (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
iast (18.948 s) : 18948000, 18948000
.   : milestone, 18948000,
iast_GLOBAL (18.16 s) : 18160000, 18160000
.   : milestone, 18160000,
profiling (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
tracing (14.768 s) : 14768000, 14768000
.   : milestone, 14768000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
.   : milestone, 15469000,
appsec (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
iast (18.915 s) : 18915000, 18915000
.   : milestone, 18915000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
.   : milestone, 18105000,
profiling (15.233 s) : 15233000, 15233000
.   : milestone, 15233000,
tracing (15.06 s) : 15060000, 15060000
.   : milestone, 15060000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.946 s [14.946 s, 14.946 s] -
appsec 15.026 s [15.026 s, 15.026 s] 80.0 ms (0.5%)
iast 18.948 s [18.948 s, 18.948 s] 4.002 s (26.8%)
iast_GLOBAL 18.16 s [18.16 s, 18.16 s] 3.214 s (21.5%)
profiling 15.023 s [15.023 s, 15.023 s] 77.0 ms (0.5%)
tracing 14.768 s [14.768 s, 14.768 s] -178.0 ms (-1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.469 s [15.469 s, 15.469 s] -
appsec 14.867 s [14.867 s, 14.867 s] -602.0 ms (-3.9%)
iast 18.915 s [18.915 s, 18.915 s] 3.446 s (22.3%)
iast_GLOBAL 18.105 s [18.105 s, 18.105 s] 2.636 s (17.0%)
profiling 15.233 s [15.233 s, 15.233 s] -236.0 ms (-1.5%)
tracing 15.06 s [15.06 s, 15.06 s] -409.0 ms (-2.6%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~d4436e5018, baseline=1.47.0-SNAPSHOT~9966995dd4
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.341 ms) : 2297, 2385
.   : milestone, 2341,
iast (2.118 ms) : 2063, 2174
.   : milestone, 2118,
iast_GLOBAL (2.156 ms) : 2101, 2212
.   : milestone, 2156,
profiling (2.457 ms) : 2269, 2645
.   : milestone, 2457,
tracing (1.947 ms) : 1905, 1990
.   : milestone, 1947,
section candidate
no_agent (1.469 ms) : 1458, 1480
.   : milestone, 1469,
appsec (2.32 ms) : 2277, 2363
.   : milestone, 2320,
iast (2.109 ms) : 2054, 2164
.   : milestone, 2109,
iast_GLOBAL (2.155 ms) : 2099, 2211
.   : milestone, 2155,
profiling (1.961 ms) : 1918, 2004
.   : milestone, 1961,
tracing (1.937 ms) : 1896, 1979
.   : milestone, 1937,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.341 ms [2.297 ms, 2.385 ms] 866.725 µs (58.8%)
iast 2.118 ms [2.063 ms, 2.174 ms] 643.87 µs (43.7%)
iast_GLOBAL 2.156 ms [2.101 ms, 2.212 ms] 681.876 µs (46.2%)
profiling 2.457 ms [2.269 ms, 2.645 ms] 982.585 µs (66.6%)
tracing 1.947 ms [1.905 ms, 1.99 ms] 472.932 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.48 ms] -
appsec 2.32 ms [2.277 ms, 2.363 ms] 851.142 µs (57.9%)
iast 2.109 ms [2.054 ms, 2.164 ms] 639.832 µs (43.6%)
iast_GLOBAL 2.155 ms [2.099 ms, 2.211 ms] 686.111 µs (46.7%)
profiling 1.961 ms [1.918 ms, 2.004 ms] 491.942 µs (33.5%)
tracing 1.937 ms [1.896 ms, 1.979 ms] 468.381 µs (31.9%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 3453e65 into master Mar 4, 2025
202 of 206 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/ci-vis-disable-debugger-by-default branch March 4, 2025 18:09
@github-actions github-actions bot added this to the 1.47.0 milestone Mar 4, 2025
jpbempel added a commit that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: ci visibility Continuous Integration Visibility comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants