-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gary/add llmobs svc functionalities traceid #8505
Draft
gary-huang
wants to merge
5
commits into
gary/add-llm-obs-writer
Choose a base branch
from
gary/add-llmobs-svc-functionalities-traceid
base: gary/add-llm-obs-writer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Gary/add llmobs svc functionalities traceid #8505
gary-huang
wants to merge
5
commits into
gary/add-llm-obs-writer
from
gary/add-llmobs-svc-functionalities-traceid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b4f8a8
to
738eb77
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042667
Total [baseline] (10.467 s) : 0, 10467453
Agent [candidate] (1.04 s) : 0, 1039913
Total [candidate] (10.539 s) : 0, 10539051
section appsec
Agent [baseline] (1.185 s) : 0, 1184546
Total [baseline] (10.782 s) : 0, 10781987
Agent [candidate] (1.184 s) : 0, 1184145
Total [candidate] (10.76 s) : 0, 10759535
section iast
Agent [baseline] (1.187 s) : 0, 1187350
Total [baseline] (11.087 s) : 0, 11086880
Agent [candidate] (1.181 s) : 0, 1181463
Total [candidate] (10.996 s) : 0, 10995697
section profiling
Agent [baseline] (1.265 s) : 0, 1265094
Total [baseline] (10.86 s) : 0, 10860398
Agent [candidate] (1.264 s) : 0, 1263772
Total [candidate] (10.99 s) : 0, 10990294
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.108 ms) : 0, 718108
BytebuddyAgent [candidate] (717.291 ms) : 0, 717291
GlobalTracer [baseline] (239.933 ms) : 0, 239933
GlobalTracer [candidate] (240.261 ms) : 0, 240261
AppSec [baseline] (55.348 ms) : 0, 55348
AppSec [candidate] (55.181 ms) : 0, 55181
Remote Config [baseline] (695.696 µs) : 0, 696
Remote Config [candidate] (691.068 µs) : 0, 691
Telemetry [baseline] (13.665 ms) : 0, 13665
Telemetry [candidate] (11.54 ms) : 0, 11540
section appsec
BytebuddyAgent [baseline] (736.789 ms) : 0, 736789
BytebuddyAgent [candidate] (735.453 ms) : 0, 735453
GlobalTracer [baseline] (236.599 ms) : 0, 236599
GlobalTracer [candidate] (236.58 ms) : 0, 236580
IAST [baseline] (21.524 ms) : 0, 21524
IAST [candidate] (21.654 ms) : 0, 21654
AppSec [baseline] (176.467 ms) : 0, 176467
AppSec [candidate] (177.36 ms) : 0, 177360
Remote Config [baseline] (658.84 µs) : 0, 659
Remote Config [candidate] (663.213 µs) : 0, 663
Telemetry [baseline] (8.259 ms) : 0, 8259
Telemetry [candidate] (8.293 ms) : 0, 8293
section iast
BytebuddyAgent [baseline] (849.278 ms) : 0, 849278
BytebuddyAgent [candidate] (845.028 ms) : 0, 845028
GlobalTracer [baseline] (232.917 ms) : 0, 232917
GlobalTracer [candidate] (231.798 ms) : 0, 231798
IAST [baseline] (23.112 ms) : 0, 23112
IAST [candidate] (23.236 ms) : 0, 23236
AppSec [baseline] (57.482 ms) : 0, 57482
AppSec [candidate] (56.942 ms) : 0, 56942
Remote Config [baseline] (625.346 µs) : 0, 625
Remote Config [candidate] (624.927 µs) : 0, 625
Telemetry [baseline] (8.823 ms) : 0, 8823
Telemetry [candidate] (8.702 ms) : 0, 8702
section profiling
BytebuddyAgent [baseline] (710.51 ms) : 0, 710510
BytebuddyAgent [candidate] (710.849 ms) : 0, 710849
GlobalTracer [baseline] (352.263 ms) : 0, 352263
GlobalTracer [candidate] (351.311 ms) : 0, 351311
AppSec [baseline] (55.228 ms) : 0, 55228
AppSec [candidate] (54.59 ms) : 0, 54590
Remote Config [baseline] (672.68 µs) : 0, 673
Remote Config [candidate] (679.487 µs) : 0, 679
Telemetry [baseline] (9.008 ms) : 0, 9008
Telemetry [candidate] (9.016 ms) : 0, 9016
ProfilingAgent [baseline] (96.957 ms) : 0, 96957
ProfilingAgent [candidate] (96.901 ms) : 0, 96901
Profiling [baseline] (96.982 ms) : 0, 96982
Profiling [candidate] (96.925 ms) : 0, 96925
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1037185
Total [baseline] (8.681 s) : 0, 8681047
Agent [candidate] (1.042 s) : 0, 1041973
Total [candidate] (8.681 s) : 0, 8680633
section iast
Agent [baseline] (1.173 s) : 0, 1172909
Total [baseline] (9.281 s) : 0, 9280655
Agent [candidate] (1.171 s) : 0, 1170987
Total [candidate] (9.267 s) : 0, 9267274
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172049
Total [baseline] (9.267 s) : 0, 9266750
Agent [candidate] (1.171 s) : 0, 1171266
Total [candidate] (9.23 s) : 0, 9230386
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166953
Total [baseline] (9.272 s) : 0, 9271715
Agent [candidate] (1.177 s) : 0, 1176775
Total [candidate] (9.322 s) : 0, 9322459
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.976 ms) : 0, 715976
BytebuddyAgent [candidate] (717.83 ms) : 0, 717830
GlobalTracer [baseline] (239.16 ms) : 0, 239160
GlobalTracer [candidate] (239.784 ms) : 0, 239784
AppSec [baseline] (54.991 ms) : 0, 54991
AppSec [candidate] (55.175 ms) : 0, 55175
Remote Config [baseline] (681.598 µs) : 0, 682
Remote Config [candidate] (701.848 µs) : 0, 702
Telemetry [baseline] (11.422 ms) : 0, 11422
Telemetry [candidate] (13.524 ms) : 0, 13524
section iast
BytebuddyAgent [baseline] (838.01 ms) : 0, 838010
BytebuddyAgent [candidate] (836.937 ms) : 0, 836937
GlobalTracer [baseline] (230.431 ms) : 0, 230431
GlobalTracer [candidate] (230.151 ms) : 0, 230151
IAST [baseline] (23.791 ms) : 0, 23791
IAST [candidate] (22.729 ms) : 0, 22729
AppSec [baseline] (56.222 ms) : 0, 56222
AppSec [candidate] (56.759 ms) : 0, 56759
Remote Config [baseline] (617.171 µs) : 0, 617
Remote Config [candidate] (618.864 µs) : 0, 619
Telemetry [baseline] (8.846 ms) : 0, 8846
Telemetry [candidate] (8.765 ms) : 0, 8765
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.269 ms) : 0, 837269
BytebuddyAgent [candidate] (837.095 ms) : 0, 837095
GlobalTracer [baseline] (230.936 ms) : 0, 230936
GlobalTracer [candidate] (229.854 ms) : 0, 229854
IAST [baseline] (22.839 ms) : 0, 22839
IAST [candidate] (23.085 ms) : 0, 23085
AppSec [baseline] (56.695 ms) : 0, 56695
AppSec [candidate] (56.694 ms) : 0, 56694
Remote Config [baseline] (610.502 µs) : 0, 611
Remote Config [candidate] (615.865 µs) : 0, 616
Telemetry [baseline] (8.702 ms) : 0, 8702
Telemetry [candidate] (8.797 ms) : 0, 8797
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.375 ms) : 0, 833375
BytebuddyAgent [candidate] (839.635 ms) : 0, 839635
GlobalTracer [baseline] (230.48 ms) : 0, 230480
GlobalTracer [candidate] (232.529 ms) : 0, 232529
IAST [baseline] (23.16 ms) : 0, 23160
IAST [candidate] (22.86 ms) : 0, 22860
AppSec [baseline] (55.757 ms) : 0, 55757
AppSec [candidate] (57.256 ms) : 0, 57256
Remote Config [baseline] (608.347 µs) : 0, 608
Remote Config [candidate] (626.508 µs) : 0, 627
Telemetry [baseline] (8.597 ms) : 0, 8597
Telemetry [candidate] (8.8 ms) : 0, 8800
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section baseline
no_agent (384.169 µs) : 364, 404
. : milestone, 384,
iast (512.885 µs) : 491, 535
. : milestone, 513,
iast_FULL (725.352 µs) : 703, 747
. : milestone, 725,
iast_GLOBAL (556.727 µs) : 535, 578
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (509.925 µs) : 488, 532
. : milestone, 510,
iast_INACTIVE (463.737 µs) : 442, 486
. : milestone, 464,
iast_TELEMETRY_OFF (498.887 µs) : 477, 521
. : milestone, 499,
tracing (456.41 µs) : 435, 478
. : milestone, 456,
section candidate
no_agent (374.627 µs) : 355, 395
. : milestone, 375,
iast (514.669 µs) : 492, 538
. : milestone, 515,
iast_FULL (730.464 µs) : 708, 753
. : milestone, 730,
iast_GLOBAL (563.068 µs) : 540, 586
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (518.172 µs) : 496, 540
. : milestone, 518,
iast_INACTIVE (461.469 µs) : 440, 483
. : milestone, 461,
iast_TELEMETRY_OFF (494.911 µs) : 472, 517
. : milestone, 495,
tracing (459.576 µs) : 438, 481
. : milestone, 460,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section baseline
no_agent (1.34 ms) : 1320, 1360
. : milestone, 1340,
appsec (1.747 ms) : 1724, 1770
. : milestone, 1747,
appsec_no_iast (1.724 ms) : 1699, 1750
. : milestone, 1724,
code_origins (1.684 ms) : 1651, 1718
. : milestone, 1684,
iast (1.525 ms) : 1501, 1549
. : milestone, 1525,
profiling (1.547 ms) : 1522, 1572
. : milestone, 1547,
tracing (1.485 ms) : 1460, 1510
. : milestone, 1485,
section candidate
no_agent (1.353 ms) : 1333, 1373
. : milestone, 1353,
appsec (1.742 ms) : 1717, 1767
. : milestone, 1742,
appsec_no_iast (1.746 ms) : 1722, 1770
. : milestone, 1746,
code_origins (1.684 ms) : 1651, 1718
. : milestone, 1684,
iast (1.508 ms) : 1483, 1533
. : milestone, 1508,
profiling (1.556 ms) : 1530, 1581
. : milestone, 1556,
tracing (1.501 ms) : 1475, 1526
. : milestone, 1501,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section baseline
no_agent (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (19.05 s) : 19050000, 19050000
. : milestone, 19050000,
iast_GLOBAL (18.31 s) : 18310000, 18310000
. : milestone, 18310000,
profiling (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
tracing (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
section candidate
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
iast (19.202 s) : 19202000, 19202000
. : milestone, 19202000,
iast_GLOBAL (17.634 s) : 17634000, 17634000
. : milestone, 17634000,
profiling (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
tracing (14.907 s) : 14907000, 14907000
. : milestone, 14907000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~c390963ea7, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.344 ms) : 2301, 2388
. : milestone, 2344,
iast (2.108 ms) : 2053, 2163
. : milestone, 2108,
iast_GLOBAL (2.162 ms) : 2106, 2218
. : milestone, 2162,
profiling (1.959 ms) : 1916, 2002
. : milestone, 1959,
tracing (1.957 ms) : 1914, 1999
. : milestone, 1957,
section candidate
no_agent (1.475 ms) : 1463, 1487
. : milestone, 1475,
appsec (2.339 ms) : 2296, 2382
. : milestone, 2339,
iast (2.113 ms) : 2058, 2168
. : milestone, 2113,
iast_GLOBAL (2.156 ms) : 2100, 2211
. : milestone, 2156,
profiling (1.971 ms) : 1926, 2015
. : milestone, 1971,
tracing (1.957 ms) : 1915, 2000
. : milestone, 1957,
|
707295a
to
ebec127
Compare
f9a3902
to
b5d1199
Compare
ebec127
to
f0215ef
Compare
2080275
to
43a996f
Compare
f0215ef
to
edeca5c
Compare
592dbc5
to
d37b718
Compare
0e7c1e5
to
0b04221
Compare
d3dac5f
to
1f81260
Compare
0b04221
to
0bf8eb0
Compare
2a053a8
to
6f995a0
Compare
0bf8eb0
to
1d5dcc0
Compare
6f995a0
to
2a57453
Compare
1d5dcc0
to
dad55c7
Compare
2a57453
to
c390963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]