-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config Consistency Round 2 #8489
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052605
Total [baseline] (8.692 s) : 0, 8692191
Agent [candidate] (1.043 s) : 0, 1042880
Total [candidate] (8.681 s) : 0, 8681436
section iast
Agent [baseline] (1.17 s) : 0, 1169843
Total [baseline] (9.268 s) : 0, 9267995
Agent [candidate] (1.172 s) : 0, 1172299
Total [candidate] (9.259 s) : 0, 9258650
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171094
Total [baseline] (9.199 s) : 0, 9199103
Agent [candidate] (1.179 s) : 0, 1179003
Total [candidate] (9.185 s) : 0, 9184664
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168915
Total [baseline] (9.257 s) : 0, 9256874
Agent [candidate] (1.177 s) : 0, 1176634
Total [candidate] (9.263 s) : 0, 9262926
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.774 ms) : 0, 726774
BytebuddyAgent [candidate] (717.562 ms) : 0, 717562
GlobalTracer [baseline] (240.705 ms) : 0, 240705
GlobalTracer [candidate] (240.05 ms) : 0, 240050
AppSec [baseline] (55.74 ms) : 0, 55740
AppSec [candidate] (55.382 ms) : 0, 55382
Remote Config [baseline] (699.24 µs) : 0, 699
Remote Config [candidate] (694.838 µs) : 0, 695
Telemetry [baseline] (13.714 ms) : 0, 13714
Telemetry [candidate] (14.226 ms) : 0, 14226
section iast
BytebuddyAgent [baseline] (836.081 ms) : 0, 836081
BytebuddyAgent [candidate] (837.629 ms) : 0, 837629
GlobalTracer [baseline] (229.908 ms) : 0, 229908
GlobalTracer [candidate] (230.891 ms) : 0, 230891
AppSec [baseline] (56.598 ms) : 0, 56598
AppSec [candidate] (56.664 ms) : 0, 56664
Remote Config [baseline] (615.627 µs) : 0, 616
Remote Config [candidate] (621.768 µs) : 0, 622
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.724 ms) : 0, 8724
IAST [baseline] (23.088 ms) : 0, 23088
IAST [candidate] (22.851 ms) : 0, 22851
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.881 ms) : 0, 836881
BytebuddyAgent [candidate] (842.845 ms) : 0, 842845
GlobalTracer [baseline] (230.687 ms) : 0, 230687
GlobalTracer [candidate] (231.602 ms) : 0, 231602
AppSec [baseline] (56.464 ms) : 0, 56464
AppSec [candidate] (56.97 ms) : 0, 56970
Remote Config [baseline] (616.696 µs) : 0, 617
Remote Config [candidate] (610.752 µs) : 0, 611
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.767 ms) : 0, 8767
IAST [baseline] (22.784 ms) : 0, 22784
IAST [candidate] (23.202 ms) : 0, 23202
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.789 ms) : 0, 834789
BytebuddyAgent [candidate] (840.821 ms) : 0, 840821
GlobalTracer [baseline] (230.752 ms) : 0, 230752
GlobalTracer [candidate] (231.594 ms) : 0, 231594
AppSec [baseline] (56.797 ms) : 0, 56797
AppSec [candidate] (57.098 ms) : 0, 57098
Remote Config [baseline] (621.397 µs) : 0, 621
Remote Config [candidate] (622.02 µs) : 0, 622
Telemetry [baseline] (8.63 ms) : 0, 8630
Telemetry [candidate] (8.645 ms) : 0, 8645
IAST [baseline] (22.419 ms) : 0, 22419
IAST [candidate] (22.71 ms) : 0, 22710
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039976
Total [baseline] (10.533 s) : 0, 10532962
Agent [candidate] (1.043 s) : 0, 1043232
Total [candidate] (10.503 s) : 0, 10502601
section appsec
Agent [baseline] (1.184 s) : 0, 1184230
Total [baseline] (10.804 s) : 0, 10803875
Agent [candidate] (1.193 s) : 0, 1192638
Total [candidate] (10.808 s) : 0, 10808486
section iast
Agent [baseline] (1.168 s) : 0, 1168436
Total [baseline] (10.976 s) : 0, 10976050
Agent [candidate] (1.174 s) : 0, 1174191
Total [candidate] (11.001 s) : 0, 11000667
section profiling
Agent [baseline] (1.268 s) : 0, 1267730
Total [baseline] (10.944 s) : 0, 10943509
Agent [candidate] (1.259 s) : 0, 1258790
Total [candidate] (10.891 s) : 0, 10890707
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.383 ms) : 0, 717383
BytebuddyAgent [candidate] (719.217 ms) : 0, 719217
GlobalTracer [baseline] (239.738 ms) : 0, 239738
GlobalTracer [candidate] (240.178 ms) : 0, 240178
AppSec [baseline] (55.056 ms) : 0, 55056
AppSec [candidate] (55.385 ms) : 0, 55385
Remote Config [baseline] (691.806 µs) : 0, 692
Remote Config [candidate] (685.236 µs) : 0, 685
Telemetry [baseline] (12.19 ms) : 0, 12190
Telemetry [candidate] (12.794 ms) : 0, 12794
section appsec
BytebuddyAgent [baseline] (736.025 ms) : 0, 736025
BytebuddyAgent [candidate] (742.295 ms) : 0, 742295
GlobalTracer [baseline] (236.787 ms) : 0, 236787
GlobalTracer [candidate] (237.999 ms) : 0, 237999
AppSec [baseline] (176.698 ms) : 0, 176698
AppSec [candidate] (177.165 ms) : 0, 177165
Remote Config [baseline] (667.321 µs) : 0, 667
Remote Config [candidate] (667.504 µs) : 0, 668
Telemetry [baseline] (8.297 ms) : 0, 8297
Telemetry [candidate] (8.659 ms) : 0, 8659
IAST [baseline] (21.667 ms) : 0, 21667
IAST [candidate] (21.672 ms) : 0, 21672
section iast
BytebuddyAgent [baseline] (834.896 ms) : 0, 834896
BytebuddyAgent [candidate] (838.718 ms) : 0, 838718
GlobalTracer [baseline] (230.003 ms) : 0, 230003
GlobalTracer [candidate] (230.961 ms) : 0, 230961
AppSec [baseline] (56.552 ms) : 0, 56552
AppSec [candidate] (57.131 ms) : 0, 57131
Remote Config [baseline] (600.594 µs) : 0, 601
Remote Config [candidate] (617.907 µs) : 0, 618
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.768 ms) : 0, 8768
IAST [baseline] (22.746 ms) : 0, 22746
IAST [candidate] (23.06 ms) : 0, 23060
section profiling
BytebuddyAgent [baseline] (714.46 ms) : 0, 714460
BytebuddyAgent [candidate] (709.414 ms) : 0, 709414
GlobalTracer [baseline] (350.668 ms) : 0, 350668
GlobalTracer [candidate] (349.529 ms) : 0, 349529
AppSec [baseline] (55.164 ms) : 0, 55164
AppSec [candidate] (53.87 ms) : 0, 53870
Remote Config [baseline] (687.839 µs) : 0, 688
Remote Config [candidate] (674.328 µs) : 0, 674
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (8.93 ms) : 0, 8930
ProfilingAgent [baseline] (97.072 ms) : 0, 97072
ProfilingAgent [candidate] (95.997 ms) : 0, 95997
Profiling [baseline] (97.097 ms) : 0, 97097
Profiling [candidate] (96.021 ms) : 0, 96021
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (384.104 µs) : 362, 406
. : milestone, 384,
iast (509.126 µs) : 487, 531
. : milestone, 509,
iast_FULL (728.893 µs) : 707, 751
. : milestone, 729,
iast_GLOBAL (566.877 µs) : 545, 589
. : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (507.872 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (462.67 µs) : 442, 484
. : milestone, 463,
iast_TELEMETRY_OFF (494.35 µs) : 473, 516
. : milestone, 494,
tracing (461.822 µs) : 440, 483
. : milestone, 462,
section candidate
no_agent (377.103 µs) : 357, 397
. : milestone, 377,
iast (510.394 µs) : 488, 532
. : milestone, 510,
iast_FULL (732.089 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (561.077 µs) : 538, 584
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (517.277 µs) : 495, 539
. : milestone, 517,
iast_INACTIVE (458.341 µs) : 437, 480
. : milestone, 458,
iast_TELEMETRY_OFF (499.742 µs) : 477, 522
. : milestone, 500,
tracing (449.882 µs) : 429, 470
. : milestone, 450,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1370
. : milestone, 1349,
appsec (1.725 ms) : 1701, 1749
. : milestone, 1725,
appsec_no_iast (1.735 ms) : 1710, 1761
. : milestone, 1735,
code_origins (1.679 ms) : 1646, 1712
. : milestone, 1679,
iast (1.504 ms) : 1480, 1529
. : milestone, 1504,
profiling (1.508 ms) : 1484, 1532
. : milestone, 1508,
tracing (1.48 ms) : 1454, 1506
. : milestone, 1480,
section candidate
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.72 ms) : 1696, 1744
. : milestone, 1720,
appsec_no_iast (1.731 ms) : 1706, 1756
. : milestone, 1731,
code_origins (1.703 ms) : 1671, 1735
. : milestone, 1703,
iast (1.517 ms) : 1493, 1542
. : milestone, 1517,
profiling (1.545 ms) : 1519, 1570
. : milestone, 1545,
tracing (1.476 ms) : 1451, 1501
. : milestone, 1476,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
iast (18.829 s) : 18829000, 18829000
. : milestone, 18829000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
tracing (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
section candidate
no_agent (15.216 s) : 15216000, 15216000
. : milestone, 15216000,
appsec (15.206 s) : 15206000, 15206000
. : milestone, 15206000,
iast (18.676 s) : 18676000, 18676000
. : milestone, 18676000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (15.21 s) : 15210000, 15210000
. : milestone, 15210000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.33 ms) : 2287, 2373
. : milestone, 2330,
iast (2.103 ms) : 2048, 2158
. : milestone, 2103,
iast_GLOBAL (2.153 ms) : 2098, 2208
. : milestone, 2153,
profiling (1.99 ms) : 1945, 2034
. : milestone, 1990,
tracing (1.942 ms) : 1900, 1984
. : milestone, 1942,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.322 ms) : 2279, 2365
. : milestone, 2322,
iast (2.107 ms) : 2052, 2161
. : milestone, 2107,
iast_GLOBAL (2.15 ms) : 2094, 2205
. : milestone, 2150,
profiling (1.983 ms) : 1938, 2028
. : milestone, 1983,
tracing (1.946 ms) : 1903, 1989
. : milestone, 1946,
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
This PR updates the config implementations for the following configurations:
DD_LOGS_INJECTION
default value to be falseDD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED
default value to be trueThis PR also adds support for the following configuration:
DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED
, which takes in a string and stores a list of configurations to run the "breaking change" version of.Motivation
The SDK Capabilities team is working on modifying configurations to be consistent across all SDKs. This PR aims to update configs in dd-trace-java to match the following RFC.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMAPI-1037