Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Consistency Round 2 #8489

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Config Consistency Round 2 #8489

wants to merge 11 commits into from

Conversation

mhlidd
Copy link
Contributor

@mhlidd mhlidd commented Mar 3, 2025

What Does This Do

This PR updates the config implementations for the following configurations:

  • DD_LOGS_INJECTION default value to be false
  • DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED default value to be true

This PR also adds support for the following configuration: DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED, which takes in a string and stores a list of configurations to run the "breaking change" version of.

Motivation

The SDK Capabilities team is working on modifying configurations to be consistent across all SDKs. This PR aims to update configs in dd-trace-java to match the following RFC.

Additional Notes

Contributor Checklist

Jira ticket: APMAPI-1037

@pr-commenter
Copy link

pr-commenter bot commented Mar 3, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/config_consistency
git_commit_date 1741356784 1741363375
git_commit_sha 2575c71 da164b0
release_version 1.48.0-SNAPSHOT~2575c713ad 1.48.0-SNAPSHOT~da164b0edf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741365727 1741365727
ci_job_id 838206653 838206653
ci_pipeline_id 58110817 58110817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-t3ggepcs-project-304-concurrent-0-t3rartmn 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-t3ggepcs-project-304-concurrent-0-t3rartmn 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 3 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052605
Total [baseline] (8.692 s) : 0, 8692191
Agent [candidate] (1.043 s) : 0, 1042880
Total [candidate] (8.681 s) : 0, 8681436
section iast
Agent [baseline] (1.17 s) : 0, 1169843
Total [baseline] (9.268 s) : 0, 9267995
Agent [candidate] (1.172 s) : 0, 1172299
Total [candidate] (9.259 s) : 0, 9258650
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171094
Total [baseline] (9.199 s) : 0, 9199103
Agent [candidate] (1.179 s) : 0, 1179003
Total [candidate] (9.185 s) : 0, 9184664
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168915
Total [baseline] (9.257 s) : 0, 9256874
Agent [candidate] (1.177 s) : 0, 1176634
Total [candidate] (9.263 s) : 0, 9262926
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.17 s 117.238 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 118.489 ms (11.3%)
Agent iast_TELEMETRY_OFF 1.169 s 116.31 ms (11.0%)
Total tracing 8.692 s -
Total iast 9.268 s 575.804 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.199 s 506.912 ms (5.8%)
Total iast_TELEMETRY_OFF 9.257 s 564.683 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent iast 1.172 s 129.419 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.179 s 136.123 ms (13.1%)
Agent iast_TELEMETRY_OFF 1.177 s 133.754 ms (12.8%)
Total tracing 8.681 s -
Total iast 9.259 s 577.214 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.185 s 503.228 ms (5.8%)
Total iast_TELEMETRY_OFF 9.263 s 581.49 ms (6.7%)
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (726.774 ms) : 0, 726774
BytebuddyAgent [candidate] (717.562 ms) : 0, 717562
GlobalTracer [baseline] (240.705 ms) : 0, 240705
GlobalTracer [candidate] (240.05 ms) : 0, 240050
AppSec [baseline] (55.74 ms) : 0, 55740
AppSec [candidate] (55.382 ms) : 0, 55382
Remote Config [baseline] (699.24 µs) : 0, 699
Remote Config [candidate] (694.838 µs) : 0, 695
Telemetry [baseline] (13.714 ms) : 0, 13714
Telemetry [candidate] (14.226 ms) : 0, 14226
section iast
BytebuddyAgent [baseline] (836.081 ms) : 0, 836081
BytebuddyAgent [candidate] (837.629 ms) : 0, 837629
GlobalTracer [baseline] (229.908 ms) : 0, 229908
GlobalTracer [candidate] (230.891 ms) : 0, 230891
AppSec [baseline] (56.598 ms) : 0, 56598
AppSec [candidate] (56.664 ms) : 0, 56664
Remote Config [baseline] (615.627 µs) : 0, 616
Remote Config [candidate] (621.768 µs) : 0, 622
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.724 ms) : 0, 8724
IAST [baseline] (23.088 ms) : 0, 23088
IAST [candidate] (22.851 ms) : 0, 22851
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.881 ms) : 0, 836881
BytebuddyAgent [candidate] (842.845 ms) : 0, 842845
GlobalTracer [baseline] (230.687 ms) : 0, 230687
GlobalTracer [candidate] (231.602 ms) : 0, 231602
AppSec [baseline] (56.464 ms) : 0, 56464
AppSec [candidate] (56.97 ms) : 0, 56970
Remote Config [baseline] (616.696 µs) : 0, 617
Remote Config [candidate] (610.752 µs) : 0, 611
Telemetry [baseline] (8.685 ms) : 0, 8685
Telemetry [candidate] (8.767 ms) : 0, 8767
IAST [baseline] (22.784 ms) : 0, 22784
IAST [candidate] (23.202 ms) : 0, 23202
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.789 ms) : 0, 834789
BytebuddyAgent [candidate] (840.821 ms) : 0, 840821
GlobalTracer [baseline] (230.752 ms) : 0, 230752
GlobalTracer [candidate] (231.594 ms) : 0, 231594
AppSec [baseline] (56.797 ms) : 0, 56797
AppSec [candidate] (57.098 ms) : 0, 57098
Remote Config [baseline] (621.397 µs) : 0, 621
Remote Config [candidate] (622.02 µs) : 0, 622
Telemetry [baseline] (8.63 ms) : 0, 8630
Telemetry [candidate] (8.645 ms) : 0, 8645
IAST [baseline] (22.419 ms) : 0, 22419
IAST [candidate] (22.71 ms) : 0, 22710
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039976
Total [baseline] (10.533 s) : 0, 10532962
Agent [candidate] (1.043 s) : 0, 1043232
Total [candidate] (10.503 s) : 0, 10502601
section appsec
Agent [baseline] (1.184 s) : 0, 1184230
Total [baseline] (10.804 s) : 0, 10803875
Agent [candidate] (1.193 s) : 0, 1192638
Total [candidate] (10.808 s) : 0, 10808486
section iast
Agent [baseline] (1.168 s) : 0, 1168436
Total [baseline] (10.976 s) : 0, 10976050
Agent [candidate] (1.174 s) : 0, 1174191
Total [candidate] (11.001 s) : 0, 11000667
section profiling
Agent [baseline] (1.268 s) : 0, 1267730
Total [baseline] (10.944 s) : 0, 10943509
Agent [candidate] (1.259 s) : 0, 1258790
Total [candidate] (10.891 s) : 0, 10890707
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.04 s -
Agent appsec 1.184 s 144.255 ms (13.9%)
Agent iast 1.168 s 128.46 ms (12.4%)
Agent profiling 1.268 s 227.754 ms (21.9%)
Total tracing 10.533 s -
Total appsec 10.804 s 270.914 ms (2.6%)
Total iast 10.976 s 443.088 ms (4.2%)
Total profiling 10.944 s 410.547 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.193 s 149.406 ms (14.3%)
Agent iast 1.174 s 130.959 ms (12.6%)
Agent profiling 1.259 s 215.558 ms (20.7%)
Total tracing 10.503 s -
Total appsec 10.808 s 305.885 ms (2.9%)
Total iast 11.001 s 498.065 ms (4.7%)
Total profiling 10.891 s 388.106 ms (3.7%)
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.383 ms) : 0, 717383
BytebuddyAgent [candidate] (719.217 ms) : 0, 719217
GlobalTracer [baseline] (239.738 ms) : 0, 239738
GlobalTracer [candidate] (240.178 ms) : 0, 240178
AppSec [baseline] (55.056 ms) : 0, 55056
AppSec [candidate] (55.385 ms) : 0, 55385
Remote Config [baseline] (691.806 µs) : 0, 692
Remote Config [candidate] (685.236 µs) : 0, 685
Telemetry [baseline] (12.19 ms) : 0, 12190
Telemetry [candidate] (12.794 ms) : 0, 12794
section appsec
BytebuddyAgent [baseline] (736.025 ms) : 0, 736025
BytebuddyAgent [candidate] (742.295 ms) : 0, 742295
GlobalTracer [baseline] (236.787 ms) : 0, 236787
GlobalTracer [candidate] (237.999 ms) : 0, 237999
AppSec [baseline] (176.698 ms) : 0, 176698
AppSec [candidate] (177.165 ms) : 0, 177165
Remote Config [baseline] (667.321 µs) : 0, 667
Remote Config [candidate] (667.504 µs) : 0, 668
Telemetry [baseline] (8.297 ms) : 0, 8297
Telemetry [candidate] (8.659 ms) : 0, 8659
IAST [baseline] (21.667 ms) : 0, 21667
IAST [candidate] (21.672 ms) : 0, 21672
section iast
BytebuddyAgent [baseline] (834.896 ms) : 0, 834896
BytebuddyAgent [candidate] (838.718 ms) : 0, 838718
GlobalTracer [baseline] (230.003 ms) : 0, 230003
GlobalTracer [candidate] (230.961 ms) : 0, 230961
AppSec [baseline] (56.552 ms) : 0, 56552
AppSec [candidate] (57.131 ms) : 0, 57131
Remote Config [baseline] (600.594 µs) : 0, 601
Remote Config [candidate] (617.907 µs) : 0, 618
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.768 ms) : 0, 8768
IAST [baseline] (22.746 ms) : 0, 22746
IAST [candidate] (23.06 ms) : 0, 23060
section profiling
BytebuddyAgent [baseline] (714.46 ms) : 0, 714460
BytebuddyAgent [candidate] (709.414 ms) : 0, 709414
GlobalTracer [baseline] (350.668 ms) : 0, 350668
GlobalTracer [candidate] (349.529 ms) : 0, 349529
AppSec [baseline] (55.164 ms) : 0, 55164
AppSec [candidate] (53.87 ms) : 0, 53870
Remote Config [baseline] (687.839 µs) : 0, 688
Remote Config [candidate] (674.328 µs) : 0, 674
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (8.93 ms) : 0, 8930
ProfilingAgent [baseline] (97.072 ms) : 0, 97072
ProfilingAgent [candidate] (95.997 ms) : 0, 95997
Profiling [baseline] (97.097 ms) : 0, 97097
Profiling [candidate] (96.021 ms) : 0, 96021
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-07T16:14:33 2025-03-07T16:22:16
git_branch master mhlidd/config_consistency
git_commit_date 1741356784 1741363375
git_commit_sha 2575c71 da164b0
release_version 1.48.0-SNAPSHOT~2575c713ad 1.48.0-SNAPSHOT~da164b0edf
start_time 2025-03-07T16:14:19 2025-03-07T16:22:02
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741364933 1741364933
ci_job_id 838206654 838206654
ci_pipeline_id 58110817 58110817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pciukrgm-project-304-concurrent-0-omjeln1y 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pciukrgm-project-304-concurrent-0-omjeln1y 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
    dateFormat X
    axisFormat %s
section baseline
no_agent (384.104 µs) : 362, 406
.   : milestone, 384,
iast (509.126 µs) : 487, 531
.   : milestone, 509,
iast_FULL (728.893 µs) : 707, 751
.   : milestone, 729,
iast_GLOBAL (566.877 µs) : 545, 589
.   : milestone, 567,
iast_HARDCODED_SECRET_DISABLED (507.872 µs) : 486, 529
.   : milestone, 508,
iast_INACTIVE (462.67 µs) : 442, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (494.35 µs) : 473, 516
.   : milestone, 494,
tracing (461.822 µs) : 440, 483
.   : milestone, 462,
section candidate
no_agent (377.103 µs) : 357, 397
.   : milestone, 377,
iast (510.394 µs) : 488, 532
.   : milestone, 510,
iast_FULL (732.089 µs) : 710, 754
.   : milestone, 732,
iast_GLOBAL (561.077 µs) : 538, 584
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (517.277 µs) : 495, 539
.   : milestone, 517,
iast_INACTIVE (458.341 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (499.742 µs) : 477, 522
.   : milestone, 500,
tracing (449.882 µs) : 429, 470
.   : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.104 µs [362.396 µs, 405.813 µs] -
iast 509.126 µs [487.324 µs, 530.928 µs] 125.022 µs (32.5%)
iast_FULL 728.893 µs [707.075 µs, 750.711 µs] 344.789 µs (89.8%)
iast_GLOBAL 566.877 µs [544.758 µs, 588.996 µs] 182.773 µs (47.6%)
iast_HARDCODED_SECRET_DISABLED 507.872 µs [486.279 µs, 529.466 µs] 123.768 µs (32.2%)
iast_INACTIVE 462.67 µs [441.585 µs, 483.755 µs] 78.566 µs (20.5%)
iast_TELEMETRY_OFF 494.35 µs [472.513 µs, 516.187 µs] 110.246 µs (28.7%)
tracing 461.822 µs [440.15 µs, 483.494 µs] 77.718 µs (20.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.103 µs [357.46 µs, 396.745 µs] -
iast 510.394 µs [488.423 µs, 532.365 µs] 133.291 µs (35.3%)
iast_FULL 732.089 µs [710.031 µs, 754.148 µs] 354.987 µs (94.1%)
iast_GLOBAL 561.077 µs [537.808 µs, 584.346 µs] 183.974 µs (48.8%)
iast_HARDCODED_SECRET_DISABLED 517.277 µs [495.475 µs, 539.079 µs] 140.175 µs (37.2%)
iast_INACTIVE 458.341 µs [437.008 µs, 479.674 µs] 81.238 µs (21.5%)
iast_TELEMETRY_OFF 499.742 µs [477.032 µs, 522.451 µs] 122.639 µs (32.5%)
tracing 449.882 µs [429.328 µs, 470.436 µs] 72.78 µs (19.3%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1370
.   : milestone, 1349,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.735 ms) : 1710, 1761
.   : milestone, 1735,
code_origins (1.679 ms) : 1646, 1712
.   : milestone, 1679,
iast (1.504 ms) : 1480, 1529
.   : milestone, 1504,
profiling (1.508 ms) : 1484, 1532
.   : milestone, 1508,
tracing (1.48 ms) : 1454, 1506
.   : milestone, 1480,
section candidate
no_agent (1.365 ms) : 1345, 1384
.   : milestone, 1365,
appsec (1.72 ms) : 1696, 1744
.   : milestone, 1720,
appsec_no_iast (1.731 ms) : 1706, 1756
.   : milestone, 1731,
code_origins (1.703 ms) : 1671, 1735
.   : milestone, 1703,
iast (1.517 ms) : 1493, 1542
.   : milestone, 1517,
profiling (1.545 ms) : 1519, 1570
.   : milestone, 1545,
tracing (1.476 ms) : 1451, 1501
.   : milestone, 1476,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.329 ms, 1.37 ms] -
appsec 1.725 ms [1.701 ms, 1.749 ms] 375.36 µs (27.8%)
appsec_no_iast 1.735 ms [1.71 ms, 1.761 ms] 385.943 µs (28.6%)
code_origins 1.679 ms [1.646 ms, 1.712 ms] 329.77 µs (24.4%)
iast 1.504 ms [1.48 ms, 1.529 ms] 154.973 µs (11.5%)
profiling 1.508 ms [1.484 ms, 1.532 ms] 158.869 µs (11.8%)
tracing 1.48 ms [1.454 ms, 1.506 ms] 130.669 µs (9.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.345 ms, 1.384 ms] -
appsec 1.72 ms [1.696 ms, 1.744 ms] 355.69 µs (26.1%)
appsec_no_iast 1.731 ms [1.706 ms, 1.756 ms] 366.408 µs (26.9%)
code_origins 1.703 ms [1.671 ms, 1.735 ms] 338.05 µs (24.8%)
iast 1.517 ms [1.493 ms, 1.542 ms] 152.563 µs (11.2%)
profiling 1.545 ms [1.519 ms, 1.57 ms] 180.213 µs (13.2%)
tracing 1.476 ms [1.451 ms, 1.501 ms] 111.663 µs (8.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mhlidd/config_consistency
git_commit_date 1741356784 1741363375
git_commit_sha 2575c71 da164b0
release_version 1.48.0-SNAPSHOT~2575c713ad 1.48.0-SNAPSHOT~da164b0edf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741365276 1741365276
ci_job_id 838206655 838206655
ci_pipeline_id 58110817 58110817
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-t3ggepcs-project-304-concurrent-1-vpbxi6bz 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-t3ggepcs-project-304-concurrent-1-vpbxi6bz 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
appsec (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
iast (18.829 s) : 18829000, 18829000
.   : milestone, 18829000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
.   : milestone, 17818000,
profiling (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
tracing (14.763 s) : 14763000, 14763000
.   : milestone, 14763000,
section candidate
no_agent (15.216 s) : 15216000, 15216000
.   : milestone, 15216000,
appsec (15.206 s) : 15206000, 15206000
.   : milestone, 15206000,
iast (18.676 s) : 18676000, 18676000
.   : milestone, 18676000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
.   : milestone, 18101000,
profiling (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
tracing (14.985 s) : 14985000, 14985000
.   : milestone, 14985000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.955 s [14.955 s, 14.955 s] -
appsec 15.0 s [15.0 s, 15.0 s] 45.0 ms (0.3%)
iast 18.829 s [18.829 s, 18.829 s] 3.874 s (25.9%)
iast_GLOBAL 17.818 s [17.818 s, 17.818 s] 2.863 s (19.1%)
profiling 15.133 s [15.133 s, 15.133 s] 178.0 ms (1.2%)
tracing 14.763 s [14.763 s, 14.763 s] -192.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.216 s [15.216 s, 15.216 s] -
appsec 15.206 s [15.206 s, 15.206 s] -10.0 ms (-0.1%)
iast 18.676 s [18.676 s, 18.676 s] 3.46 s (22.7%)
iast_GLOBAL 18.101 s [18.101 s, 18.101 s] 2.885 s (19.0%)
profiling 15.21 s [15.21 s, 15.21 s] -6.0 ms (-0.0%)
tracing 14.985 s [14.985 s, 14.985 s] -231.0 ms (-1.5%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~da164b0edf, baseline=1.48.0-SNAPSHOT~2575c713ad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
.   : milestone, 1467,
appsec (2.33 ms) : 2287, 2373
.   : milestone, 2330,
iast (2.103 ms) : 2048, 2158
.   : milestone, 2103,
iast_GLOBAL (2.153 ms) : 2098, 2208
.   : milestone, 2153,
profiling (1.99 ms) : 1945, 2034
.   : milestone, 1990,
tracing (1.942 ms) : 1900, 1984
.   : milestone, 1942,
section candidate
no_agent (1.467 ms) : 1455, 1478
.   : milestone, 1467,
appsec (2.322 ms) : 2279, 2365
.   : milestone, 2322,
iast (2.107 ms) : 2052, 2161
.   : milestone, 2107,
iast_GLOBAL (2.15 ms) : 2094, 2205
.   : milestone, 2150,
profiling (1.983 ms) : 1938, 2028
.   : milestone, 1983,
tracing (1.946 ms) : 1903, 1989
.   : milestone, 1946,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.456 ms, 1.479 ms] -
appsec 2.33 ms [2.287 ms, 2.373 ms] 862.993 µs (58.8%)
iast 2.103 ms [2.048 ms, 2.158 ms] 635.874 µs (43.3%)
iast_GLOBAL 2.153 ms [2.098 ms, 2.208 ms] 685.704 µs (46.7%)
profiling 1.99 ms [1.945 ms, 2.034 ms] 522.458 µs (35.6%)
tracing 1.942 ms [1.9 ms, 1.984 ms] 475.114 µs (32.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.467 ms [1.455 ms, 1.478 ms] -
appsec 2.322 ms [2.279 ms, 2.365 ms] 855.192 µs (58.3%)
iast 2.107 ms [2.052 ms, 2.161 ms] 640.289 µs (43.7%)
iast_GLOBAL 2.15 ms [2.094 ms, 2.205 ms] 683.144 µs (46.6%)
profiling 1.983 ms [1.938 ms, 2.028 ms] 516.057 µs (35.2%)
tracing 1.946 ms [1.903 ms, 1.989 ms] 479.185 µs (32.7%)

@mhlidd mhlidd marked this pull request as ready for review March 4, 2025 21:06
@mhlidd mhlidd requested a review from a team as a code owner March 4, 2025 21:06
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@mhlidd mhlidd added comp: api Tracer public API type: enhancement labels Mar 4, 2025
@mhlidd mhlidd marked this pull request as draft March 4, 2025 21:18
@mhlidd mhlidd marked this pull request as ready for review March 6, 2025 16:00
@mhlidd mhlidd requested a review from a team as a code owner March 6, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant