Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remote configuration for API Security sampling rate #8486

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Remove remote configuration for API Security sampling rate #8486

merged 2 commits into from
Mar 5, 2025
+3 −111

Conversation

smola
Copy link
Member

@smola smola commented Mar 3, 2025 •
edited by jira bot
Loading

What Does This Do

Remove the old system to configure API Security sampling rate via remote config. This is currently not exposed in the UI, and the backend is being decomisioned. It was never in operation in production.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-54874

@smola smola added type: refactoring comp: asm waf Application Security Management (WAF) labels Mar 3, 2025
@smola smola changed the title Remove API Security sampling configuration via remote configuration Remove remote configuration API Security sampling rate Mar 3, 2025
@smola smola changed the title Remove remote configuration API Security sampling rate Remove remote configuration for API Security sampling rate Mar 3, 2025
@smola smola marked this pull request as ready for review March 3, 2025 17:01
@smola smola requested a review from a team as a code owner March 3, 2025 17:01
@smola smola requested review from robertpi and sezen-datadog March 3, 2025 17:01
@pr-commenter
Copy link

pr-commenter bot commented Mar 3, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/remove-old-api-sec-sampling-rc
git_commit_date 1741124606 1741158779
git_commit_sha 7787c9d 5ba0e37
release_version 1.47.0-SNAPSHOT~7787c9ddf9 1.47.0-SNAPSHOT~5ba0e37c58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741161223 1741161223
ci_job_id 833073599 833073599
ci_pipeline_id 57750168 57750168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-46nhganc-project-304-concurrent-0-qvd41itw 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-46nhganc-project-304-concurrent-0-qvd41itw 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041382
Total [baseline] (8.672 s) : 0, 8672188
Agent [candidate] (1.049 s) : 0, 1049336
Total [candidate] (8.693 s) : 0, 8693031
section iast
Agent [baseline] (1.178 s) : 0, 1178368
Total [baseline] (9.242 s) : 0, 9242428
Agent [candidate] (1.172 s) : 0, 1171576
Total [candidate] (9.235 s) : 0, 9235259
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190616
Total [baseline] (9.274 s) : 0, 9273573
Agent [candidate] (1.184 s) : 0, 1183874
Total [candidate] (9.232 s) : 0, 9232045
section iast_TELEMETRY_OFF
Agent [baseline] (1.164 s) : 0, 1163811
Total [baseline] (9.235 s) : 0, 9235076
Agent [candidate] (1.167 s) : 0, 1167221
Total [candidate] (9.24 s) : 0, 9240335
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent iast 1.178 s 136.986 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 149.234 ms (14.3%)
Agent iast_TELEMETRY_OFF 1.164 s 122.429 ms (11.8%)
Total tracing 8.672 s -
Total iast 9.242 s 570.24 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.274 s 601.385 ms (6.9%)
Total iast_TELEMETRY_OFF 9.235 s 562.888 ms (6.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent iast 1.172 s 122.24 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 134.537 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.167 s 117.885 ms (11.2%)
Total tracing 8.693 s -
Total iast 9.235 s 542.228 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.232 s 539.014 ms (6.2%)
Total iast_TELEMETRY_OFF 9.24 s 547.304 ms (6.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.713 ms) : 0, 718713
BytebuddyAgent [candidate] (722.086 ms) : 0, 722086
GlobalTracer [baseline] (239.795 ms) : 0, 239795
GlobalTracer [candidate] (241.075 ms) : 0, 241075
AppSec [baseline] (55.845 ms) : 0, 55845
AppSec [candidate] (55.502 ms) : 0, 55502
Remote Config [baseline] (694.179 µs) : 0, 694
Remote Config [candidate] (701.873 µs) : 0, 702
Telemetry [baseline] (11.396 ms) : 0, 11396
Telemetry [candidate] (14.915 ms) : 0, 14915
section iast
BytebuddyAgent [baseline] (842.647 ms) : 0, 842647
BytebuddyAgent [candidate] (837.259 ms) : 0, 837259
GlobalTracer [baseline] (231.454 ms) : 0, 231454
GlobalTracer [candidate] (230.508 ms) : 0, 230508
AppSec [baseline] (56.957 ms) : 0, 56957
AppSec [candidate] (56.863 ms) : 0, 56863
Remote Config [baseline] (619.027 µs) : 0, 619
Remote Config [candidate] (613.784 µs) : 0, 614
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (8.651 ms) : 0, 8651
IAST [baseline] (22.893 ms) : 0, 22893
IAST [candidate] (22.769 ms) : 0, 22769
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (850.219 ms) : 0, 850219
BytebuddyAgent [candidate] (845.996 ms) : 0, 845996
GlobalTracer [baseline] (233.401 ms) : 0, 233401
GlobalTracer [candidate] (233.025 ms) : 0, 233025
AppSec [baseline] (58.226 ms) : 0, 58226
AppSec [candidate] (56.987 ms) : 0, 56987
Remote Config [baseline] (645.944 µs) : 0, 646
Remote Config [candidate] (616.526 µs) : 0, 617
Telemetry [baseline] (9.055 ms) : 0, 9055
Telemetry [candidate] (8.699 ms) : 0, 8699
IAST [baseline] (23.924 ms) : 0, 23924
IAST [candidate] (23.351 ms) : 0, 23351
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.194 ms) : 0, 831194
BytebuddyAgent [candidate] (833.255 ms) : 0, 833255
GlobalTracer [baseline] (229.371 ms) : 0, 229371
GlobalTracer [candidate] (230.191 ms) : 0, 230191
AppSec [baseline] (53.658 ms) : 0, 53658
AppSec [candidate] (53.946 ms) : 0, 53946
Remote Config [baseline] (613.19 µs) : 0, 613
Remote Config [candidate] (633.041 µs) : 0, 633
Telemetry [baseline] (8.586 ms) : 0, 8586
Telemetry [candidate] (8.72 ms) : 0, 8720
IAST [baseline] (25.507 ms) : 0, 25507
IAST [candidate] (25.527 ms) : 0, 25527
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040728
Total [baseline] (10.475 s) : 0, 10475213
Agent [candidate] (1.046 s) : 0, 1046275
Total [candidate] (10.556 s) : 0, 10555819
section appsec
Agent [baseline] (1.187 s) : 0, 1187001
Total [baseline] (10.782 s) : 0, 10781773
Agent [candidate] (1.191 s) : 0, 1190831
Total [candidate] (10.781 s) : 0, 10780657
section iast
Agent [baseline] (1.18 s) : 0, 1180141
Total [baseline] (11.039 s) : 0, 11038642
Agent [candidate] (1.181 s) : 0, 1180773
Total [candidate] (11.037 s) : 0, 11036686
section profiling
Agent [baseline] (1.27 s) : 0, 1270351
Total [baseline] (10.909 s) : 0, 10908554
Agent [candidate] (1.26 s) : 0, 1260326
Total [candidate] (10.926 s) : 0, 10925931
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.187 s 146.274 ms (14.1%)
Agent iast 1.18 s 139.414 ms (13.4%)
Agent profiling 1.27 s 229.623 ms (22.1%)
Total tracing 10.475 s -
Total appsec 10.782 s 306.561 ms (2.9%)
Total iast 11.039 s 563.429 ms (5.4%)
Total profiling 10.909 s 433.341 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.191 s 144.556 ms (13.8%)
Agent iast 1.181 s 134.498 ms (12.9%)
Agent profiling 1.26 s 214.051 ms (20.5%)
Total tracing 10.556 s -
Total appsec 10.781 s 224.838 ms (2.1%)
Total iast 11.037 s 480.867 ms (4.6%)
Total profiling 10.926 s 370.111 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.904 ms) : 0, 716904
BytebuddyAgent [candidate] (723.104 ms) : 0, 723104
GlobalTracer [baseline] (239.075 ms) : 0, 239075
GlobalTracer [candidate] (241.344 ms) : 0, 241344
AppSec [baseline] (55.638 ms) : 0, 55638
AppSec [candidate] (55.402 ms) : 0, 55402
Remote Config [baseline] (681.406 µs) : 0, 681
Remote Config [candidate] (690.101 µs) : 0, 690
Telemetry [baseline] (13.532 ms) : 0, 13532
Telemetry [candidate] (10.738 ms) : 0, 10738
section appsec
BytebuddyAgent [baseline] (737.66 ms) : 0, 737660
BytebuddyAgent [candidate] (741.146 ms) : 0, 741146
GlobalTracer [baseline] (237.059 ms) : 0, 237059
GlobalTracer [candidate] (237.475 ms) : 0, 237475
AppSec [baseline] (177.179 ms) : 0, 177179
AppSec [candidate] (177.375 ms) : 0, 177375
Remote Config [baseline] (665.804 µs) : 0, 666
Remote Config [candidate] (667.723 µs) : 0, 668
Telemetry [baseline] (8.62 ms) : 0, 8620
Telemetry [candidate] (8.311 ms) : 0, 8311
IAST [baseline] (21.743 ms) : 0, 21743
IAST [candidate] (21.608 ms) : 0, 21608
section iast
BytebuddyAgent [baseline] (842.719 ms) : 0, 842719
BytebuddyAgent [candidate] (844.076 ms) : 0, 844076
GlobalTracer [baseline] (232.169 ms) : 0, 232169
GlobalTracer [candidate] (232.203 ms) : 0, 232203
AppSec [baseline] (57.777 ms) : 0, 57777
AppSec [candidate] (56.985 ms) : 0, 56985
Remote Config [baseline] (625.958 µs) : 0, 626
Remote Config [candidate] (611.693 µs) : 0, 612
Telemetry [baseline] (8.777 ms) : 0, 8777
Telemetry [candidate] (8.683 ms) : 0, 8683
IAST [baseline] (23.078 ms) : 0, 23078
IAST [candidate] (23.1 ms) : 0, 23100
section profiling
ProfilingAgent [baseline] (97.366 ms) : 0, 97366
ProfilingAgent [candidate] (95.53 ms) : 0, 95530
BytebuddyAgent [baseline] (714.276 ms) : 0, 714276
BytebuddyAgent [candidate] (709.126 ms) : 0, 709126
GlobalTracer [baseline] (352.361 ms) : 0, 352361
GlobalTracer [candidate] (351.341 ms) : 0, 351341
AppSec [baseline] (55.974 ms) : 0, 55974
AppSec [candidate] (54.185 ms) : 0, 54185
Remote Config [baseline] (687.73 µs) : 0, 688
Remote Config [candidate] (690.202 µs) : 0, 690
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (9.04 ms) : 0, 9040
Profiling [baseline] (97.391 ms) : 0, 97391
Profiling [candidate] (95.557 ms) : 0, 95557
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-05T07:23:55 2025-03-05T07:31:38
git_branch master smola/remove-old-api-sec-sampling-rc
git_commit_date 1741124606 1741158779
git_commit_sha 7787c9d 5ba0e37
release_version 1.47.0-SNAPSHOT~7787c9ddf9 1.47.0-SNAPSHOT~5ba0e37c58
start_time 2025-03-05T07:23:41 2025-03-05T07:31:24
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741160296 1741160296
ci_job_id 833073600 833073600
ci_pipeline_id 57750168 57750168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-o2jwfd6w-project-304-concurrent-0-to3e17fc 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-o2jwfd6w-project-304-concurrent-0-to3e17fc 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1334, 1373
.   : milestone, 1354,
appsec (1.726 ms) : 1702, 1749
.   : milestone, 1726,
appsec_no_iast (1.728 ms) : 1703, 1752
.   : milestone, 1728,
code_origins (1.675 ms) : 1642, 1709
.   : milestone, 1675,
iast (1.513 ms) : 1488, 1537
.   : milestone, 1513,
profiling (1.539 ms) : 1514, 1565
.   : milestone, 1539,
tracing (1.472 ms) : 1447, 1497
.   : milestone, 1472,
section candidate
no_agent (1.346 ms) : 1326, 1365
.   : milestone, 1346,
appsec (1.732 ms) : 1709, 1755
.   : milestone, 1732,
appsec_no_iast (1.716 ms) : 1690, 1742
.   : milestone, 1716,
code_origins (1.698 ms) : 1666, 1731
.   : milestone, 1698,
iast (1.506 ms) : 1482, 1531
.   : milestone, 1506,
profiling (1.532 ms) : 1507, 1557
.   : milestone, 1532,
tracing (1.499 ms) : 1474, 1524
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.334 ms, 1.373 ms] -
appsec 1.726 ms [1.702 ms, 1.749 ms] 371.954 µs (27.5%)
appsec_no_iast 1.728 ms [1.703 ms, 1.752 ms] 373.861 µs (27.6%)
code_origins 1.675 ms [1.642 ms, 1.709 ms] 321.701 µs (23.8%)
iast 1.513 ms [1.488 ms, 1.537 ms] 159.018 µs (11.7%)
profiling 1.539 ms [1.514 ms, 1.565 ms] 185.662 µs (13.7%)
tracing 1.472 ms [1.447 ms, 1.497 ms] 118.242 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.326 ms, 1.365 ms] -
appsec 1.732 ms [1.709 ms, 1.755 ms] 386.415 µs (28.7%)
appsec_no_iast 1.716 ms [1.69 ms, 1.742 ms] 370.522 µs (27.5%)
code_origins 1.698 ms [1.666 ms, 1.731 ms] 352.657 µs (26.2%)
iast 1.506 ms [1.482 ms, 1.531 ms] 160.694 µs (11.9%)
profiling 1.532 ms [1.507 ms, 1.557 ms] 186.221 µs (13.8%)
tracing 1.499 ms [1.474 ms, 1.524 ms] 153.599 µs (11.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.012 µs) : 357, 397
.   : milestone, 377,
iast (508.512 µs) : 487, 530
.   : milestone, 509,
iast_FULL (730.171 µs) : 708, 752
.   : milestone, 730,
iast_GLOBAL (563.017 µs) : 540, 586
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (509.201 µs) : 487, 531
.   : milestone, 509,
iast_INACTIVE (461.428 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (495.571 µs) : 473, 518
.   : milestone, 496,
tracing (457.728 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (375.966 µs) : 355, 396
.   : milestone, 376,
iast (509.824 µs) : 487, 533
.   : milestone, 510,
iast_FULL (727.349 µs) : 705, 749
.   : milestone, 727,
iast_GLOBAL (575.422 µs) : 552, 599
.   : milestone, 575,
iast_HARDCODED_SECRET_DISABLED (505.631 µs) : 484, 527
.   : milestone, 506,
iast_INACTIVE (462.658 µs) : 441, 484
.   : milestone, 463,
iast_TELEMETRY_OFF (497.544 µs) : 476, 519
.   : milestone, 498,
tracing (454.123 µs) : 433, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.012 µs [357.253 µs, 396.77 µs] -
iast 508.512 µs [486.645 µs, 530.379 µs] 131.5 µs (34.9%)
iast_FULL 730.171 µs [708.246 µs, 752.095 µs] 353.159 µs (93.7%)
iast_GLOBAL 563.017 µs [540.093 µs, 585.941 µs] 186.006 µs (49.3%)
iast_HARDCODED_SECRET_DISABLED 509.201 µs [487.336 µs, 531.067 µs] 132.19 µs (35.1%)
iast_INACTIVE 461.428 µs [440.379 µs, 482.477 µs] 84.416 µs (22.4%)
iast_TELEMETRY_OFF 495.571 µs [472.89 µs, 518.252 µs] 118.559 µs (31.4%)
tracing 457.728 µs [436.563 µs, 478.893 µs] 80.716 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 375.966 µs [355.493 µs, 396.44 µs] -
iast 509.824 µs [486.745 µs, 532.903 µs] 133.858 µs (35.6%)
iast_FULL 727.349 µs [705.307 µs, 749.391 µs] 351.383 µs (93.5%)
iast_GLOBAL 575.422 µs [551.87 µs, 598.974 µs] 199.456 µs (53.1%)
iast_HARDCODED_SECRET_DISABLED 505.631 µs [484.122 µs, 527.14 µs] 129.665 µs (34.5%)
iast_INACTIVE 462.658 µs [441.396 µs, 483.92 µs] 86.692 µs (23.1%)
iast_TELEMETRY_OFF 497.544 µs [475.91 µs, 519.178 µs] 121.578 µs (32.3%)
tracing 454.123 µs [432.757 µs, 475.488 µs] 78.156 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/remove-old-api-sec-sampling-rc
git_commit_date 1741124606 1741158779
git_commit_sha 7787c9d 5ba0e37
release_version 1.47.0-SNAPSHOT~7787c9ddf9 1.47.0-SNAPSHOT~5ba0e37c58
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741160787 1741160787
ci_job_id 833073601 833073601
ci_pipeline_id 57750168 57750168
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-46nhganc-project-304-concurrent-1-ejdbnlz9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-46nhganc-project-304-concurrent-1-ejdbnlz9 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.27 s) : 15270000, 15270000
.   : milestone, 15270000,
appsec (14.934 s) : 14934000, 14934000
.   : milestone, 14934000,
iast (18.309 s) : 18309000, 18309000
.   : milestone, 18309000,
iast_GLOBAL (17.805 s) : 17805000, 17805000
.   : milestone, 17805000,
profiling (15.579 s) : 15579000, 15579000
.   : milestone, 15579000,
tracing (14.935 s) : 14935000, 14935000
.   : milestone, 14935000,
section candidate
no_agent (14.913 s) : 14913000, 14913000
.   : milestone, 14913000,
appsec (14.938 s) : 14938000, 14938000
.   : milestone, 14938000,
iast (18.689 s) : 18689000, 18689000
.   : milestone, 18689000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
.   : milestone, 17704000,
profiling (14.959 s) : 14959000, 14959000
.   : milestone, 14959000,
tracing (15.002 s) : 15002000, 15002000
.   : milestone, 15002000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.27 s [15.27 s, 15.27 s] -
appsec 14.934 s [14.934 s, 14.934 s] -336.0 ms (-2.2%)
iast 18.309 s [18.309 s, 18.309 s] 3.039 s (19.9%)
iast_GLOBAL 17.805 s [17.805 s, 17.805 s] 2.535 s (16.6%)
profiling 15.579 s [15.579 s, 15.579 s] 309.0 ms (2.0%)
tracing 14.935 s [14.935 s, 14.935 s] -335.0 ms (-2.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.913 s [14.913 s, 14.913 s] -
appsec 14.938 s [14.938 s, 14.938 s] 25.0 ms (0.2%)
iast 18.689 s [18.689 s, 18.689 s] 3.776 s (25.3%)
iast_GLOBAL 17.704 s [17.704 s, 17.704 s] 2.791 s (18.7%)
profiling 14.959 s [14.959 s, 14.959 s] 46.0 ms (0.3%)
tracing 15.002 s [15.002 s, 15.002 s] 89.0 ms (0.6%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~5ba0e37c58, baseline=1.47.0-SNAPSHOT~7787c9ddf9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.332 ms) : 2288, 2376
.   : milestone, 2332,
iast (2.109 ms) : 2054, 2165
.   : milestone, 2109,
iast_GLOBAL (2.156 ms) : 2100, 2211
.   : milestone, 2156,
profiling (1.974 ms) : 1931, 2018
.   : milestone, 1974,
tracing (1.936 ms) : 1895, 1978
.   : milestone, 1936,
section candidate
no_agent (1.471 ms) : 1460, 1482
.   : milestone, 1471,
appsec (2.342 ms) : 2298, 2386
.   : milestone, 2342,
iast (2.114 ms) : 2059, 2169
.   : milestone, 2114,
iast_GLOBAL (2.164 ms) : 2108, 2220
.   : milestone, 2164,
profiling (1.974 ms) : 1930, 2018
.   : milestone, 1974,
tracing (1.94 ms) : 1898, 1982
.   : milestone, 1940,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.332 ms [2.288 ms, 2.376 ms] 863.909 µs (58.8%)
iast 2.109 ms [2.054 ms, 2.165 ms] 641.287 µs (43.7%)
iast_GLOBAL 2.156 ms [2.1 ms, 2.211 ms] 687.4 µs (46.8%)
profiling 1.974 ms [1.931 ms, 2.018 ms] 506.0 µs (34.5%)
tracing 1.936 ms [1.895 ms, 1.978 ms] 468.174 µs (31.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.482 ms] -
appsec 2.342 ms [2.298 ms, 2.386 ms] 871.036 µs (59.2%)
iast 2.114 ms [2.059 ms, 2.169 ms] 643.044 µs (43.7%)
iast_GLOBAL 2.164 ms [2.108 ms, 2.22 ms] 693.442 µs (47.1%)
profiling 1.974 ms [1.93 ms, 2.018 ms] 502.904 µs (34.2%)
tracing 1.94 ms [1.898 ms, 1.982 ms] 469.275 µs (31.9%)

@smola smola merged commit 0f1105d into master Mar 5, 2025
209 checks passed
@smola smola deleted the smola/remove-old-api-sec-sampling-rc branch March 5, 2025 13:26
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezen-datadog sezen-datadog sezen-datadog approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @sezen-datadog @ValentinZakharov