Add setUser to user monitoring SDK #8482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuel-alvarez-alvarez
added
type: enhancement
comp: asm waf
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
dd-trace-api/src/main/java/datadog/appsec/api/user/UserService.java
Outdated
Show resolved
Hide resolved
manuel-alvarez-alvarez
force-pushed
the
malvarez/waf-set-user-sdk
branch
2 times, most recently
from
5eaffba to
b3dcd02
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 23 performance improvements and 8 performance regressions! Performance is the same for 26 metrics, 6 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1134897
Total [baseline] (11.425 s) : 0, 11425401
Agent [candidate] (1.042 s) : 0, 1041647
Total [candidate] (10.399 s) : 0, 10399456
section appsec
Agent [baseline] (1.275 s) : 0, 1275000
Total [baseline] (11.672 s) : 0, 11671969
Agent [candidate] (1.185 s) : 0, 1185218
Total [candidate] (10.762 s) : 0, 10761945
section iast
Agent [baseline] (1.261 s) : 0, 1261176
Total [baseline] (11.901 s) : 0, 11900523
Agent [candidate] (1.173 s) : 0, 1173156
Total [candidate] (10.965 s) : 0, 10964675
section profiling
Agent [baseline] (1.386 s) : 0, 1385793
Total [baseline] (11.787 s) : 0, 11786590
Agent [candidate] (1.272 s) : 0, 1271669
Total [candidate] (10.85 s) : 0, 10850386
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.826 ms) : 0, 716826
BytebuddyAgent [candidate] (719.06 ms) : 0, 719060
GlobalTracer [baseline] (239.941 ms) : 0, 239941
GlobalTracer [candidate] (239.48 ms) : 0, 239480
AppSec [baseline] (55.603 ms) : 0, 55603
AppSec [candidate] (55.011 ms) : 0, 55011
Remote Config [baseline] (603.554 µs) : 0, 604
Remote Config [candidate] (686.637 µs) : 0, 687
Telemetry [baseline] (12.449 ms) : 0, 12449
Telemetry [candidate] (11.335 ms) : 0, 11335
Debugger [baseline] (94.434 ms) : 0, 94434
section appsec
BytebuddyAgent [baseline] (737.618 ms) : 0, 737618
BytebuddyAgent [candidate] (735.633 ms) : 0, 735633
GlobalTracer [baseline] (236.686 ms) : 0, 236686
GlobalTracer [candidate] (236.342 ms) : 0, 236342
AppSec [baseline] (177.658 ms) : 0, 177658
AppSec [candidate] (176.965 ms) : 0, 176965
Remote Config [baseline] (623.004 µs) : 0, 623
Remote Config [candidate] (659.052 µs) : 0, 659
Telemetry [baseline] (12.316 ms) : 0, 12316
Telemetry [candidate] (8.665 ms) : 0, 8665
Debugger [baseline] (84.22 ms) : 0, 84220
IAST [baseline] (21.74 ms) : 0, 21740
IAST [candidate] (21.758 ms) : 0, 21758
section iast
BytebuddyAgent [baseline] (838.74 ms) : 0, 838740
BytebuddyAgent [candidate] (838.368 ms) : 0, 838368
GlobalTracer [baseline] (230.476 ms) : 0, 230476
GlobalTracer [candidate] (230.239 ms) : 0, 230239
AppSec [baseline] (57.434 ms) : 0, 57434
AppSec [candidate] (56.394 ms) : 0, 56394
Remote Config [baseline] (527.842 µs) : 0, 528
Remote Config [candidate] (605.203 µs) : 0, 605
Telemetry [baseline] (12.32 ms) : 0, 12320
Telemetry [candidate] (8.625 ms) : 0, 8625
Debugger [baseline] (83.807 ms) : 0, 83807
IAST [baseline] (22.816 ms) : 0, 22816
IAST [candidate] (22.842 ms) : 0, 22842
section profiling
BytebuddyAgent [baseline] (714.4 ms) : 0, 714400
BytebuddyAgent [candidate] (715.679 ms) : 0, 715679
GlobalTracer [baseline] (351.659 ms) : 0, 351659
GlobalTracer [candidate] (352.993 ms) : 0, 352993
AppSec [baseline] (55.173 ms) : 0, 55173
AppSec [candidate] (54.333 ms) : 0, 54333
Remote Config [baseline] (603.365 µs) : 0, 603
Remote Config [candidate] (678.434 µs) : 0, 678
Telemetry [baseline] (12.557 ms) : 0, 12557
Telemetry [candidate] (9.181 ms) : 0, 9181
Debugger [baseline] (87.791 ms) : 0, 87791
ProfilingAgent [baseline] (122.928 ms) : 0, 122928
ProfilingAgent [candidate] (97.102 ms) : 0, 97102
Profiling [baseline] (122.95 ms) : 0, 122950
Profiling [candidate] (97.128 ms) : 0, 97128
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.136 s) : 0, 1136314
Total [baseline] (9.285 s) : 0, 9285181
Agent [candidate] (1.039 s) : 0, 1039286
Total [candidate] (8.648 s) : 0, 8647739
section iast
Agent [baseline] (1.263 s) : 0, 1263268
Total [baseline] (9.856 s) : 0, 9856015
Agent [candidate] (1.17 s) : 0, 1170403
Total [candidate] (9.259 s) : 0, 9258613
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.257 s) : 0, 1256601
Total [baseline] (9.841 s) : 0, 9840803
Agent [candidate] (1.172 s) : 0, 1171746
Total [candidate] (9.176 s) : 0, 9176102
section iast_TELEMETRY_OFF
Agent [baseline] (1.255 s) : 0, 1254961
Total [baseline] (9.855 s) : 0, 9854673
Agent [candidate] (1.168 s) : 0, 1167971
Total [candidate] (9.248 s) : 0, 9248106
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.022 ms) : 0, 718022
BytebuddyAgent [candidate] (716.313 ms) : 0, 716313
GlobalTracer [baseline] (239.579 ms) : 0, 239579
GlobalTracer [candidate] (238.934 ms) : 0, 238934
AppSec [baseline] (55.385 ms) : 0, 55385
AppSec [candidate] (55.072 ms) : 0, 55072
Remote Config [baseline] (589.201 µs) : 0, 589
Remote Config [candidate] (707.668 µs) : 0, 708
Telemetry [baseline] (12.54 ms) : 0, 12540
Telemetry [candidate] (12.206 ms) : 0, 12206
Debugger [baseline] (95.11 ms) : 0, 95110
section iast
BytebuddyAgent [baseline] (841.942 ms) : 0, 841942
BytebuddyAgent [candidate] (835.841 ms) : 0, 835841
GlobalTracer [baseline] (230.031 ms) : 0, 230031
GlobalTracer [candidate] (230.118 ms) : 0, 230118
AppSec [baseline] (57.211 ms) : 0, 57211
AppSec [candidate] (56.54 ms) : 0, 56540
Remote Config [baseline] (512.568 µs) : 0, 513
Remote Config [candidate] (604.159 µs) : 0, 604
Telemetry [baseline] (12.185 ms) : 0, 12185
Telemetry [candidate] (8.585 ms) : 0, 8585
Debugger [baseline] (83.528 ms) : 0, 83528
IAST [baseline] (22.768 ms) : 0, 22768
IAST [candidate] (22.634 ms) : 0, 22634
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.193 ms) : 0, 835193
BytebuddyAgent [candidate] (836.558 ms) : 0, 836558
GlobalTracer [baseline] (230.027 ms) : 0, 230027
GlobalTracer [candidate] (229.95 ms) : 0, 229950
AppSec [baseline] (56.339 ms) : 0, 56339
AppSec [candidate] (56.832 ms) : 0, 56832
Remote Config [baseline] (515.084 µs) : 0, 515
Remote Config [candidate] (611.855 µs) : 0, 612
Telemetry [baseline] (12.29 ms) : 0, 12290
Telemetry [candidate] (8.769 ms) : 0, 8769
Debugger [baseline] (83.4 ms) : 0, 83400
IAST [baseline] (23.841 ms) : 0, 23841
IAST [candidate] (22.955 ms) : 0, 22955
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.666 ms) : 0, 834666
BytebuddyAgent [candidate] (833.545 ms) : 0, 833545
GlobalTracer [baseline] (230.217 ms) : 0, 230217
GlobalTracer [candidate] (230.179 ms) : 0, 230179
AppSec [baseline] (54.49 ms) : 0, 54490
AppSec [candidate] (54.443 ms) : 0, 54443
Remote Config [baseline] (522.994 µs) : 0, 523
Remote Config [candidate] (619.466 µs) : 0, 619
Telemetry [baseline] (12.064 ms) : 0, 12064
Telemetry [candidate] (8.68 ms) : 0, 8680
Debugger [baseline] (83.331 ms) : 0, 83331
IAST [baseline] (24.513 ms) : 0, 24513
IAST [candidate] (23.809 ms) : 0, 23809
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section baseline
no_agent (384.866 µs) : 364, 406
. : milestone, 385,
iast (514.575 µs) : 492, 537
. : milestone, 515,
iast_FULL (731.65 µs) : 709, 754
. : milestone, 732,
iast_GLOBAL (561.824 µs) : 539, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (514.882 µs) : 493, 537
. : milestone, 515,
iast_INACTIVE (462.275 µs) : 440, 484
. : milestone, 462,
iast_TELEMETRY_OFF (495.298 µs) : 473, 517
. : milestone, 495,
tracing (469.643 µs) : 448, 491
. : milestone, 470,
section candidate
no_agent (386.207 µs) : 364, 409
. : milestone, 386,
iast (510.704 µs) : 488, 533
. : milestone, 511,
iast_FULL (727.322 µs) : 706, 749
. : milestone, 727,
iast_GLOBAL (561.078 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (516.456 µs) : 494, 539
. : milestone, 516,
iast_INACTIVE (461.478 µs) : 440, 483
. : milestone, 461,
iast_TELEMETRY_OFF (506.133 µs) : 483, 530
. : milestone, 506,
tracing (455.568 µs) : 435, 476
. : milestone, 456,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1390
. : milestone, 1370,
appsec (1.733 ms) : 1709, 1757
. : milestone, 1733,
appsec_no_iast (1.716 ms) : 1692, 1741
. : milestone, 1716,
code_origins (1.676 ms) : 1643, 1710
. : milestone, 1676,
iast (1.515 ms) : 1490, 1539
. : milestone, 1515,
profiling (1.519 ms) : 1494, 1545
. : milestone, 1519,
tracing (1.497 ms) : 1474, 1520
. : milestone, 1497,
section candidate
no_agent (1.358 ms) : 1337, 1378
. : milestone, 1358,
appsec (1.723 ms) : 1699, 1747
. : milestone, 1723,
appsec_no_iast (1.751 ms) : 1727, 1776
. : milestone, 1751,
code_origins (1.666 ms) : 1632, 1699
. : milestone, 1666,
iast (1.522 ms) : 1498, 1546
. : milestone, 1522,
profiling (1.527 ms) : 1504, 1550
. : milestone, 1527,
tracing (1.493 ms) : 1468, 1517
. : milestone, 1493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section baseline
no_agent (15.231 s) : 15231000, 15231000
. : milestone, 15231000,
appsec (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
iast (18.883 s) : 18883000, 18883000
. : milestone, 18883000,
iast_GLOBAL (17.785 s) : 17785000, 17785000
. : milestone, 17785000,
profiling (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
tracing (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
section candidate
no_agent (15.551 s) : 15551000, 15551000
. : milestone, 15551000,
appsec (14.944 s) : 14944000, 14944000
. : milestone, 14944000,
iast (18.242 s) : 18242000, 18242000
. : milestone, 18242000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
tracing (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~0723431572, baseline=1.47.0-SNAPSHOT~6502eeb8e2
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.349 ms) : 2305, 2393
. : milestone, 2349,
iast (2.124 ms) : 2069, 2180
. : milestone, 2124,
iast_GLOBAL (2.164 ms) : 2109, 2220
. : milestone, 2164,
profiling (1.961 ms) : 1918, 2005
. : milestone, 1961,
tracing (1.954 ms) : 1911, 1996
. : milestone, 1954,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.349 ms) : 2306, 2392
. : milestone, 2349,
iast (2.127 ms) : 2072, 2183
. : milestone, 2127,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (1.984 ms) : 1940, 2027
. : milestone, 1984,
tracing (1.947 ms) : 1905, 1989
. : milestone, 1947,
|
manuel-alvarez-alvarez
force-pushed
the
malvarez/waf-set-user-sdk
branch
from
b3dcd02 to
0723431
Compare
manuel-alvarez-alvarez
force-pushed
the
malvarez/waf-sdk-appsec-inactive
branch
from
d0b259b to
f420acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]