Bump grpc versions in tests to match the current logs-backend versions #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanchooly
added
comp: testing
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.135 s) : 0, 1134764
Total [baseline] (9.275 s) : 0, 9275115
Agent [candidate] (1.14 s) : 0, 1139868
Total [candidate] (9.272 s) : 0, 9272172
section iast
Agent [baseline] (1.258 s) : 0, 1257619
Total [baseline] (9.875 s) : 0, 9875181
Agent [candidate] (1.258 s) : 0, 1257925
Total [candidate] (9.863 s) : 0, 9863288
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.26 s) : 0, 1259736
Total [baseline] (9.824 s) : 0, 9824297
Agent [candidate] (1.26 s) : 0, 1260069
Total [candidate] (9.833 s) : 0, 9832574
section iast_TELEMETRY_OFF
Agent [baseline] (1.254 s) : 0, 1254377
Total [baseline] (9.882 s) : 0, 9882257
Agent [candidate] (1.265 s) : 0, 1264637
Total [candidate] (10.025 s) : 0, 10024992
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.748 ms) : 0, 716748
BytebuddyAgent [candidate] (719.261 ms) : 0, 719261
GlobalTracer [baseline] (238.905 ms) : 0, 238905
GlobalTracer [candidate] (240.845 ms) : 0, 240845
AppSec [baseline] (55.5 ms) : 0, 55500
AppSec [candidate] (55.69 ms) : 0, 55690
Debugger [baseline] (95.489 ms) : 0, 95489
Debugger [candidate] (95.945 ms) : 0, 95945
Remote Config [baseline] (587.418 µs) : 0, 587
Remote Config [candidate] (576.76 µs) : 0, 577
Telemetry [baseline] (12.56 ms) : 0, 12560
Telemetry [candidate] (12.517 ms) : 0, 12517
section iast
BytebuddyAgent [baseline] (836.116 ms) : 0, 836116
BytebuddyAgent [candidate] (837.081 ms) : 0, 837081
GlobalTracer [baseline] (229.88 ms) : 0, 229880
GlobalTracer [candidate] (230.38 ms) : 0, 230380
AppSec [baseline] (57.311 ms) : 0, 57311
AppSec [candidate] (56.062 ms) : 0, 56062
Debugger [baseline] (83.606 ms) : 0, 83606
Debugger [candidate] (83.396 ms) : 0, 83396
Remote Config [baseline] (541.76 µs) : 0, 542
Remote Config [candidate] (531.069 µs) : 0, 531
Telemetry [baseline] (12.288 ms) : 0, 12288
Telemetry [candidate] (12.156 ms) : 0, 12156
IAST [baseline] (22.799 ms) : 0, 22799
IAST [candidate] (23.293 ms) : 0, 23293
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.034 ms) : 0, 837034
BytebuddyAgent [candidate] (836.847 ms) : 0, 836847
GlobalTracer [baseline] (230.727 ms) : 0, 230727
GlobalTracer [candidate] (230.66 ms) : 0, 230660
AppSec [baseline] (57.654 ms) : 0, 57654
AppSec [candidate] (57.947 ms) : 0, 57947
Debugger [baseline] (83.788 ms) : 0, 83788
Debugger [candidate] (83.712 ms) : 0, 83712
Remote Config [baseline] (533.346 µs) : 0, 533
Remote Config [candidate] (526.964 µs) : 0, 527
Telemetry [baseline] (12.184 ms) : 0, 12184
Telemetry [candidate] (12.268 ms) : 0, 12268
IAST [baseline] (22.784 ms) : 0, 22784
IAST [candidate] (23.063 ms) : 0, 23063
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.071 ms) : 0, 834071
BytebuddyAgent [candidate] (840.887 ms) : 0, 840887
GlobalTracer [baseline] (230.337 ms) : 0, 230337
GlobalTracer [candidate] (231.614 ms) : 0, 231614
AppSec [baseline] (56.064 ms) : 0, 56064
AppSec [candidate] (56.162 ms) : 0, 56162
Debugger [baseline] (83.369 ms) : 0, 83369
Debugger [candidate] (83.931 ms) : 0, 83931
Remote Config [baseline] (524.43 µs) : 0, 524
Remote Config [candidate] (527.96 µs) : 0, 528
Telemetry [baseline] (12.118 ms) : 0, 12118
Telemetry [candidate] (12.249 ms) : 0, 12249
IAST [baseline] (22.903 ms) : 0, 22903
IAST [candidate] (24.1 ms) : 0, 24100
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.143 s) : 0, 1143014
Total [baseline] (11.491 s) : 0, 11490654
Agent [candidate] (1.135 s) : 0, 1134943
Total [candidate] (11.518 s) : 0, 11517791
section appsec
Agent [baseline] (1.274 s) : 0, 1273726
Total [baseline] (11.777 s) : 0, 11776680
Agent [candidate] (1.275 s) : 0, 1275262
Total [candidate] (11.753 s) : 0, 11753372
section iast
Agent [baseline] (1.259 s) : 0, 1259408
Total [baseline] (11.987 s) : 0, 11986681
Agent [candidate] (1.263 s) : 0, 1262690
Total [candidate] (11.962 s) : 0, 11961838
section profiling
Agent [baseline] (1.38 s) : 0, 1380104
Total [baseline] (11.837 s) : 0, 11837252
Agent [candidate] (1.379 s) : 0, 1379488
Total [candidate] (11.812 s) : 0, 11811504
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.221 ms) : 0, 721221
BytebuddyAgent [candidate] (716.216 ms) : 0, 716216
GlobalTracer [baseline] (241.585 ms) : 0, 241585
GlobalTracer [candidate] (239.382 ms) : 0, 239382
AppSec [baseline] (56.187 ms) : 0, 56187
AppSec [candidate] (55.367 ms) : 0, 55367
Debugger [baseline] (95.725 ms) : 0, 95725
Debugger [candidate] (95.994 ms) : 0, 95994
Remote Config [baseline] (601.916 µs) : 0, 602
Remote Config [candidate] (588.05 µs) : 0, 588
Telemetry [baseline] (12.598 ms) : 0, 12598
Telemetry [candidate] (12.339 ms) : 0, 12339
section appsec
BytebuddyAgent [baseline] (734.723 ms) : 0, 734723
BytebuddyAgent [candidate] (736.694 ms) : 0, 736694
GlobalTracer [baseline] (236.296 ms) : 0, 236296
GlobalTracer [candidate] (236.919 ms) : 0, 236919
AppSec [baseline] (178.773 ms) : 0, 178773
AppSec [candidate] (178.133 ms) : 0, 178133
Debugger [baseline] (84.97 ms) : 0, 84970
Debugger [candidate] (84.54 ms) : 0, 84540
Remote Config [baseline] (637.794 µs) : 0, 638
Remote Config [candidate] (632.348 µs) : 0, 632
Telemetry [baseline] (12.384 ms) : 0, 12384
Telemetry [candidate] (12.406 ms) : 0, 12406
IAST [baseline] (21.849 ms) : 0, 21849
IAST [candidate] (21.718 ms) : 0, 21718
section iast
BytebuddyAgent [baseline] (837.344 ms) : 0, 837344
BytebuddyAgent [candidate] (840.281 ms) : 0, 840281
GlobalTracer [baseline] (230.39 ms) : 0, 230390
GlobalTracer [candidate] (229.982 ms) : 0, 229982
AppSec [baseline] (57.335 ms) : 0, 57335
AppSec [candidate] (57.425 ms) : 0, 57425
Debugger [baseline] (83.485 ms) : 0, 83485
Debugger [candidate] (84.289 ms) : 0, 84289
Remote Config [baseline] (513.13 µs) : 0, 513
Remote Config [candidate] (519.359 µs) : 0, 519
Telemetry [baseline] (12.333 ms) : 0, 12333
Telemetry [candidate] (12.237 ms) : 0, 12237
IAST [baseline] (22.889 ms) : 0, 22889
IAST [candidate] (22.829 ms) : 0, 22829
section profiling
BytebuddyAgent [baseline] (708.583 ms) : 0, 708583
BytebuddyAgent [candidate] (708.549 ms) : 0, 708549
GlobalTracer [baseline] (350.731 ms) : 0, 350731
GlobalTracer [candidate] (351.055 ms) : 0, 351055
AppSec [baseline] (55.224 ms) : 0, 55224
AppSec [candidate] (54.511 ms) : 0, 54511
Debugger [baseline] (88.626 ms) : 0, 88626
Debugger [candidate] (88.576 ms) : 0, 88576
Remote Config [baseline] (608.768 µs) : 0, 609
Remote Config [candidate] (605.674 µs) : 0, 606
Telemetry [baseline] (12.55 ms) : 0, 12550
Telemetry [candidate] (12.489 ms) : 0, 12489
ProfilingAgent [baseline] (123.405 ms) : 0, 123405
ProfilingAgent [candidate] (123.221 ms) : 0, 123221
Profiling [baseline] (123.426 ms) : 0, 123426
Profiling [candidate] (123.242 ms) : 0, 123242
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section baseline
no_agent (378.811 µs) : 359, 398
. : milestone, 379,
iast (510.524 µs) : 488, 533
. : milestone, 511,
iast_FULL (731.521 µs) : 709, 754
. : milestone, 732,
iast_GLOBAL (557.237 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (508.721 µs) : 487, 531
. : milestone, 509,
iast_INACTIVE (458.695 µs) : 437, 480
. : milestone, 459,
iast_TELEMETRY_OFF (505.036 µs) : 481, 529
. : milestone, 505,
tracing (448.638 µs) : 428, 469
. : milestone, 449,
section candidate
no_agent (378.321 µs) : 358, 398
. : milestone, 378,
iast (517.375 µs) : 495, 539
. : milestone, 517,
iast_FULL (733.413 µs) : 711, 756
. : milestone, 733,
iast_GLOBAL (561.747 µs) : 540, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (506.891 µs) : 485, 529
. : milestone, 507,
iast_INACTIVE (461.514 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (497.305 µs) : 475, 520
. : milestone, 497,
tracing (458.13 µs) : 437, 479
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1382
. : milestone, 1362,
appsec (1.72 ms) : 1695, 1745
. : milestone, 1720,
appsec_no_iast (1.722 ms) : 1698, 1746
. : milestone, 1722,
code_origins (1.698 ms) : 1666, 1730
. : milestone, 1698,
iast (1.509 ms) : 1484, 1534
. : milestone, 1509,
profiling (1.514 ms) : 1490, 1539
. : milestone, 1514,
tracing (1.504 ms) : 1479, 1529
. : milestone, 1504,
section candidate
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.727 ms) : 1703, 1751
. : milestone, 1727,
appsec_no_iast (1.728 ms) : 1704, 1751
. : milestone, 1728,
code_origins (1.694 ms) : 1662, 1726
. : milestone, 1694,
iast (1.512 ms) : 1487, 1537
. : milestone, 1512,
profiling (1.55 ms) : 1524, 1576
. : milestone, 1550,
tracing (1.491 ms) : 1467, 1514
. : milestone, 1491,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.331 ms) : 2288, 2375
. : milestone, 2331,
iast (2.103 ms) : 2048, 2157
. : milestone, 2103,
iast_GLOBAL (2.147 ms) : 2091, 2202
. : milestone, 2147,
profiling (1.978 ms) : 1933, 2023
. : milestone, 1978,
tracing (1.925 ms) : 1883, 1966
. : milestone, 1925,
section candidate
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (2.327 ms) : 2284, 2370
. : milestone, 2327,
iast (2.1 ms) : 2045, 2155
. : milestone, 2100,
iast_GLOBAL (2.145 ms) : 2089, 2200
. : milestone, 2145,
profiling (2.43 ms) : 2255, 2605
. : milestone, 2430,
tracing (1.933 ms) : 1892, 1975
. : milestone, 1933,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~dd3dabdbd3, baseline=1.47.0-SNAPSHOT~c8886fbcec
dateFormat X
axisFormat %s
section baseline
no_agent (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
appsec (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
iast (18.98 s) : 18980000, 18980000
. : milestone, 18980000,
iast_GLOBAL (18.075 s) : 18075000, 18075000
. : milestone, 18075000,
profiling (14.882 s) : 14882000, 14882000
. : milestone, 14882000,
tracing (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
section candidate
no_agent (15.568 s) : 15568000, 15568000
. : milestone, 15568000,
appsec (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
iast (18.721 s) : 18721000, 18721000
. : milestone, 18721000,
iast_GLOBAL (17.888 s) : 17888000, 17888000
. : milestone, 17888000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
|
amarziali
reviewed
Mar 3, 2025
| @@ -14,12 +14,12 @@ apply from: "$rootDir/gradle/java.gradle" | |||
| apply plugin: 'idea' | |||
|
|
|||
| // First version with Mac M1 support | |||
| def grpcVersion = '1.42.2' | |||
| def grpcVersion = '1.62.2' | |||
There was a problem hiding this comment.
We claim to support 1.42.2 (at least 1.5) so if you raise that version we loose this guarantee.
In general, for instrumentation, we test the version we compile with and we test the latest.
If you want to add a specific test for 1.62 you can just leave the base version as it and add a test suite for this specific version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
The versions here lag behind what's currently in use in logs-backed by quite some bit. This suggested PR bumps these versions up to something closer to parity with logs-backend. We have resolved the issues this caused for us with code origins so the urgency is low but thought it might be a good time/reason to bump up versions. I don't know either the policies around version bumps nor any nuances this change might cause so if it's deemed to risky or simply undesirable, that's ok. I don't have a particular need for this upgrade beyond just trying to keep dependencies relatively up to date where possible.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]