Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing address for signup event #8469

Open
wants to merge 3 commits into
base: malvarez/waf-sdk-appsec-inactive
Choose a base branch
from
Open

Add missing address for signup event #8469

wants to merge 3 commits into from

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Feb 28, 2025 •
edited
Loading

What Does This Do

Adds the missing address server.business_logic.users.signup to the automated login events instrumentation.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: enhancement tag: no release notes Changes to exclude from release notes comp: asm waf Application Security Management (WAF) labels Feb 28, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-signup-address
git_commit_date 1740739493 1740743257
git_commit_sha 5328e2b 4bfddbf
release_version 1.47.0-SNAPSHOT~5328e2b1a1 1.47.0-SNAPSHOT~4bfddbf4c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740745603 1740745603
ci_job_id 827520436 827520436
ci_pipeline_id 57322059 57322059
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-giwhvhrh-project-304-concurrent-0-1cxgh1l3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-giwhvhrh-project-304-concurrent-0-1cxgh1l3 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045934
Total [baseline] (8.643 s) : 0, 8643420
Agent [candidate] (1.039 s) : 0, 1039002
Total [candidate] (8.66 s) : 0, 8660450
section iast
Agent [baseline] (1.169 s) : 0, 1168906
Total [baseline] (9.23 s) : 0, 9229739
Agent [candidate] (1.168 s) : 0, 1167636
Total [candidate] (9.243 s) : 0, 9243438
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1168645
Total [baseline] (9.253 s) : 0, 9252836
Agent [candidate] (1.169 s) : 0, 1169092
Total [candidate] (9.183 s) : 0, 9182515
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164590
Total [baseline] (9.239 s) : 0, 9238686
Agent [candidate] (1.163 s) : 0, 1163096
Total [candidate] (9.259 s) : 0, 9258674
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.169 s 122.972 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 122.711 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.165 s 118.655 ms (11.3%)
Total tracing 8.643 s -
Total iast 9.23 s 586.318 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.253 s 609.416 ms (7.1%)
Total iast_TELEMETRY_OFF 9.239 s 595.266 ms (6.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.168 s 128.634 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 130.09 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.163 s 124.094 ms (11.9%)
Total tracing 8.66 s -
Total iast 9.243 s 582.988 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.183 s 522.065 ms (6.0%)
Total iast_TELEMETRY_OFF 9.259 s 598.224 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.234 ms) : 0, 720234
BytebuddyAgent [candidate] (716.289 ms) : 0, 716289
GlobalTracer [baseline] (239.499 ms) : 0, 239499
GlobalTracer [candidate] (239.059 ms) : 0, 239059
AppSec [baseline] (56.056 ms) : 0, 56056
AppSec [candidate] (55.358 ms) : 0, 55358
Remote Config [baseline] (699.0 µs) : 0, 699
Remote Config [candidate] (755.939 µs) : 0, 756
Telemetry [baseline] (14.473 ms) : 0, 14473
Telemetry [candidate] (12.295 ms) : 0, 12295
section iast
BytebuddyAgent [baseline] (835.04 ms) : 0, 835040
BytebuddyAgent [candidate] (834.797 ms) : 0, 834797
GlobalTracer [baseline] (229.73 ms) : 0, 229730
GlobalTracer [candidate] (228.928 ms) : 0, 228928
IAST [baseline] (23.002 ms) : 0, 23002
IAST [candidate] (22.892 ms) : 0, 22892
AppSec [baseline] (56.82 ms) : 0, 56820
AppSec [candidate] (56.448 ms) : 0, 56448
Remote Config [baseline] (615.933 µs) : 0, 616
Remote Config [candidate] (606.92 µs) : 0, 607
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (8.677 ms) : 0, 8677
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.171 ms) : 0, 834171
BytebuddyAgent [candidate] (835.752 ms) : 0, 835752
GlobalTracer [baseline] (229.582 ms) : 0, 229582
GlobalTracer [candidate] (230.001 ms) : 0, 230001
IAST [baseline] (23.055 ms) : 0, 23055
IAST [candidate] (22.779 ms) : 0, 22779
AppSec [baseline] (57.411 ms) : 0, 57411
AppSec [candidate] (56.137 ms) : 0, 56137
Remote Config [baseline] (628.857 µs) : 0, 629
Remote Config [candidate] (605.153 µs) : 0, 605
Telemetry [baseline] (8.807 ms) : 0, 8807
Telemetry [candidate] (8.603 ms) : 0, 8603
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.444 ms) : 0, 832444
BytebuddyAgent [candidate] (830.394 ms) : 0, 830394
GlobalTracer [baseline] (229.668 ms) : 0, 229668
GlobalTracer [candidate] (229.637 ms) : 0, 229637
IAST [baseline] (25.914 ms) : 0, 25914
IAST [candidate] (28.677 ms) : 0, 28677
AppSec [baseline] (52.633 ms) : 0, 52633
AppSec [candidate] (50.021 ms) : 0, 50021
Remote Config [baseline] (602.772 µs) : 0, 603
Remote Config [candidate] (610.862 µs) : 0, 611
Telemetry [baseline] (8.414 ms) : 0, 8414
Telemetry [candidate] (8.565 ms) : 0, 8565
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045478
Total [baseline] (10.413 s) : 0, 10412681
Agent [candidate] (1.036 s) : 0, 1036031
Total [candidate] (10.425 s) : 0, 10425050
section appsec
Agent [baseline] (1.183 s) : 0, 1182675
Total [baseline] (10.726 s) : 0, 10726115
Agent [candidate] (1.181 s) : 0, 1181264
Total [candidate] (10.79 s) : 0, 10789812
section iast
Agent [baseline] (1.17 s) : 0, 1169517
Total [baseline] (10.939 s) : 0, 10938800
Agent [candidate] (1.179 s) : 0, 1178717
Total [candidate] (10.995 s) : 0, 10995213
section profiling
Agent [baseline] (1.26 s) : 0, 1259892
Total [baseline] (10.833 s) : 0, 10832857
Agent [candidate] (1.266 s) : 0, 1265706
Total [candidate] (10.893 s) : 0, 10892830
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent appsec 1.183 s 137.197 ms (13.1%)
Agent iast 1.17 s 124.039 ms (11.9%)
Agent profiling 1.26 s 214.414 ms (20.5%)
Total tracing 10.413 s -
Total appsec 10.726 s 313.434 ms (3.0%)
Total iast 10.939 s 526.119 ms (5.1%)
Total profiling 10.833 s 420.176 ms (4.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent appsec 1.181 s 145.233 ms (14.0%)
Agent iast 1.179 s 142.686 ms (13.8%)
Agent profiling 1.266 s 229.675 ms (22.2%)
Total tracing 10.425 s -
Total appsec 10.79 s 364.762 ms (3.5%)
Total iast 10.995 s 570.164 ms (5.5%)
Total profiling 10.893 s 467.78 ms (4.5%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.513 ms) : 0, 722513
BytebuddyAgent [candidate] (715.346 ms) : 0, 715346
GlobalTracer [baseline] (239.779 ms) : 0, 239779
GlobalTracer [candidate] (238.515 ms) : 0, 238515
AppSec [baseline] (55.812 ms) : 0, 55812
AppSec [candidate] (54.798 ms) : 0, 54798
Remote Config [baseline] (716.961 µs) : 0, 717
Remote Config [candidate] (693.019 µs) : 0, 693
Telemetry [baseline] (11.585 ms) : 0, 11585
Telemetry [candidate] (11.471 ms) : 0, 11471
section appsec
BytebuddyAgent [baseline] (734.61 ms) : 0, 734610
BytebuddyAgent [candidate] (733.453 ms) : 0, 733453
GlobalTracer [baseline] (235.841 ms) : 0, 235841
GlobalTracer [candidate] (235.787 ms) : 0, 235787
AppSec [baseline] (177.631 ms) : 0, 177631
AppSec [candidate] (177.156 ms) : 0, 177156
Remote Config [baseline] (663.225 µs) : 0, 663
Remote Config [candidate] (661.897 µs) : 0, 662
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (8.305 ms) : 0, 8305
IAST [baseline] (21.568 ms) : 0, 21568
IAST [candidate] (21.389 ms) : 0, 21389
section iast
BytebuddyAgent [baseline] (835.33 ms) : 0, 835330
BytebuddyAgent [candidate] (843.052 ms) : 0, 843052
GlobalTracer [baseline] (229.822 ms) : 0, 229822
GlobalTracer [candidate] (230.836 ms) : 0, 230836
AppSec [baseline] (57.215 ms) : 0, 57215
AppSec [candidate] (57.005 ms) : 0, 57005
Remote Config [baseline] (614.942 µs) : 0, 615
Remote Config [candidate] (614.668 µs) : 0, 615
Telemetry [baseline] (8.711 ms) : 0, 8711
Telemetry [candidate] (8.843 ms) : 0, 8843
IAST [baseline] (22.922 ms) : 0, 22922
IAST [candidate] (22.973 ms) : 0, 22973
section profiling
BytebuddyAgent [baseline] (708.51 ms) : 0, 708510
BytebuddyAgent [candidate] (711.698 ms) : 0, 711698
GlobalTracer [baseline] (349.381 ms) : 0, 349381
GlobalTracer [candidate] (351.253 ms) : 0, 351253
AppSec [baseline] (55.497 ms) : 0, 55497
AppSec [candidate] (54.465 ms) : 0, 54465
Remote Config [baseline] (666.283 µs) : 0, 666
Remote Config [candidate] (679.439 µs) : 0, 679
Telemetry [baseline] (8.987 ms) : 0, 8987
Telemetry [candidate] (9.069 ms) : 0, 9069
ProfilingAgent [baseline] (96.554 ms) : 0, 96554
ProfilingAgent [candidate] (97.952 ms) : 0, 97952
Profiling [baseline] (96.579 ms) : 0, 96579
Profiling [candidate] (97.977 ms) : 0, 97977
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-28T11:59:01 2025-02-28T12:06:44
git_branch master malvarez/waf-signup-address
git_commit_date 1740739493 1740743257
git_commit_sha 5328e2b 4bfddbf
release_version 1.47.0-SNAPSHOT~5328e2b1a1 1.47.0-SNAPSHOT~4bfddbf4c6
start_time 2025-02-28T11:58:47 2025-02-28T12:06:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740744799 1740744799
ci_job_id 827520437 827520437
ci_pipeline_id 57322059 57322059
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-xzxde7hb-project-304-concurrent-0-47v9ziw1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-xzxde7hb-project-304-concurrent-0-47v9ziw1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.106 µs) : 360, 400
.   : milestone, 380,
iast (503.786 µs) : 482, 526
.   : milestone, 504,
iast_FULL (727.763 µs) : 706, 750
.   : milestone, 728,
iast_GLOBAL (557.408 µs) : 536, 579
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (500.235 µs) : 479, 522
.   : milestone, 500,
iast_INACTIVE (459.122 µs) : 437, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (491.098 µs) : 468, 514
.   : milestone, 491,
tracing (453.543 µs) : 432, 475
.   : milestone, 454,
section candidate
no_agent (379.916 µs) : 360, 400
.   : milestone, 380,
iast (503.89 µs) : 481, 526
.   : milestone, 504,
iast_FULL (724.165 µs) : 702, 746
.   : milestone, 724,
iast_GLOBAL (545.295 µs) : 524, 567
.   : milestone, 545,
iast_HARDCODED_SECRET_DISABLED (503.319 µs) : 482, 525
.   : milestone, 503,
iast_INACTIVE (460.997 µs) : 440, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (498.424 µs) : 475, 522
.   : milestone, 498,
tracing (459.135 µs) : 438, 480
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.106 µs [360.375 µs, 399.837 µs] -
iast 503.786 µs [481.813 µs, 525.758 µs] 123.68 µs (32.5%)
iast_FULL 727.763 µs [705.782 µs, 749.744 µs] 347.657 µs (91.5%)
iast_GLOBAL 557.408 µs [535.658 µs, 579.157 µs] 177.302 µs (46.6%)
iast_HARDCODED_SECRET_DISABLED 500.235 µs [478.599 µs, 521.872 µs] 120.129 µs (31.6%)
iast_INACTIVE 459.122 µs [436.887 µs, 481.357 µs] 79.016 µs (20.8%)
iast_TELEMETRY_OFF 491.098 µs [467.985 µs, 514.211 µs] 110.992 µs (29.2%)
tracing 453.543 µs [432.185 µs, 474.9 µs] 73.437 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.916 µs [360.032 µs, 399.8 µs] -
iast 503.89 µs [481.361 µs, 526.418 µs] 123.973 µs (32.6%)
iast_FULL 724.165 µs [702.321 µs, 746.009 µs] 344.248 µs (90.6%)
iast_GLOBAL 545.295 µs [523.552 µs, 567.038 µs] 165.379 µs (43.5%)
iast_HARDCODED_SECRET_DISABLED 503.319 µs [481.647 µs, 524.992 µs] 123.403 µs (32.5%)
iast_INACTIVE 460.997 µs [439.707 µs, 482.286 µs] 81.081 µs (21.3%)
iast_TELEMETRY_OFF 498.424 µs [475.323 µs, 521.526 µs] 118.508 µs (31.2%)
tracing 459.135 µs [438.392 µs, 479.878 µs] 79.219 µs (20.9%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
.   : milestone, 1354,
appsec (1.716 ms) : 1692, 1741
.   : milestone, 1716,
appsec_no_iast (1.727 ms) : 1702, 1751
.   : milestone, 1727,
code_origins (1.685 ms) : 1653, 1718
.   : milestone, 1685,
iast (1.499 ms) : 1475, 1523
.   : milestone, 1499,
profiling (1.531 ms) : 1506, 1556
.   : milestone, 1531,
tracing (1.474 ms) : 1449, 1499
.   : milestone, 1474,
section candidate
no_agent (1.36 ms) : 1340, 1381
.   : milestone, 1360,
appsec (1.724 ms) : 1700, 1749
.   : milestone, 1724,
appsec_no_iast (1.72 ms) : 1695, 1745
.   : milestone, 1720,
code_origins (1.68 ms) : 1647, 1714
.   : milestone, 1680,
iast (1.501 ms) : 1477, 1525
.   : milestone, 1501,
profiling (1.484 ms) : 1460, 1508
.   : milestone, 1484,
tracing (1.478 ms) : 1453, 1504
.   : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.374 ms] -
appsec 1.716 ms [1.692 ms, 1.741 ms] 362.049 µs (26.7%)
appsec_no_iast 1.727 ms [1.702 ms, 1.751 ms] 372.271 µs (27.5%)
code_origins 1.685 ms [1.653 ms, 1.718 ms] 330.992 µs (24.4%)
iast 1.499 ms [1.475 ms, 1.523 ms] 144.963 µs (10.7%)
profiling 1.531 ms [1.506 ms, 1.556 ms] 177.088 µs (13.1%)
tracing 1.474 ms [1.449 ms, 1.499 ms] 119.676 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.381 ms] -
appsec 1.724 ms [1.7 ms, 1.749 ms] 363.853 µs (26.7%)
appsec_no_iast 1.72 ms [1.695 ms, 1.745 ms] 359.452 µs (26.4%)
code_origins 1.68 ms [1.647 ms, 1.714 ms] 320.0 µs (23.5%)
iast 1.501 ms [1.477 ms, 1.525 ms] 140.558 µs (10.3%)
profiling 1.484 ms [1.46 ms, 1.508 ms] 123.517 µs (9.1%)
tracing 1.478 ms [1.453 ms, 1.504 ms] 118.058 µs (8.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-signup-address
git_commit_date 1740739493 1740743257
git_commit_sha 5328e2b 4bfddbf
release_version 1.47.0-SNAPSHOT~5328e2b1a1 1.47.0-SNAPSHOT~4bfddbf4c6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1740745447 1740745447
ci_job_id 827520438 827520438
ci_pipeline_id 57322059 57322059
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-7pfyxjxb-project-304-concurrent-0-xghk4khy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-7pfyxjxb-project-304-concurrent-0-xghk4khy 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.331 ms) : 2287, 2374
.   : milestone, 2331,
iast (2.113 ms) : 2057, 2169
.   : milestone, 2113,
iast_GLOBAL (2.151 ms) : 2095, 2207
.   : milestone, 2151,
profiling (1.957 ms) : 1914, 2001
.   : milestone, 1957,
tracing (1.946 ms) : 1903, 1988
.   : milestone, 1946,
section candidate
no_agent (1.468 ms) : 1457, 1479
.   : milestone, 1468,
appsec (2.317 ms) : 2274, 2360
.   : milestone, 2317,
iast (2.101 ms) : 2046, 2157
.   : milestone, 2101,
iast_GLOBAL (2.141 ms) : 2086, 2197
.   : milestone, 2141,
profiling (1.949 ms) : 1906, 1992
.   : milestone, 1949,
tracing (1.943 ms) : 1900, 1985
.   : milestone, 1943,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.46 ms, 1.483 ms] -
appsec 2.331 ms [2.287 ms, 2.374 ms] 859.509 µs (58.4%)
iast 2.113 ms [2.057 ms, 2.169 ms] 641.752 µs (43.6%)
iast_GLOBAL 2.151 ms [2.095 ms, 2.207 ms] 679.644 µs (46.2%)
profiling 1.957 ms [1.914 ms, 2.001 ms] 486.11 µs (33.0%)
tracing 1.946 ms [1.903 ms, 1.988 ms] 474.605 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.479 ms] -
appsec 2.317 ms [2.274 ms, 2.36 ms] 848.797 µs (57.8%)
iast 2.101 ms [2.046 ms, 2.157 ms] 633.497 µs (43.2%)
iast_GLOBAL 2.141 ms [2.086 ms, 2.197 ms] 673.377 µs (45.9%)
profiling 1.949 ms [1.906 ms, 1.992 ms] 481.019 µs (32.8%)
tracing 1.943 ms [1.9 ms, 1.985 ms] 474.793 µs (32.3%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~4bfddbf4c6, baseline=1.47.0-SNAPSHOT~5328e2b1a1
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.248 s) : 15248000, 15248000
.   : milestone, 15248000,
appsec (15.005 s) : 15005000, 15005000
.   : milestone, 15005000,
iast (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
iast_GLOBAL (18.067 s) : 18067000, 18067000
.   : milestone, 18067000,
profiling (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
tracing (15.03 s) : 15030000, 15030000
.   : milestone, 15030000,
section candidate
no_agent (15.341 s) : 15341000, 15341000
.   : milestone, 15341000,
appsec (14.754 s) : 14754000, 14754000
.   : milestone, 14754000,
iast (19.009 s) : 19009000, 19009000
.   : milestone, 19009000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
.   : milestone, 17974000,
profiling (15.119 s) : 15119000, 15119000
.   : milestone, 15119000,
tracing (15.236 s) : 15236000, 15236000
.   : milestone, 15236000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.248 s [15.248 s, 15.248 s] -
appsec 15.005 s [15.005 s, 15.005 s] -243.0 ms (-1.6%)
iast 18.029 s [18.029 s, 18.029 s] 2.781 s (18.2%)
iast_GLOBAL 18.067 s [18.067 s, 18.067 s] 2.819 s (18.5%)
profiling 14.958 s [14.958 s, 14.958 s] -290.0 ms (-1.9%)
tracing 15.03 s [15.03 s, 15.03 s] -218.0 ms (-1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.341 s [15.341 s, 15.341 s] -
appsec 14.754 s [14.754 s, 14.754 s] -587.0 ms (-3.8%)
iast 19.009 s [19.009 s, 19.009 s] 3.668 s (23.9%)
iast_GLOBAL 17.974 s [17.974 s, 17.974 s] 2.633 s (17.2%)
profiling 15.119 s [15.119 s, 15.119 s] -222.0 ms (-1.4%)
tracing 15.236 s [15.236 s, 15.236 s] -105.0 ms (-0.7%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from c4329c6 to d0b259b Compare February 28, 2025 11:07
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review February 28, 2025 11:48
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner February 28, 2025 11:48
@smola smola removed the tag: no release notes Changes to exclude from release notes label Mar 3, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from d0b259b to f420acc Compare March 7, 2025 13:07
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner March 7, 2025 13:07
PerfectSlayer
PerfectSlayer approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good for platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@sezen-datadog sezen-datadog sezen-datadog approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuel-alvarez-alvarez @smola @PerfectSlayer @sezen-datadog