Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow login events SDK to be used with appsec disabled #8464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow login events SDK to be used with appsec disabled #8464

wants to merge 2 commits into from

Conversation

manuel-alvarez-alvarez
Copy link
Member

What Does This Do

Relocates the logic for handling span tags related to the login event SDK from the com.datadog.appsec.gateway.GatewayBridge class to datadog.trace.api.appsecAppSecEventTracker. This modification ensures the functionality remains accessible even if AppSec is explicitly disabled.

Motivation

Customers using the SDK should still be able to set the appropriate span tags even when AppSec is disabled.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@manuel-alvarez-alvarez manuel-alvarez-alvarez added tag: no release notes Changes to exclude from release notes type: refactoring comp: asm waf Application Security Management (WAF) labels Feb 27, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from 081dea3 to dc094dd Compare February 27, 2025 16:34
@pr-commenter
Copy link

pr-commenter bot commented Feb 27, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741344572 1741352756
git_commit_sha b34cd6d f420acc
release_version 1.48.0-SNAPSHOT~b34cd6dbd9 1.48.0-SNAPSHOT~f420acc067
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741355082 1741355082
ci_job_id 837737563 837737563
ci_pipeline_id 58078897 58078897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-j57kgy2v-project-304-concurrent-4-axp694x6 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-j57kgy2v-project-304-concurrent-4-axp694x6 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039494
Total [baseline] (10.534 s) : 0, 10533568
Agent [candidate] (1.041 s) : 0, 1041033
Total [candidate] (10.555 s) : 0, 10555192
section appsec
Agent [baseline] (1.184 s) : 0, 1184137
Total [baseline] (10.791 s) : 0, 10791266
Agent [candidate] (1.181 s) : 0, 1181160
Total [candidate] (10.732 s) : 0, 10732244
section iast
Agent [baseline] (1.169 s) : 0, 1168660
Total [baseline] (11.028 s) : 0, 11028485
Agent [candidate] (1.168 s) : 0, 1168357
Total [candidate] (11.012 s) : 0, 11011544
section profiling
Agent [baseline] (1.273 s) : 0, 1272600
Total [baseline] (10.907 s) : 0, 10907035
Agent [candidate] (1.263 s) : 0, 1263219
Total [candidate] (10.934 s) : 0, 10933910
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent appsec 1.184 s 144.642 ms (13.9%)
Agent iast 1.169 s 129.165 ms (12.4%)
Agent profiling 1.273 s 233.106 ms (22.4%)
Total tracing 10.534 s -
Total appsec 10.791 s 257.697 ms (2.4%)
Total iast 11.028 s 494.916 ms (4.7%)
Total profiling 10.907 s 373.467 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.181 s 140.128 ms (13.5%)
Agent iast 1.168 s 127.325 ms (12.2%)
Agent profiling 1.263 s 222.186 ms (21.3%)
Total tracing 10.555 s -
Total appsec 10.732 s 177.052 ms (1.7%)
Total iast 11.012 s 456.352 ms (4.3%)
Total profiling 10.934 s 378.717 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.337 ms) : 0, 716337
BytebuddyAgent [candidate] (717.993 ms) : 0, 717993
GlobalTracer [baseline] (239.094 ms) : 0, 239094
GlobalTracer [candidate] (239.982 ms) : 0, 239982
AppSec [baseline] (54.873 ms) : 0, 54873
AppSec [candidate] (54.829 ms) : 0, 54829
Remote Config [baseline] (676.865 µs) : 0, 677
Remote Config [candidate] (699.276 µs) : 0, 699
Telemetry [baseline] (13.606 ms) : 0, 13606
Telemetry [candidate] (12.168 ms) : 0, 12168
section appsec
BytebuddyAgent [baseline] (735.85 ms) : 0, 735850
BytebuddyAgent [candidate] (733.579 ms) : 0, 733579
GlobalTracer [baseline] (236.517 ms) : 0, 236517
GlobalTracer [candidate] (236.206 ms) : 0, 236206
AppSec [baseline] (177.139 ms) : 0, 177139
AppSec [candidate] (176.515 ms) : 0, 176515
Remote Config [baseline] (656.874 µs) : 0, 657
Remote Config [candidate] (654.37 µs) : 0, 654
Telemetry [baseline] (8.283 ms) : 0, 8283
Telemetry [candidate] (8.228 ms) : 0, 8228
IAST [baseline] (21.334 ms) : 0, 21334
IAST [candidate] (21.519 ms) : 0, 21519
section iast
BytebuddyAgent [baseline] (834.957 ms) : 0, 834957
BytebuddyAgent [candidate] (834.636 ms) : 0, 834636
GlobalTracer [baseline] (230.083 ms) : 0, 230083
GlobalTracer [candidate] (229.978 ms) : 0, 229978
AppSec [baseline] (56.678 ms) : 0, 56678
AppSec [candidate] (56.187 ms) : 0, 56187
Remote Config [baseline] (617.564 µs) : 0, 618
Remote Config [candidate] (614.888 µs) : 0, 615
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.778 ms) : 0, 8778
IAST [baseline] (22.648 ms) : 0, 22648
IAST [candidate] (22.91 ms) : 0, 22910
section profiling
BytebuddyAgent [baseline] (715.322 ms) : 0, 715322
BytebuddyAgent [candidate] (711.344 ms) : 0, 711344
GlobalTracer [baseline] (353.321 ms) : 0, 353321
GlobalTracer [candidate] (350.786 ms) : 0, 350786
AppSec [baseline] (55.76 ms) : 0, 55760
AppSec [candidate] (53.828 ms) : 0, 53828
Remote Config [baseline] (687.767 µs) : 0, 688
Remote Config [candidate] (656.271 µs) : 0, 656
Telemetry [baseline] (9.066 ms) : 0, 9066
Telemetry [candidate] (9.018 ms) : 0, 9018
ProfilingAgent [baseline] (97.72 ms) : 0, 97720
ProfilingAgent [candidate] (96.613 ms) : 0, 96613
Profiling [baseline] (97.744 ms) : 0, 97744
Profiling [candidate] (96.638 ms) : 0, 96638
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043769
Total [baseline] (8.669 s) : 0, 8669493
Agent [candidate] (1.044 s) : 0, 1043965
Total [candidate] (8.69 s) : 0, 8689772
section iast
Agent [baseline] (1.17 s) : 0, 1170156
Total [baseline] (9.255 s) : 0, 9254820
Agent [candidate] (1.17 s) : 0, 1170403
Total [candidate] (9.263 s) : 0, 9262682
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1167835
Total [baseline] (9.208 s) : 0, 9208226
Agent [candidate] (1.182 s) : 0, 1181793
Total [candidate] (9.233 s) : 0, 9232948
section iast_TELEMETRY_OFF
Agent [baseline] (1.178 s) : 0, 1177585
Total [baseline] (9.248 s) : 0, 9247831
Agent [candidate] (1.173 s) : 0, 1172974
Total [candidate] (9.322 s) : 0, 9321876
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.17 s 126.386 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.168 s 124.065 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.178 s 133.815 ms (12.8%)
Total tracing 8.669 s -
Total iast 9.255 s 585.327 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.208 s 538.734 ms (6.2%)
Total iast_TELEMETRY_OFF 9.248 s 578.338 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.17 s 126.439 ms (12.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.182 s 137.829 ms (13.2%)
Agent iast_TELEMETRY_OFF 1.173 s 129.01 ms (12.4%)
Total tracing 8.69 s -
Total iast 9.263 s 572.911 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.233 s 543.176 ms (6.3%)
Total iast_TELEMETRY_OFF 9.322 s 632.104 ms (7.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.606 ms) : 0, 719606
BytebuddyAgent [candidate] (721.139 ms) : 0, 721139
GlobalTracer [baseline] (239.426 ms) : 0, 239426
GlobalTracer [candidate] (240.763 ms) : 0, 240763
AppSec [baseline] (55.242 ms) : 0, 55242
AppSec [candidate] (54.715 ms) : 0, 54715
Remote Config [baseline] (697.485 µs) : 0, 697
Remote Config [candidate] (697.26 µs) : 0, 697
Telemetry [baseline] (13.711 ms) : 0, 13711
Telemetry [candidate] (11.218 ms) : 0, 11218
section iast
BytebuddyAgent [baseline] (836.431 ms) : 0, 836431
BytebuddyAgent [candidate] (836.711 ms) : 0, 836711
GlobalTracer [baseline] (230.295 ms) : 0, 230295
GlobalTracer [candidate] (230.121 ms) : 0, 230121
AppSec [baseline] (56.47 ms) : 0, 56470
AppSec [candidate] (56.142 ms) : 0, 56142
Remote Config [baseline] (612.642 µs) : 0, 613
Remote Config [candidate] (611.254 µs) : 0, 611
Telemetry [baseline] (8.652 ms) : 0, 8652
Telemetry [candidate] (8.656 ms) : 0, 8656
IAST [baseline] (22.725 ms) : 0, 22725
IAST [candidate] (22.843 ms) : 0, 22843
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.406 ms) : 0, 834406
BytebuddyAgent [candidate] (846.119 ms) : 0, 846119
GlobalTracer [baseline] (229.768 ms) : 0, 229768
GlobalTracer [candidate] (230.964 ms) : 0, 230964
AppSec [baseline] (55.819 ms) : 0, 55819
AppSec [candidate] (56.596 ms) : 0, 56596
Remote Config [baseline] (615.224 µs) : 0, 615
Remote Config [candidate] (615.187 µs) : 0, 615
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.783 ms) : 0, 8783
IAST [baseline] (23.547 ms) : 0, 23547
IAST [candidate] (23.057 ms) : 0, 23057
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.05 ms) : 0, 841050
BytebuddyAgent [candidate] (838.006 ms) : 0, 838006
GlobalTracer [baseline] (232.067 ms) : 0, 232067
GlobalTracer [candidate] (231.527 ms) : 0, 231527
AppSec [baseline] (56.61 ms) : 0, 56610
AppSec [candidate] (56.337 ms) : 0, 56337
Remote Config [baseline] (617.01 µs) : 0, 617
Remote Config [candidate] (610.449 µs) : 0, 610
Telemetry [baseline] (8.672 ms) : 0, 8672
Telemetry [candidate] (8.611 ms) : 0, 8611
IAST [baseline] (23.464 ms) : 0, 23464
IAST [candidate] (22.533 ms) : 0, 22533
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-07T13:14:53 2025-03-07T13:22:39
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741344572 1741352756
git_commit_sha b34cd6d f420acc
release_version 1.48.0-SNAPSHOT~b34cd6dbd9 1.48.0-SNAPSHOT~f420acc067
start_time 2025-03-07T13:14:39 2025-03-07T13:22:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1741354158 1741354158
ci_job_id 837737564 837737564
ci_pipeline_id 58078897 58078897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-s3yupehv-project-304-concurrent-1-tmj9v72o 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-s3yupehv-project-304-concurrent-1-tmj9v72o 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.383 ms) : 1363, 1404
.   : milestone, 1383,
appsec (1.725 ms) : 1701, 1749
.   : milestone, 1725,
appsec_no_iast (1.751 ms) : 1726, 1776
.   : milestone, 1751,
code_origins (1.697 ms) : 1664, 1730
.   : milestone, 1697,
iast (1.504 ms) : 1480, 1529
.   : milestone, 1504,
profiling (1.573 ms) : 1548, 1598
.   : milestone, 1573,
tracing (1.485 ms) : 1461, 1510
.   : milestone, 1485,
section candidate
no_agent (1.371 ms) : 1351, 1390
.   : milestone, 1371,
appsec (1.749 ms) : 1725, 1773
.   : milestone, 1749,
appsec_no_iast (1.722 ms) : 1697, 1746
.   : milestone, 1722,
code_origins (1.68 ms) : 1645, 1714
.   : milestone, 1680,
iast (1.498 ms) : 1474, 1523
.   : milestone, 1498,
profiling (1.558 ms) : 1532, 1583
.   : milestone, 1558,
tracing (1.498 ms) : 1473, 1523
.   : milestone, 1498,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.383 ms [1.363 ms, 1.404 ms] -
appsec 1.725 ms [1.701 ms, 1.749 ms] 341.645 µs (24.7%)
appsec_no_iast 1.751 ms [1.726 ms, 1.776 ms] 367.342 µs (26.6%)
code_origins 1.697 ms [1.664 ms, 1.73 ms] 313.102 µs (22.6%)
iast 1.504 ms [1.48 ms, 1.529 ms] 120.839 µs (8.7%)
profiling 1.573 ms [1.548 ms, 1.598 ms] 189.13 µs (13.7%)
tracing 1.485 ms [1.461 ms, 1.51 ms] 102.021 µs (7.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.371 ms [1.351 ms, 1.39 ms] -
appsec 1.749 ms [1.725 ms, 1.773 ms] 378.675 µs (27.6%)
appsec_no_iast 1.722 ms [1.697 ms, 1.746 ms] 351.052 µs (25.6%)
code_origins 1.68 ms [1.645 ms, 1.714 ms] 309.078 µs (22.6%)
iast 1.498 ms [1.474 ms, 1.523 ms] 127.858 µs (9.3%)
profiling 1.558 ms [1.532 ms, 1.583 ms] 186.966 µs (13.6%)
tracing 1.498 ms [1.473 ms, 1.523 ms] 127.274 µs (9.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.846 µs) : 360, 400
.   : milestone, 380,
iast (507.782 µs) : 486, 529
.   : milestone, 508,
iast_FULL (729.458 µs) : 708, 751
.   : milestone, 729,
iast_GLOBAL (558.286 µs) : 536, 580
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (510.561 µs) : 489, 532
.   : milestone, 511,
iast_INACTIVE (461.956 µs) : 440, 484
.   : milestone, 462,
iast_TELEMETRY_OFF (498.261 µs) : 475, 521
.   : milestone, 498,
tracing (453.215 µs) : 433, 474
.   : milestone, 453,
section candidate
no_agent (374.457 µs) : 355, 394
.   : milestone, 374,
iast (508.757 µs) : 486, 532
.   : milestone, 509,
iast_FULL (729.1 µs) : 707, 751
.   : milestone, 729,
iast_GLOBAL (551.257 µs) : 530, 573
.   : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (512.605 µs) : 490, 535
.   : milestone, 513,
iast_INACTIVE (467.334 µs) : 445, 489
.   : milestone, 467,
iast_TELEMETRY_OFF (492.645 µs) : 471, 514
.   : milestone, 493,
tracing (453.854 µs) : 433, 474
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 379.846 µs [360.026 µs, 399.666 µs] -
iast 507.782 µs [486.237 µs, 529.327 µs] 127.936 µs (33.7%)
iast_FULL 729.458 µs [707.566 µs, 751.349 µs] 349.612 µs (92.0%)
iast_GLOBAL 558.286 µs [536.149 µs, 580.424 µs] 178.44 µs (47.0%)
iast_HARDCODED_SECRET_DISABLED 510.561 µs [489.084 µs, 532.037 µs] 130.715 µs (34.4%)
iast_INACTIVE 461.956 µs [440.197 µs, 483.716 µs] 82.11 µs (21.6%)
iast_TELEMETRY_OFF 498.261 µs [475.422 µs, 521.101 µs] 118.415 µs (31.2%)
tracing 453.215 µs [432.531 µs, 473.9 µs] 73.369 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 374.457 µs [354.889 µs, 394.025 µs] -
iast 508.757 µs [485.845 µs, 531.669 µs] 134.3 µs (35.9%)
iast_FULL 729.1 µs [707.145 µs, 751.056 µs] 354.643 µs (94.7%)
iast_GLOBAL 551.257 µs [529.708 µs, 572.806 µs] 176.8 µs (47.2%)
iast_HARDCODED_SECRET_DISABLED 512.605 µs [490.416 µs, 534.795 µs] 138.148 µs (36.9%)
iast_INACTIVE 467.334 µs [445.264 µs, 489.405 µs] 92.878 µs (24.8%)
iast_TELEMETRY_OFF 492.645 µs [471.303 µs, 513.986 µs] 118.188 µs (31.6%)
tracing 453.854 µs [433.305 µs, 474.403 µs] 79.397 µs (21.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master malvarez/waf-sdk-appsec-inactive
git_commit_date 1741344572 1741352756
git_commit_sha b34cd6d f420acc
release_version 1.48.0-SNAPSHOT~b34cd6dbd9 1.48.0-SNAPSHOT~f420acc067
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1741354652 1741354652
ci_job_id 837737565 837737565
ci_pipeline_id 58078897 58078897
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pctlsheo-project-304-concurrent-0-0w5ch08n 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pctlsheo-project-304-concurrent-0-0w5ch08n 6.8.0-1023-aws #25~22.04.1-Ubuntu SMP Tue Jan 28 12:51:22 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.267 s) : 15267000, 15267000
.   : milestone, 15267000,
appsec (14.944 s) : 14944000, 14944000
.   : milestone, 14944000,
iast (18.633 s) : 18633000, 18633000
.   : milestone, 18633000,
iast_GLOBAL (18.096 s) : 18096000, 18096000
.   : milestone, 18096000,
profiling (15.043 s) : 15043000, 15043000
.   : milestone, 15043000,
tracing (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
section candidate
no_agent (15.192 s) : 15192000, 15192000
.   : milestone, 15192000,
appsec (14.903 s) : 14903000, 14903000
.   : milestone, 14903000,
iast (18.502 s) : 18502000, 18502000
.   : milestone, 18502000,
iast_GLOBAL (18.152 s) : 18152000, 18152000
.   : milestone, 18152000,
profiling (15.226 s) : 15226000, 15226000
.   : milestone, 15226000,
tracing (14.867 s) : 14867000, 14867000
.   : milestone, 14867000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.267 s [15.267 s, 15.267 s] -
appsec 14.944 s [14.944 s, 14.944 s] -323.0 ms (-2.1%)
iast 18.633 s [18.633 s, 18.633 s] 3.366 s (22.0%)
iast_GLOBAL 18.096 s [18.096 s, 18.096 s] 2.829 s (18.5%)
profiling 15.043 s [15.043 s, 15.043 s] -224.0 ms (-1.5%)
tracing 15.014 s [15.014 s, 15.014 s] -253.0 ms (-1.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.192 s [15.192 s, 15.192 s] -
appsec 14.903 s [14.903 s, 14.903 s] -289.0 ms (-1.9%)
iast 18.502 s [18.502 s, 18.502 s] 3.31 s (21.8%)
iast_GLOBAL 18.152 s [18.152 s, 18.152 s] 2.96 s (19.5%)
profiling 15.226 s [15.226 s, 15.226 s] 34.0 ms (0.2%)
tracing 14.867 s [14.867 s, 14.867 s] -325.0 ms (-2.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~f420acc067, baseline=1.48.0-SNAPSHOT~b34cd6dbd9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
.   : milestone, 1469,
appsec (2.326 ms) : 2283, 2369
.   : milestone, 2326,
iast (2.107 ms) : 2052, 2162
.   : milestone, 2107,
iast_GLOBAL (2.148 ms) : 2093, 2203
.   : milestone, 2148,
profiling (1.945 ms) : 1902, 1988
.   : milestone, 1945,
tracing (1.941 ms) : 1898, 1983
.   : milestone, 1941,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (2.328 ms) : 2284, 2371
.   : milestone, 2328,
iast (2.11 ms) : 2055, 2165
.   : milestone, 2110,
iast_GLOBAL (2.145 ms) : 2089, 2200
.   : milestone, 2145,
profiling (1.981 ms) : 1936, 2025
.   : milestone, 1981,
tracing (1.945 ms) : 1903, 1988
.   : milestone, 1945,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.326 ms [2.283 ms, 2.369 ms] 856.812 µs (58.3%)
iast 2.107 ms [2.052 ms, 2.162 ms] 637.9 µs (43.4%)
iast_GLOBAL 2.148 ms [2.093 ms, 2.203 ms] 678.903 µs (46.2%)
profiling 1.945 ms [1.902 ms, 1.988 ms] 475.757 µs (32.4%)
tracing 1.941 ms [1.898 ms, 1.983 ms] 471.755 µs (32.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 2.328 ms [2.284 ms, 2.371 ms] 852.767 µs (57.8%)
iast 2.11 ms [2.055 ms, 2.165 ms] 635.183 µs (43.1%)
iast_GLOBAL 2.145 ms [2.089 ms, 2.2 ms] 669.932 µs (45.4%)
profiling 1.981 ms [1.936 ms, 2.025 ms] 505.892 µs (34.3%)
tracing 1.945 ms [1.903 ms, 1.988 ms] 470.494 µs (31.9%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from dc094dd to c4329c6 Compare February 27, 2025 17:20
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review February 28, 2025 09:14
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Allow login event SDK to be used with appsec disabled Allow login events SDK to be used with appsec disabled Feb 28, 2025
jandro996
jandro996 reviewed Feb 28, 2025
View reviewed changes
internal-api/src/main/java/datadog/trace/api/appsec/AppSecEventTracker.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many tag names used in setTagTop method that extracted to constants to increase readability. What do you think?

jandro996
jandro996 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@jandro996 jandro996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! check my comment related with create constants for the tag names

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from c4329c6 to d0b259b Compare February 28, 2025 11:07
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/waf-sdk-appsec-inactive branch from d0b259b to f420acc Compare March 7, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandro996 jandro996 jandro996 approved these changes

@sezen-datadog sezen-datadog sezen-datadog approved these changes

@robertpi robertpi Awaiting requested review from robertpi robertpi is a code owner automatically assigned from DataDog/asm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: asm waf Application Security Management (WAF) type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @jandro996 @sezen-datadog