-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GHCR registry pruning #8443
Merged
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f5f08d
to
47924fd
Compare
mcculls
approved these changes
Feb 25, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065964
Total [baseline] (9.178 s) : 0, 9177569
Agent [candidate] (1.068 s) : 0, 1068277
Total [candidate] (9.154 s) : 0, 9154224
section iast
Agent [baseline] (1.199 s) : 0, 1198541
Total [baseline] (9.844 s) : 0, 9844174
Agent [candidate] (1.214 s) : 0, 1214254
Total [candidate] (9.819 s) : 0, 9819397
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.199 s) : 0, 1199428
Total [baseline] (9.766 s) : 0, 9766020
Agent [candidate] (1.206 s) : 0, 1205806
Total [candidate] (9.768 s) : 0, 9768354
section iast_TELEMETRY_OFF
Agent [baseline] (1.207 s) : 0, 1206869
Total [baseline] (9.796 s) : 0, 9796496
Agent [candidate] (1.206 s) : 0, 1205897
Total [candidate] (9.834 s) : 0, 9834451
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (735.064 ms) : 0, 735064
BytebuddyAgent [candidate] (735.559 ms) : 0, 735559
GlobalTracer [baseline] (247.077 ms) : 0, 247077
GlobalTracer [candidate] (247.089 ms) : 0, 247089
AppSec [baseline] (56.802 ms) : 0, 56802
AppSec [candidate] (57.048 ms) : 0, 57048
Remote Config [baseline] (711.02 µs) : 0, 711
Remote Config [candidate] (722.469 µs) : 0, 722
Telemetry [baseline] (11.071 ms) : 0, 11071
Telemetry [candidate] (12.664 ms) : 0, 12664
section iast
BytebuddyAgent [baseline] (853.101 ms) : 0, 853101
BytebuddyAgent [candidate] (867.378 ms) : 0, 867378
GlobalTracer [baseline] (238.017 ms) : 0, 238017
GlobalTracer [candidate] (238.405 ms) : 0, 238405
IAST [baseline] (23.815 ms) : 0, 23815
IAST [candidate] (24.052 ms) : 0, 24052
AppSec [baseline] (58.912 ms) : 0, 58912
AppSec [candidate] (59.269 ms) : 0, 59269
Remote Config [baseline] (637.004 µs) : 0, 637
Remote Config [candidate] (654.333 µs) : 0, 654
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (9.151 ms) : 0, 9151
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (853.032 ms) : 0, 853032
BytebuddyAgent [candidate] (859.067 ms) : 0, 859067
GlobalTracer [baseline] (239.114 ms) : 0, 239114
GlobalTracer [candidate] (239.056 ms) : 0, 239056
IAST [baseline] (23.882 ms) : 0, 23882
IAST [candidate] (24.079 ms) : 0, 24079
AppSec [baseline] (58.726 ms) : 0, 58726
AppSec [candidate] (58.74 ms) : 0, 58740
Remote Config [baseline] (641.552 µs) : 0, 642
Remote Config [candidate] (647.188 µs) : 0, 647
Telemetry [baseline] (8.893 ms) : 0, 8893
Telemetry [candidate] (8.999 ms) : 0, 8999
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (859.554 ms) : 0, 859554
BytebuddyAgent [candidate] (858.543 ms) : 0, 858543
GlobalTracer [baseline] (240.331 ms) : 0, 240331
GlobalTracer [candidate] (239.714 ms) : 0, 239714
IAST [baseline] (27.706 ms) : 0, 27706
IAST [candidate] (26.864 ms) : 0, 26864
AppSec [baseline] (54.503 ms) : 0, 54503
AppSec [candidate] (55.874 ms) : 0, 55874
Remote Config [baseline] (646.494 µs) : 0, 646
Remote Config [candidate] (659.35 µs) : 0, 659
Telemetry [baseline] (8.934 ms) : 0, 8934
Telemetry [candidate] (9.024 ms) : 0, 9024
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061310
Total [baseline] (10.547 s) : 0, 10546914
Agent [candidate] (1.063 s) : 0, 1063169
Total [candidate] (10.564 s) : 0, 10564176
section appsec
Agent [baseline] (1.214 s) : 0, 1213783
Total [baseline] (11.0 s) : 0, 11000225
Agent [candidate] (1.213 s) : 0, 1213038
Total [candidate] (10.938 s) : 0, 10937587
section iast
Agent [baseline] (1.203 s) : 0, 1202554
Total [baseline] (11.144 s) : 0, 11143617
Agent [candidate] (1.207 s) : 0, 1207495
Total [candidate] (11.22 s) : 0, 11219708
section profiling
Agent [baseline] (1.302 s) : 0, 1302402
Total [baseline] (11.076 s) : 0, 11075636
Agent [candidate] (1.295 s) : 0, 1295404
Total [candidate] (11.042 s) : 0, 11041525
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (731.061 ms) : 0, 731061
BytebuddyAgent [candidate] (731.439 ms) : 0, 731439
GlobalTracer [baseline] (245.433 ms) : 0, 245433
GlobalTracer [candidate] (245.902 ms) : 0, 245902
AppSec [baseline] (57.107 ms) : 0, 57107
AppSec [candidate] (57.231 ms) : 0, 57231
Remote Config [baseline] (716.305 µs) : 0, 716
Remote Config [candidate] (729.952 µs) : 0, 730
Telemetry [baseline] (11.878 ms) : 0, 11878
Telemetry [candidate] (12.76 ms) : 0, 12760
section appsec
BytebuddyAgent [baseline] (752.169 ms) : 0, 752169
BytebuddyAgent [candidate] (751.074 ms) : 0, 751074
GlobalTracer [baseline] (243.433 ms) : 0, 243433
GlobalTracer [candidate] (243.548 ms) : 0, 243548
AppSec [baseline] (182.129 ms) : 0, 182129
AppSec [candidate] (182.933 ms) : 0, 182933
Remote Config [baseline] (691.219 µs) : 0, 691
Remote Config [candidate] (685.978 µs) : 0, 686
Telemetry [baseline] (8.938 ms) : 0, 8938
Telemetry [candidate] (8.511 ms) : 0, 8511
IAST [baseline] (22.496 ms) : 0, 22496
IAST [candidate] (22.317 ms) : 0, 22317
section iast
BytebuddyAgent [baseline] (855.594 ms) : 0, 855594
BytebuddyAgent [candidate] (860.638 ms) : 0, 860638
GlobalTracer [baseline] (239.361 ms) : 0, 239361
GlobalTracer [candidate] (239.182 ms) : 0, 239182
AppSec [baseline] (58.645 ms) : 0, 58645
AppSec [candidate] (58.96 ms) : 0, 58960
Remote Config [baseline] (662.831 µs) : 0, 663
Remote Config [candidate] (631.943 µs) : 0, 632
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (8.98 ms) : 0, 8980
IAST [baseline] (24.051 ms) : 0, 24051
IAST [candidate] (23.939 ms) : 0, 23939
section profiling
ProfilingAgent [baseline] (97.24 ms) : 0, 97240
ProfilingAgent [candidate] (96.255 ms) : 0, 96255
BytebuddyAgent [baseline] (728.416 ms) : 0, 728416
BytebuddyAgent [candidate] (724.115 ms) : 0, 724115
GlobalTracer [baseline] (368.257 ms) : 0, 368257
GlobalTracer [candidate] (367.928 ms) : 0, 367928
AppSec [baseline] (57.385 ms) : 0, 57385
AppSec [candidate] (56.139 ms) : 0, 56139
Remote Config [baseline] (698.027 µs) : 0, 698
Remote Config [candidate] (702.215 µs) : 0, 702
Telemetry [baseline] (9.375 ms) : 0, 9375
Telemetry [candidate] (9.29 ms) : 0, 9290
Profiling [baseline] (97.265 ms) : 0, 97265
Profiling [candidate] (96.279 ms) : 0, 96279
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
. : milestone, 1347,
appsec (1.763 ms) : 1740, 1785
. : milestone, 1763,
appsec_no_iast (1.754 ms) : 1729, 1779
. : milestone, 1754,
code_origins (1.707 ms) : 1674, 1740
. : milestone, 1707,
iast (1.503 ms) : 1478, 1527
. : milestone, 1503,
profiling (1.526 ms) : 1501, 1551
. : milestone, 1526,
tracing (1.496 ms) : 1472, 1521
. : milestone, 1496,
section candidate
no_agent (1.358 ms) : 1338, 1379
. : milestone, 1358,
appsec (1.738 ms) : 1715, 1762
. : milestone, 1738,
appsec_no_iast (1.77 ms) : 1746, 1795
. : milestone, 1770,
code_origins (1.691 ms) : 1657, 1725
. : milestone, 1691,
iast (1.506 ms) : 1482, 1530
. : milestone, 1506,
profiling (1.518 ms) : 1494, 1542
. : milestone, 1518,
tracing (1.491 ms) : 1467, 1515
. : milestone, 1491,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section baseline
no_agent (378.812 µs) : 359, 398
. : milestone, 379,
iast (505.032 µs) : 483, 527
. : milestone, 505,
iast_FULL (720.347 µs) : 698, 742
. : milestone, 720,
iast_GLOBAL (549.196 µs) : 528, 571
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (510.632 µs) : 488, 533
. : milestone, 511,
iast_INACTIVE (460.326 µs) : 439, 482
. : milestone, 460,
iast_TELEMETRY_OFF (498.784 µs) : 475, 523
. : milestone, 499,
tracing (452.121 µs) : 431, 473
. : milestone, 452,
section candidate
no_agent (379.226 µs) : 359, 399
. : milestone, 379,
iast (505.542 µs) : 483, 528
. : milestone, 506,
iast_FULL (723.324 µs) : 701, 745
. : milestone, 723,
iast_GLOBAL (551.253 µs) : 529, 573
. : milestone, 551,
iast_HARDCODED_SECRET_DISABLED (511.881 µs) : 490, 534
. : milestone, 512,
iast_INACTIVE (461.112 µs) : 440, 482
. : milestone, 461,
iast_TELEMETRY_OFF (495.868 µs) : 474, 518
. : milestone, 496,
tracing (454.877 µs) : 434, 476
. : milestone, 455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.367 ms) : 2323, 2410
. : milestone, 2367,
iast (2.121 ms) : 2065, 2176
. : milestone, 2121,
iast_GLOBAL (2.163 ms) : 2107, 2219
. : milestone, 2163,
profiling (1.994 ms) : 1949, 2039
. : milestone, 1994,
tracing (1.949 ms) : 1906, 1992
. : milestone, 1949,
section candidate
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (2.375 ms) : 2331, 2418
. : milestone, 2375,
iast (2.117 ms) : 2062, 2172
. : milestone, 2117,
iast_GLOBAL (2.159 ms) : 2103, 2214
. : milestone, 2159,
profiling (2.418 ms) : 2236, 2601
. : milestone, 2418,
tracing (1.947 ms) : 1904, 1989
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6f5f08d727, baseline=1.47.0-SNAPSHOT~c643643e68
dateFormat X
axisFormat %s
section baseline
no_agent (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
appsec (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
iast (18.829 s) : 18829000, 18829000
. : milestone, 18829000,
iast_GLOBAL (17.901 s) : 17901000, 17901000
. : milestone, 17901000,
profiling (15.618 s) : 15618000, 15618000
. : milestone, 15618000,
tracing (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
section candidate
no_agent (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
appsec (15.018 s) : 15018000, 15018000
. : milestone, 15018000,
iast (18.579 s) : 18579000, 18579000
. : milestone, 18579000,
iast_GLOBAL (17.849 s) : 17849000, 17849000
. : milestone, 17849000,
profiling (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
tracing (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
System tests start pushing new tags using architecture.
Those are new pruned from the registry.
Motivation
Keep the registry healthy.
Additional Notes
We can expect system tests disruption as we will reach API call limits when trying to clean up 10k tags from the registry.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: LANGPLAT-326