Gary/add llmobs svc functionalities #8439
Draft
+1,701
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Comment on lines
327
to
328
| private PayloadV2() { | ||
| } |
There was a problem hiding this comment.
⚪ Code Quality Violation
Consider adding super() or this() to your constructor (...read more)
In Java, it is suggested to call super() in an extended class. This rule will report a violation if both a call to super() and an overloaded constructor are absent.
| LOGGER.error("Exception occurred", e); | ||
| } | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
🟠 Code Quality Violation
Avoid printStackTrace(); use a logger call instead. (...read more)
Use a logging framework instead of printStackTrace() when handling exceptions. printStackTrace() can be useful during development for quick debugging, but it is not suitable for production code.
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
9ee77d9 to
0b4f8a8
Compare
gary-huang
force-pushed
the
gary/add-llmobs-svc-functionalities
branch
from
d2ae55a to
eb6b63d
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 20 performance improvements and 7 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.138 s) : 0, 1137809
Total [baseline] (9.329 s) : 0, 9328984
Agent [candidate] (1.049 s) : 0, 1048758
Total [candidate] (8.677 s) : 0, 8677052
section iast
Agent [baseline] (1.261 s) : 0, 1260714
Total [baseline] (9.915 s) : 0, 9915167
Agent [candidate] (1.185 s) : 0, 1185345
Total [candidate] (9.3 s) : 0, 9299531
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.263 s) : 0, 1262844
Total [baseline] (9.861 s) : 0, 9860985
Agent [candidate] (1.181 s) : 0, 1181392
Total [candidate] (9.305 s) : 0, 9304825
section iast_TELEMETRY_OFF
Agent [baseline] (1.254 s) : 0, 1253992
Total [baseline] (9.904 s) : 0, 9904180
Agent [candidate] (1.174 s) : 0, 1173651
Total [candidate] (9.277 s) : 0, 9277333
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.342 ms) : 0, 718342
BytebuddyAgent [candidate] (720.454 ms) : 0, 720454
GlobalTracer [baseline] (240.268 ms) : 0, 240268
GlobalTracer [candidate] (245.197 ms) : 0, 245197
AppSec [baseline] (55.832 ms) : 0, 55832
AppSec [candidate] (55.369 ms) : 0, 55369
Remote Config [baseline] (580.374 µs) : 0, 580
Remote Config [candidate] (732.49 µs) : 0, 732
Telemetry [baseline] (12.436 ms) : 0, 12436
Telemetry [candidate] (11.706 ms) : 0, 11706
Debugger [baseline] (95.37 ms) : 0, 95370
section iast
BytebuddyAgent [baseline] (836.418 ms) : 0, 836418
BytebuddyAgent [candidate] (843.245 ms) : 0, 843245
GlobalTracer [baseline] (231.164 ms) : 0, 231164
GlobalTracer [candidate] (237.337 ms) : 0, 237337
IAST [baseline] (22.816 ms) : 0, 22816
IAST [candidate] (22.961 ms) : 0, 22961
AppSec [baseline] (56.965 ms) : 0, 56965
AppSec [candidate] (56.972 ms) : 0, 56972
Remote Config [baseline] (516.4 µs) : 0, 516
Remote Config [candidate] (613.84 µs) : 0, 614
Telemetry [baseline] (14.278 ms) : 0, 14278
Telemetry [candidate] (8.884 ms) : 0, 8884
Debugger [baseline] (83.525 ms) : 0, 83525
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (837.191 ms) : 0, 837191
BytebuddyAgent [candidate] (839.941 ms) : 0, 839941
GlobalTracer [baseline] (231.05 ms) : 0, 231050
GlobalTracer [candidate] (236.759 ms) : 0, 236759
IAST [baseline] (22.936 ms) : 0, 22936
IAST [candidate] (22.98 ms) : 0, 22980
AppSec [baseline] (57.387 ms) : 0, 57387
AppSec [candidate] (56.904 ms) : 0, 56904
Remote Config [baseline] (521.646 µs) : 0, 522
Remote Config [candidate] (613.747 µs) : 0, 614
Telemetry [baseline] (14.915 ms) : 0, 14915
Telemetry [candidate] (8.805 ms) : 0, 8805
Debugger [baseline] (83.806 ms) : 0, 83806
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.728 ms) : 0, 832728
BytebuddyAgent [candidate] (834.524 ms) : 0, 834524
GlobalTracer [baseline] (230.778 ms) : 0, 230778
GlobalTracer [candidate] (235.749 ms) : 0, 235749
IAST [baseline] (23.852 ms) : 0, 23852
IAST [candidate] (22.417 ms) : 0, 22417
AppSec [baseline] (55.359 ms) : 0, 55359
AppSec [candidate] (56.37 ms) : 0, 56370
Remote Config [baseline] (524.206 µs) : 0, 524
Remote Config [candidate] (617.888 µs) : 0, 618
Telemetry [baseline] (12.076 ms) : 0, 12076
Telemetry [candidate] (8.651 ms) : 0, 8651
Debugger [baseline] (83.668 ms) : 0, 83668
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.137 s) : 0, 1137128
Total [baseline] (11.598 s) : 0, 11598057
Agent [candidate] (1.05 s) : 0, 1050174
Total [candidate] (10.439 s) : 0, 10439243
section appsec
Agent [baseline] (1.271 s) : 0, 1271445
Total [baseline] (11.691 s) : 0, 11690855
Agent [candidate] (1.191 s) : 0, 1191024
Total [candidate] (10.802 s) : 0, 10802462
section iast
Agent [baseline] (1.272 s) : 0, 1272089
Total [baseline] (12.044 s) : 0, 12044312
Agent [candidate] (1.191 s) : 0, 1190817
Total [candidate] (11.046 s) : 0, 11045810
section profiling
Agent [baseline] (1.39 s) : 0, 1390378
Total [baseline] (11.758 s) : 0, 11757953
Agent [candidate] (1.268 s) : 0, 1268353
Total [candidate] (10.897 s) : 0, 10897189
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.127 ms) : 0, 718127
BytebuddyAgent [candidate] (719.995 ms) : 0, 719995
GlobalTracer [baseline] (240.284 ms) : 0, 240284
GlobalTracer [candidate] (245.703 ms) : 0, 245703
AppSec [baseline] (55.494 ms) : 0, 55494
AppSec [candidate] (55.541 ms) : 0, 55541
Remote Config [baseline] (579.611 µs) : 0, 580
Remote Config [candidate] (730.08 µs) : 0, 730
Telemetry [baseline] (12.371 ms) : 0, 12371
Telemetry [candidate] (12.926 ms) : 0, 12926
Debugger [baseline] (95.189 ms) : 0, 95189
section appsec
BytebuddyAgent [baseline] (733.895 ms) : 0, 733895
BytebuddyAgent [candidate] (739.523 ms) : 0, 739523
GlobalTracer [baseline] (236.506 ms) : 0, 236506
GlobalTracer [candidate] (242.746 ms) : 0, 242746
AppSec [baseline] (177.837 ms) : 0, 177837
AppSec [candidate] (172.952 ms) : 0, 172952
Remote Config [baseline] (626.366 µs) : 0, 626
Remote Config [candidate] (668.995 µs) : 0, 669
Telemetry [baseline] (12.266 ms) : 0, 12266
Telemetry [candidate] (8.995 ms) : 0, 8995
Debugger [baseline] (84.537 ms) : 0, 84537
IAST [baseline] (21.569 ms) : 0, 21569
IAST [candidate] (21.551 ms) : 0, 21551
section iast
BytebuddyAgent [baseline] (846.164 ms) : 0, 846164
BytebuddyAgent [candidate] (847.144 ms) : 0, 847144
GlobalTracer [baseline] (232.69 ms) : 0, 232690
GlobalTracer [candidate] (238.002 ms) : 0, 238002
AppSec [baseline] (57.42 ms) : 0, 57420
AppSec [candidate] (57.364 ms) : 0, 57364
Remote Config [baseline] (524.104 µs) : 0, 524
Remote Config [candidate] (639.653 µs) : 0, 640
Telemetry [baseline] (12.987 ms) : 0, 12987
Telemetry [candidate] (8.965 ms) : 0, 8965
Debugger [baseline] (84.164 ms) : 0, 84164
IAST [baseline] (22.912 ms) : 0, 22912
IAST [candidate] (23.256 ms) : 0, 23256
section profiling
ProfilingAgent [baseline] (123.611 ms) : 0, 123611
ProfilingAgent [candidate] (94.408 ms) : 0, 94408
BytebuddyAgent [baseline] (715.456 ms) : 0, 715456
BytebuddyAgent [candidate] (710.785 ms) : 0, 710785
GlobalTracer [baseline] (352.576 ms) : 0, 352576
GlobalTracer [candidate] (356.71 ms) : 0, 356710
AppSec [baseline] (55.394 ms) : 0, 55394
AppSec [candidate] (54.397 ms) : 0, 54397
Remote Config [baseline] (673.473 µs) : 0, 673
Remote Config [candidate] (674.25 µs) : 0, 674
Telemetry [baseline] (12.734 ms) : 0, 12734
Telemetry [candidate] (8.976 ms) : 0, 8976
Profiling [baseline] (123.632 ms) : 0, 123632
Profiling [candidate] (94.433 ms) : 0, 94433
Debugger [baseline] (89.265 ms) : 0, 89265
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (389.201 µs) : 369, 409
. : milestone, 389,
iast (519.455 µs) : 498, 541
. : milestone, 519,
iast_FULL (732.512 µs) : 710, 755
. : milestone, 733,
iast_GLOBAL (565.432 µs) : 543, 588
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (522.834 µs) : 501, 545
. : milestone, 523,
iast_INACTIVE (470.828 µs) : 448, 493
. : milestone, 471,
iast_TELEMETRY_OFF (507.288 µs) : 485, 529
. : milestone, 507,
tracing (459.529 µs) : 438, 481
. : milestone, 460,
section candidate
no_agent (378.513 µs) : 359, 398
. : milestone, 379,
iast (516.122 µs) : 494, 538
. : milestone, 516,
iast_FULL (733.166 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (562.452 µs) : 540, 585
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (515.637 µs) : 494, 538
. : milestone, 516,
iast_INACTIVE (464.642 µs) : 443, 486
. : milestone, 465,
iast_TELEMETRY_OFF (504.691 µs) : 481, 528
. : milestone, 505,
tracing (461.203 µs) : 440, 482
. : milestone, 461,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.347 ms) : 1328, 1367
. : milestone, 1347,
appsec (1.729 ms) : 1704, 1754
. : milestone, 1729,
appsec_no_iast (1.737 ms) : 1713, 1762
. : milestone, 1737,
iast (1.527 ms) : 1501, 1553
. : milestone, 1527,
profiling (1.564 ms) : 1538, 1590
. : milestone, 1564,
tracing (1.497 ms) : 1473, 1521
. : milestone, 1497,
section candidate
no_agent (1.369 ms) : 1350, 1388
. : milestone, 1369,
appsec (1.76 ms) : 1736, 1784
. : milestone, 1760,
appsec_no_iast (1.777 ms) : 1753, 1801
. : milestone, 1777,
iast (1.53 ms) : 1505, 1554
. : milestone, 1530,
profiling (1.518 ms) : 1495, 1541
. : milestone, 1518,
tracing (1.514 ms) : 1488, 1539
. : milestone, 1514,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.344 ms) : 2300, 2388
. : milestone, 2344,
iast (2.134 ms) : 2079, 2190
. : milestone, 2134,
iast_GLOBAL (2.172 ms) : 2116, 2228
. : milestone, 2172,
profiling (1.996 ms) : 1951, 2042
. : milestone, 1996,
tracing (1.955 ms) : 1912, 1997
. : milestone, 1955,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.354 ms) : 2311, 2397
. : milestone, 2354,
iast (2.127 ms) : 2073, 2182
. : milestone, 2127,
iast_GLOBAL (2.163 ms) : 2107, 2218
. : milestone, 2163,
profiling (2.0 ms) : 1955, 2045
. : milestone, 2000,
tracing (1.947 ms) : 1905, 1990
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~8e16ad22d6, baseline=1.47.0-SNAPSHOT~8f945b02a7
dateFormat X
axisFormat %s
section baseline
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (14.883 s) : 14883000, 14883000
. : milestone, 14883000,
iast (18.82 s) : 18820000, 18820000
. : milestone, 18820000,
iast_GLOBAL (18.218 s) : 18218000, 18218000
. : milestone, 18218000,
profiling (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
tracing (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
section candidate
no_agent (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
appsec (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
iast (18.745 s) : 18745000, 18745000
. : milestone, 18745000,
iast_GLOBAL (17.864 s) : 17864000, 17864000
. : milestone, 17864000,
profiling (15.449 s) : 15449000, 15449000
. : milestone, 15449000,
tracing (15.001 s) : 15001000, 15001000
. : milestone, 15001000,
|
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
from
0b4f8a8 to
738eb77
Compare
gary-huang
force-pushed
the
gary/add-llmobs-svc-functionalities
branch
from
eb6b63d to
8e16ad2
Compare
gary-huang
force-pushed
the
gary/add-llm-obs-writer
branch
10 times, most recently
from
1d5dcc0 to
dad55c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]