Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create metric: appsec.waf.config_errors #8394

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Create metric: appsec.waf.config_errors #8394

wants to merge 5 commits into from
+120 −1

Conversation

sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Feb 14, 2025 •
edited by jira bot
Loading

What Does This Do

Creates metric appsec.waf.config_errors which keeps count of errors reported by the WAF on about particular config item

Motivation

This metric counts the configuration errors as reported by libddwaf

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-56480

@pr-commenter
Copy link

pr-commenter bot commented Feb 14, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sezen.leblay/APPSEC-56480-config_errors
git_commit_date 1740058310 1740063782
git_commit_sha 10dc2ef 3765eb5
release_version 1.47.0-SNAPSHOT~10dc2ef4fb 1.47.0-SNAPSHOT~3765eb5186
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740072331 1740072331
ci_job_id 816028189 816028189
ci_pipeline_id 56433972 56433972
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-nnfmazrx-project-304-concurrent-2-7t8x2oca 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-nnfmazrx-project-304-concurrent-2-7t8x2oca 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052591
Total [baseline] (8.678 s) : 0, 8678015
Agent [candidate] (1.046 s) : 0, 1046156
Total [candidate] (8.679 s) : 0, 8678947
section iast
Agent [baseline] (1.171 s) : 0, 1170671
Total [baseline] (9.257 s) : 0, 9256572
Agent [candidate] (1.191 s) : 0, 1191230
Total [candidate] (9.294 s) : 0, 9293766
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1172151
Total [baseline] (9.198 s) : 0, 9197698
Agent [candidate] (1.172 s) : 0, 1171811
Total [candidate] (9.206 s) : 0, 9206492
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1169000
Total [baseline] (9.27 s) : 0, 9269936
Agent [candidate] (1.168 s) : 0, 1167662
Total [candidate] (9.218 s) : 0, 9218175
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.053 s -
Agent iast 1.171 s 118.081 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 119.561 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.169 s 116.41 ms (11.1%)
Total tracing 8.678 s -
Total iast 9.257 s 578.557 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.198 s 519.684 ms (6.0%)
Total iast_TELEMETRY_OFF 9.27 s 591.922 ms (6.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent iast 1.191 s 145.074 ms (13.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 125.655 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.168 s 121.505 ms (11.6%)
Total tracing 8.679 s -
Total iast 9.294 s 614.819 ms (7.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.206 s 527.545 ms (6.1%)
Total iast_TELEMETRY_OFF 9.218 s 539.228 ms (6.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.093 ms) : 0, 725093
BytebuddyAgent [candidate] (720.343 ms) : 0, 720343
GlobalTracer [baseline] (241.467 ms) : 0, 241467
GlobalTracer [candidate] (240.899 ms) : 0, 240899
AppSec [baseline] (56.2 ms) : 0, 56200
AppSec [candidate] (55.986 ms) : 0, 55986
Remote Config [baseline] (700.27 µs) : 0, 700
Remote Config [candidate] (710.446 µs) : 0, 710
Telemetry [baseline] (13.739 ms) : 0, 13739
Telemetry [candidate] (13.044 ms) : 0, 13044
section iast
BytebuddyAgent [baseline] (835.599 ms) : 0, 835599
BytebuddyAgent [candidate] (850.881 ms) : 0, 850881
GlobalTracer [baseline] (230.185 ms) : 0, 230185
GlobalTracer [candidate] (233.893 ms) : 0, 233893
IAST [baseline] (22.844 ms) : 0, 22844
IAST [candidate] (23.331 ms) : 0, 23331
AppSec [baseline] (57.393 ms) : 0, 57393
AppSec [candidate] (58.191 ms) : 0, 58191
Remote Config [baseline] (635.783 µs) : 0, 636
Remote Config [candidate] (621.675 µs) : 0, 622
Telemetry [baseline] (8.806 ms) : 0, 8806
Telemetry [candidate] (8.769 ms) : 0, 8769
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.751 ms) : 0, 836751
BytebuddyAgent [candidate] (836.631 ms) : 0, 836631
GlobalTracer [baseline] (230.526 ms) : 0, 230526
GlobalTracer [candidate] (230.608 ms) : 0, 230608
IAST [baseline] (22.914 ms) : 0, 22914
IAST [candidate] (22.824 ms) : 0, 22824
AppSec [baseline] (57.35 ms) : 0, 57350
AppSec [candidate] (57.287 ms) : 0, 57287
Remote Config [baseline] (613.251 µs) : 0, 613
Remote Config [candidate] (601.703 µs) : 0, 602
Telemetry [baseline] (8.676 ms) : 0, 8676
Telemetry [candidate] (8.652 ms) : 0, 8652
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.878 ms) : 0, 832878
BytebuddyAgent [candidate] (833.432 ms) : 0, 833432
GlobalTracer [baseline] (231.133 ms) : 0, 231133
GlobalTracer [candidate] (230.588 ms) : 0, 230588
IAST [baseline] (25.001 ms) : 0, 25001
IAST [candidate] (23.744 ms) : 0, 23744
AppSec [baseline] (55.44 ms) : 0, 55440
AppSec [candidate] (55.567 ms) : 0, 55567
Remote Config [baseline] (635.824 µs) : 0, 636
Remote Config [candidate] (614.742 µs) : 0, 615
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.565 ms) : 0, 8565
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042645
Total [baseline] (10.421 s) : 0, 10421211
Agent [candidate] (1.042 s) : 0, 1041910
Total [candidate] (10.487 s) : 0, 10486809
section appsec
Agent [baseline] (1.188 s) : 0, 1187570
Total [baseline] (10.775 s) : 0, 10774650
Agent [candidate] (1.186 s) : 0, 1185750
Total [candidate] (10.759 s) : 0, 10758867
section iast
Agent [baseline] (1.17 s) : 0, 1169962
Total [baseline] (11.014 s) : 0, 11014003
Agent [candidate] (1.17 s) : 0, 1169643
Total [candidate] (10.963 s) : 0, 10962832
section profiling
Agent [baseline] (1.263 s) : 0, 1263276
Total [baseline] (10.918 s) : 0, 10918449
Agent [candidate] (1.261 s) : 0, 1260983
Total [candidate] (10.891 s) : 0, 10891023
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.188 s 144.925 ms (13.9%)
Agent iast 1.17 s 127.317 ms (12.2%)
Agent profiling 1.263 s 220.631 ms (21.2%)
Total tracing 10.421 s -
Total appsec 10.775 s 353.439 ms (3.4%)
Total iast 11.014 s 592.793 ms (5.7%)
Total profiling 10.918 s 497.239 ms (4.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.042 s -
Agent appsec 1.186 s 143.841 ms (13.8%)
Agent iast 1.17 s 127.733 ms (12.3%)
Agent profiling 1.261 s 219.073 ms (21.0%)
Total tracing 10.487 s -
Total appsec 10.759 s 272.058 ms (2.6%)
Total iast 10.963 s 476.022 ms (4.5%)
Total profiling 10.891 s 404.214 ms (3.9%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.776 ms) : 0, 717776
BytebuddyAgent [candidate] (718.264 ms) : 0, 718264
GlobalTracer [baseline] (239.708 ms) : 0, 239708
GlobalTracer [candidate] (240.145 ms) : 0, 240145
AppSec [baseline] (56.327 ms) : 0, 56327
AppSec [candidate] (55.459 ms) : 0, 55459
Remote Config [baseline] (696.833 µs) : 0, 697
Remote Config [candidate] (697.697 µs) : 0, 698
Telemetry [baseline] (12.986 ms) : 0, 12986
Telemetry [candidate] (12.166 ms) : 0, 12166
section appsec
BytebuddyAgent [baseline] (737.469 ms) : 0, 737469
BytebuddyAgent [candidate] (734.826 ms) : 0, 734826
GlobalTracer [baseline] (237.723 ms) : 0, 237723
GlobalTracer [candidate] (236.796 ms) : 0, 236796
AppSec [baseline] (177.398 ms) : 0, 177398
AppSec [candidate] (179.207 ms) : 0, 179207
Remote Config [baseline] (668.757 µs) : 0, 669
Remote Config [candidate] (684.508 µs) : 0, 685
Telemetry [baseline] (8.3 ms) : 0, 8300
Telemetry [candidate] (8.25 ms) : 0, 8250
IAST [baseline] (21.593 ms) : 0, 21593
IAST [candidate] (21.501 ms) : 0, 21501
section iast
BytebuddyAgent [baseline] (835.394 ms) : 0, 835394
BytebuddyAgent [candidate] (835.49 ms) : 0, 835490
GlobalTracer [baseline] (230.052 ms) : 0, 230052
GlobalTracer [candidate] (230.265 ms) : 0, 230265
AppSec [baseline] (57.136 ms) : 0, 57136
AppSec [candidate] (56.805 ms) : 0, 56805
Remote Config [baseline] (611.988 µs) : 0, 612
Remote Config [candidate] (614.023 µs) : 0, 614
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (8.651 ms) : 0, 8651
IAST [baseline] (22.8 ms) : 0, 22800
IAST [candidate] (22.586 ms) : 0, 22586
section profiling
BytebuddyAgent [baseline] (708.515 ms) : 0, 708515
BytebuddyAgent [candidate] (707.844 ms) : 0, 707844
GlobalTracer [baseline] (350.221 ms) : 0, 350221
GlobalTracer [candidate] (350.766 ms) : 0, 350766
AppSec [baseline] (55.538 ms) : 0, 55538
AppSec [candidate] (54.714 ms) : 0, 54714
Remote Config [baseline] (672.239 µs) : 0, 672
Remote Config [candidate] (671.736 µs) : 0, 672
Telemetry [baseline] (9.016 ms) : 0, 9016
Telemetry [candidate] (8.919 ms) : 0, 8919
ProfilingAgent [baseline] (96.957 ms) : 0, 96957
ProfilingAgent [candidate] (96.048 ms) : 0, 96048
Profiling [baseline] (96.981 ms) : 0, 96981
Profiling [candidate] (96.072 ms) : 0, 96072
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-20T16:58:09 2025-02-20T17:05:12
git_branch master sezen.leblay/APPSEC-56480-config_errors
git_commit_date 1740058310 1740063782
git_commit_sha 10dc2ef 3765eb5
release_version 1.47.0-SNAPSHOT~10dc2ef4fb 1.47.0-SNAPSHOT~3765eb5186
start_time 2025-02-20T16:57:55 2025-02-20T17:04:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740071468 1740071468
ci_job_id 816028190 816028190
ci_pipeline_id 56433972 56433972
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-kvxxueez-project-304-concurrent-2-4aqlzyr8 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-kvxxueez-project-304-concurrent-2-4aqlzyr8 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.333 ms) : 1314, 1353
.   : milestone, 1333,
appsec (1.767 ms) : 1743, 1790
.   : milestone, 1767,
appsec_no_iast (1.754 ms) : 1729, 1779
.   : milestone, 1754,
iast (1.503 ms) : 1479, 1526
.   : milestone, 1503,
profiling (1.511 ms) : 1487, 1535
.   : milestone, 1511,
tracing (1.49 ms) : 1466, 1515
.   : milestone, 1490,
section candidate
no_agent (1.372 ms) : 1351, 1392
.   : milestone, 1372,
appsec (1.754 ms) : 1731, 1778
.   : milestone, 1754,
appsec_no_iast (1.761 ms) : 1737, 1785
.   : milestone, 1761,
iast (1.514 ms) : 1490, 1539
.   : milestone, 1514,
profiling (1.502 ms) : 1479, 1526
.   : milestone, 1502,
tracing (1.464 ms) : 1440, 1489
.   : milestone, 1464,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.333 ms [1.314 ms, 1.353 ms] -
appsec 1.767 ms [1.743 ms, 1.79 ms] 433.304 µs (32.5%)
appsec_no_iast 1.754 ms [1.729 ms, 1.779 ms] 420.968 µs (31.6%)
iast 1.503 ms [1.479 ms, 1.526 ms] 169.439 µs (12.7%)
profiling 1.511 ms [1.487 ms, 1.535 ms] 177.833 µs (13.3%)
tracing 1.49 ms [1.466 ms, 1.515 ms] 156.969 µs (11.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.372 ms [1.351 ms, 1.392 ms] -
appsec 1.754 ms [1.731 ms, 1.778 ms] 382.869 µs (27.9%)
appsec_no_iast 1.761 ms [1.737 ms, 1.785 ms] 389.024 µs (28.4%)
iast 1.514 ms [1.49 ms, 1.539 ms] 142.665 µs (10.4%)
profiling 1.502 ms [1.479 ms, 1.526 ms] 130.557 µs (9.5%)
tracing 1.464 ms [1.44 ms, 1.489 ms] 92.832 µs (6.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
    dateFormat X
    axisFormat %s
section baseline
no_agent (385.655 µs) : 365, 406
.   : milestone, 386,
iast (512.794 µs) : 489, 536
.   : milestone, 513,
iast_FULL (731.176 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (560.062 µs) : 538, 582
.   : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (515.633 µs) : 493, 538
.   : milestone, 516,
iast_INACTIVE (461.743 µs) : 440, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (500.233 µs) : 477, 523
.   : milestone, 500,
tracing (459.796 µs) : 439, 481
.   : milestone, 460,
section candidate
no_agent (380.313 µs) : 361, 400
.   : milestone, 380,
iast (516.996 µs) : 495, 539
.   : milestone, 517,
iast_FULL (735.793 µs) : 714, 758
.   : milestone, 736,
iast_GLOBAL (554.199 µs) : 533, 576
.   : milestone, 554,
iast_HARDCODED_SECRET_DISABLED (511.842 µs) : 489, 534
.   : milestone, 512,
iast_INACTIVE (463.942 µs) : 442, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (503.461 µs) : 480, 527
.   : milestone, 503,
tracing (454.376 µs) : 433, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 385.655 µs [365.267 µs, 406.044 µs] -
iast 512.794 µs [489.352 µs, 536.235 µs] 127.139 µs (33.0%)
iast_FULL 731.176 µs [709.108 µs, 753.244 µs] 345.521 µs (89.6%)
iast_GLOBAL 560.062 µs [538.451 µs, 581.672 µs] 174.406 µs (45.2%)
iast_HARDCODED_SECRET_DISABLED 515.633 µs [493.1 µs, 538.166 µs] 129.978 µs (33.7%)
iast_INACTIVE 461.743 µs [440.236 µs, 483.25 µs] 76.088 µs (19.7%)
iast_TELEMETRY_OFF 500.233 µs [477.183 µs, 523.283 µs] 114.578 µs (29.7%)
tracing 459.796 µs [438.562 µs, 481.03 µs] 74.141 µs (19.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.313 µs [360.714 µs, 399.911 µs] -
iast 516.996 µs [494.947 µs, 539.044 µs] 136.683 µs (35.9%)
iast_FULL 735.793 µs [713.858 µs, 757.729 µs] 355.48 µs (93.5%)
iast_GLOBAL 554.199 µs [532.621 µs, 575.778 µs] 173.886 µs (45.7%)
iast_HARDCODED_SECRET_DISABLED 511.842 µs [489.219 µs, 534.464 µs] 131.529 µs (34.6%)
iast_INACTIVE 463.942 µs [442.422 µs, 485.461 µs] 83.629 µs (22.0%)
iast_TELEMETRY_OFF 503.461 µs [479.88 µs, 527.042 µs] 123.148 µs (32.4%)
tracing 454.376 µs [433.279 µs, 475.473 µs] 74.063 µs (19.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sezen.leblay/APPSEC-56480-config_errors
git_commit_date 1740058310 1740063782
git_commit_sha 10dc2ef 3765eb5
release_version 1.47.0-SNAPSHOT~10dc2ef4fb 1.47.0-SNAPSHOT~3765eb5186
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1740072058 1740072058
ci_job_id 816028191 816028191
ci_pipeline_id 56433972 56433972
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-nnfmazrx-project-304-concurrent-3-ph789de7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-nnfmazrx-project-304-concurrent-3-ph789de7 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.365 ms) : 2321, 2408
.   : milestone, 2365,
iast (2.119 ms) : 2063, 2174
.   : milestone, 2119,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.993 ms) : 1948, 2038
.   : milestone, 1993,
tracing (1.956 ms) : 1913, 1998
.   : milestone, 1956,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.365 ms) : 2321, 2408
.   : milestone, 2365,
iast (2.108 ms) : 2054, 2163
.   : milestone, 2108,
iast_GLOBAL (2.157 ms) : 2102, 2212
.   : milestone, 2157,
profiling (1.963 ms) : 1919, 2006
.   : milestone, 1963,
tracing (1.947 ms) : 1905, 1989
.   : milestone, 1947,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.365 ms [2.321 ms, 2.408 ms] 892.843 µs (60.7%)
iast 2.119 ms [2.063 ms, 2.174 ms] 646.773 µs (43.9%)
iast_GLOBAL 2.152 ms [2.097 ms, 2.207 ms] 679.976 µs (46.2%)
profiling 1.993 ms [1.948 ms, 2.038 ms] 521.178 µs (35.4%)
tracing 1.956 ms [1.913 ms, 1.998 ms] 483.664 µs (32.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.365 ms [2.321 ms, 2.408 ms] 895.881 µs (61.0%)
iast 2.108 ms [2.054 ms, 2.163 ms] 639.709 µs (43.6%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.212 ms] 687.864 µs (46.8%)
profiling 1.963 ms [1.919 ms, 2.006 ms] 494.129 µs (33.6%)
tracing 1.947 ms [1.905 ms, 1.989 ms] 478.136 µs (32.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~3765eb5186, baseline=1.47.0-SNAPSHOT~10dc2ef4fb
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
appsec (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
iast (18.416 s) : 18416000, 18416000
.   : milestone, 18416000,
iast_GLOBAL (17.839 s) : 17839000, 17839000
.   : milestone, 17839000,
profiling (14.991 s) : 14991000, 14991000
.   : milestone, 14991000,
tracing (14.988 s) : 14988000, 14988000
.   : milestone, 14988000,
section candidate
no_agent (15.335 s) : 15335000, 15335000
.   : milestone, 15335000,
appsec (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
iast (19.119 s) : 19119000, 19119000
.   : milestone, 19119000,
iast_GLOBAL (17.32 s) : 17320000, 17320000
.   : milestone, 17320000,
profiling (15.261 s) : 15261000, 15261000
.   : milestone, 15261000,
tracing (14.927 s) : 14927000, 14927000
.   : milestone, 14927000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.063 s [15.063 s, 15.063 s] -
appsec 15.045 s [15.045 s, 15.045 s] -18.0 ms (-0.1%)
iast 18.416 s [18.416 s, 18.416 s] 3.353 s (22.3%)
iast_GLOBAL 17.839 s [17.839 s, 17.839 s] 2.776 s (18.4%)
profiling 14.991 s [14.991 s, 14.991 s] -72.0 ms (-0.5%)
tracing 14.988 s [14.988 s, 14.988 s] -75.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.335 s [15.335 s, 15.335 s] -
appsec 15.143 s [15.143 s, 15.143 s] -192.0 ms (-1.3%)
iast 19.119 s [19.119 s, 19.119 s] 3.784 s (24.7%)
iast_GLOBAL 17.32 s [17.32 s, 17.32 s] 1.985 s (12.9%)
profiling 15.261 s [15.261 s, 15.261 s] -74.0 ms (-0.5%)
tracing 14.927 s [14.927 s, 14.927 s] -408.0 ms (-2.7%)

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 200de0f to 5358abc Compare February 17, 2025 09:28
@sezen-datadog sezen-datadog marked this pull request as ready for review February 17, 2025 09:28
@sezen-datadog sezen-datadog requested review from a team as code owners February 17, 2025 09:28
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 3602794 to b81bc2b Compare February 17, 2025 13:03
@sezen-datadog sezen-datadog requested a review from smola February 17, 2025 13:23
@sezen-datadog sezen-datadog requested a review from smola February 17, 2025 14:52
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 2a5843a to 58f7a0c Compare February 17, 2025 14:58
@sezen-datadog sezen-datadog enabled auto-merge (squash) February 17, 2025 14:59
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from 58f7a0c to 325d88b Compare February 17, 2025 16:16
@sezen-datadog sezen-datadog marked this pull request as draft February 18, 2025 08:52
auto-merge was automatically disabled February 18, 2025 08:52

Pull request was converted to draft

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from d51336d to 66744d3 Compare February 18, 2025 15:58
@sezen-datadog sezen-datadog marked this pull request as ready for review February 19, 2025 08:34
@sezen-datadog sezen-datadog marked this pull request as draft February 19, 2025 09:51
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/APPSEC-56480-config_errors branch from cfb9393 to b663d78 Compare February 19, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola requested changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/asm-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
comp: metrics Metrics type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sezen-datadog @smola