-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate spotless, muzzle, and test-published-artifacts from CircleCI to Gitlab #8385
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048276
Total [baseline] (8.661 s) : 0, 8660690
Agent [candidate] (1.039 s) : 0, 1039291
Total [candidate] (8.643 s) : 0, 8643239
section iast
Agent [baseline] (1.168 s) : 0, 1168130
Total [baseline] (9.225 s) : 0, 9224780
Agent [candidate] (1.171 s) : 0, 1171410
Total [candidate] (9.221 s) : 0, 9220868
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190643
Total [baseline] (9.273 s) : 0, 9273415
Agent [candidate] (1.171 s) : 0, 1170574
Total [candidate] (9.238 s) : 0, 9238413
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176321
Total [baseline] (9.208 s) : 0, 9208136
Agent [candidate] (1.167 s) : 0, 1167084
Total [candidate] (9.21 s) : 0, 9210485
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.446 ms) : 0, 723446
BytebuddyAgent [candidate] (716.862 ms) : 0, 716862
GlobalTracer [baseline] (240.765 ms) : 0, 240765
GlobalTracer [candidate] (239.547 ms) : 0, 239547
AppSec [baseline] (55.718 ms) : 0, 55718
AppSec [candidate] (55.473 ms) : 0, 55473
Remote Config [baseline] (696.099 µs) : 0, 696
Remote Config [candidate] (699.07 µs) : 0, 699
Telemetry [baseline] (12.32 ms) : 0, 12320
Telemetry [candidate] (11.581 ms) : 0, 11581
section iast
BytebuddyAgent [baseline] (834.641 ms) : 0, 834641
BytebuddyAgent [candidate] (836.886 ms) : 0, 836886
GlobalTracer [baseline] (229.962 ms) : 0, 229962
GlobalTracer [candidate] (230.134 ms) : 0, 230134
AppSec [baseline] (56.805 ms) : 0, 56805
AppSec [candidate] (56.983 ms) : 0, 56983
Remote Config [baseline] (617.002 µs) : 0, 617
Remote Config [candidate] (603.806 µs) : 0, 604
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.687 ms) : 0, 8687
IAST [baseline] (22.374 ms) : 0, 22374
IAST [candidate] (22.885 ms) : 0, 22885
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (850.53 ms) : 0, 850530
BytebuddyAgent [candidate] (836.216 ms) : 0, 836216
GlobalTracer [baseline] (233.046 ms) : 0, 233046
GlobalTracer [candidate] (229.939 ms) : 0, 229939
AppSec [baseline] (58.387 ms) : 0, 58387
AppSec [candidate] (57.032 ms) : 0, 57032
Remote Config [baseline] (646.128 µs) : 0, 646
Remote Config [candidate] (606.397 µs) : 0, 606
Telemetry [baseline] (9.015 ms) : 0, 9015
Telemetry [candidate] (8.674 ms) : 0, 8674
IAST [baseline] (23.529 ms) : 0, 23529
IAST [candidate] (22.882 ms) : 0, 22882
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.71 ms) : 0, 839710
BytebuddyAgent [candidate] (833.776 ms) : 0, 833776
GlobalTracer [baseline] (231.808 ms) : 0, 231808
GlobalTracer [candidate] (230.036 ms) : 0, 230036
AppSec [baseline] (53.787 ms) : 0, 53787
AppSec [candidate] (52.07 ms) : 0, 52070
Remote Config [baseline] (641.633 µs) : 0, 642
Remote Config [candidate] (615.904 µs) : 0, 616
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.551 ms) : 0, 8551
IAST [baseline] (26.369 ms) : 0, 26369
IAST [candidate] (26.817 ms) : 0, 26817
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052185
Total [baseline] (10.445 s) : 0, 10445237
Agent [candidate] (1.049 s) : 0, 1048829
Total [candidate] (10.452 s) : 0, 10451684
section appsec
Agent [baseline] (1.182 s) : 0, 1181634
Total [baseline] (10.74 s) : 0, 10740074
Agent [candidate] (1.181 s) : 0, 1180845
Total [candidate] (10.729 s) : 0, 10728501
section iast
Agent [baseline] (1.176 s) : 0, 1176014
Total [baseline] (10.956 s) : 0, 10955871
Agent [candidate] (1.179 s) : 0, 1179245
Total [candidate] (10.988 s) : 0, 10988500
section profiling
Agent [baseline] (1.26 s) : 0, 1260373
Total [baseline] (10.799 s) : 0, 10799361
Agent [candidate] (1.261 s) : 0, 1260576
Total [candidate] (10.853 s) : 0, 10853148
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.545 ms) : 0, 724545
BytebuddyAgent [candidate] (721.887 ms) : 0, 721887
GlobalTracer [baseline] (242.815 ms) : 0, 242815
GlobalTracer [candidate] (240.772 ms) : 0, 240772
AppSec [baseline] (56.208 ms) : 0, 56208
AppSec [candidate] (55.931 ms) : 0, 55931
Remote Config [baseline] (703.666 µs) : 0, 704
Remote Config [candidate] (708.825 µs) : 0, 709
Telemetry [baseline] (12.5 ms) : 0, 12500
Telemetry [candidate] (14.335 ms) : 0, 14335
section appsec
BytebuddyAgent [baseline] (733.503 ms) : 0, 733503
BytebuddyAgent [candidate] (733.676 ms) : 0, 733676
GlobalTracer [baseline] (236.376 ms) : 0, 236376
GlobalTracer [candidate] (236.226 ms) : 0, 236226
AppSec [baseline] (176.945 ms) : 0, 176945
AppSec [candidate] (176.112 ms) : 0, 176112
Remote Config [baseline] (658.983 µs) : 0, 659
Remote Config [candidate] (659.795 µs) : 0, 660
Telemetry [baseline] (8.233 ms) : 0, 8233
Telemetry [candidate] (8.291 ms) : 0, 8291
IAST [baseline] (21.399 ms) : 0, 21399
IAST [candidate] (21.404 ms) : 0, 21404
section iast
BytebuddyAgent [baseline] (839.312 ms) : 0, 839312
BytebuddyAgent [candidate] (842.672 ms) : 0, 842672
GlobalTracer [baseline] (231.219 ms) : 0, 231219
GlobalTracer [candidate] (231.369 ms) : 0, 231369
AppSec [baseline] (57.874 ms) : 0, 57874
AppSec [candidate] (57.535 ms) : 0, 57535
Remote Config [baseline] (624.066 µs) : 0, 624
Remote Config [candidate] (622.928 µs) : 0, 623
Telemetry [baseline] (8.94 ms) : 0, 8940
Telemetry [candidate] (8.763 ms) : 0, 8763
IAST [baseline] (22.76 ms) : 0, 22760
IAST [candidate] (22.971 ms) : 0, 22971
section profiling
ProfilingAgent [baseline] (96.24 ms) : 0, 96240
ProfilingAgent [candidate] (95.859 ms) : 0, 95859
BytebuddyAgent [baseline] (707.106 ms) : 0, 707106
BytebuddyAgent [candidate] (708.77 ms) : 0, 708770
GlobalTracer [baseline] (349.834 ms) : 0, 349834
GlobalTracer [candidate] (349.236 ms) : 0, 349236
AppSec [baseline] (55.443 ms) : 0, 55443
AppSec [candidate] (54.568 ms) : 0, 54568
Remote Config [baseline] (667.862 µs) : 0, 668
Remote Config [candidate] (662.417 µs) : 0, 662
Telemetry [baseline] (8.958 ms) : 0, 8958
Telemetry [candidate] (8.977 ms) : 0, 8977
Profiling [baseline] (96.265 ms) : 0, 96265
Profiling [candidate] (95.883 ms) : 0, 95883
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section baseline
no_agent (383.07 µs) : 363, 403
. : milestone, 383,
iast (521.161 µs) : 498, 544
. : milestone, 521,
iast_FULL (733.08 µs) : 711, 755
. : milestone, 733,
iast_GLOBAL (564.563 µs) : 543, 587
. : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (513.225 µs) : 491, 536
. : milestone, 513,
iast_INACTIVE (469.015 µs) : 448, 490
. : milestone, 469,
iast_TELEMETRY_OFF (511.164 µs) : 488, 535
. : milestone, 511,
tracing (457.427 µs) : 437, 478
. : milestone, 457,
section candidate
no_agent (382.487 µs) : 363, 402
. : milestone, 382,
iast (517.527 µs) : 496, 539
. : milestone, 518,
iast_FULL (736.954 µs) : 715, 759
. : milestone, 737,
iast_GLOBAL (571.34 µs) : 548, 594
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (523.655 µs) : 500, 547
. : milestone, 524,
iast_INACTIVE (467.018 µs) : 446, 488
. : milestone, 467,
iast_TELEMETRY_OFF (508.425 µs) : 485, 532
. : milestone, 508,
tracing (465.703 µs) : 445, 487
. : milestone, 466,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1393
. : milestone, 1374,
appsec (1.751 ms) : 1728, 1775
. : milestone, 1751,
appsec_no_iast (1.792 ms) : 1769, 1815
. : milestone, 1792,
iast (1.507 ms) : 1483, 1531
. : milestone, 1507,
profiling (1.526 ms) : 1500, 1551
. : milestone, 1526,
tracing (1.494 ms) : 1469, 1520
. : milestone, 1494,
section candidate
no_agent (1.374 ms) : 1354, 1394
. : milestone, 1374,
appsec (1.756 ms) : 1733, 1780
. : milestone, 1756,
appsec_no_iast (1.758 ms) : 1730, 1786
. : milestone, 1758,
iast (1.531 ms) : 1506, 1555
. : milestone, 1531,
profiling (1.522 ms) : 1498, 1546
. : milestone, 1522,
tracing (1.473 ms) : 1448, 1498
. : milestone, 1473,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.362 ms) : 2319, 2405
. : milestone, 2362,
iast (2.123 ms) : 2068, 2178
. : milestone, 2123,
iast_GLOBAL (2.157 ms) : 2102, 2213
. : milestone, 2157,
profiling (1.962 ms) : 1919, 2005
. : milestone, 1962,
tracing (1.951 ms) : 1909, 1994
. : milestone, 1951,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.351 ms) : 2307, 2394
. : milestone, 2351,
iast (2.106 ms) : 2051, 2161
. : milestone, 2106,
iast_GLOBAL (2.161 ms) : 2105, 2216
. : milestone, 2161,
profiling (1.976 ms) : 1933, 2020
. : milestone, 1976,
tracing (1.937 ms) : 1895, 1979
. : milestone, 1937,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
dateFormat X
axisFormat %s
section baseline
no_agent (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
appsec (15.085 s) : 15085000, 15085000
. : milestone, 15085000,
iast (18.993 s) : 18993000, 18993000
. : milestone, 18993000,
iast_GLOBAL (17.613 s) : 17613000, 17613000
. : milestone, 17613000,
profiling (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
tracing (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
section candidate
no_agent (15.285 s) : 15285000, 15285000
. : milestone, 15285000,
appsec (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
iast (18.572 s) : 18572000, 18572000
. : milestone, 18572000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
. : milestone, 18034000,
profiling (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
tracing (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
|
@@ -23,15 +23,24 @@ variables: | |||
DEPENDENCY_CACHE_POLICY: pull | |||
BUILD_CACHE_POLICY: pull | |||
GRADLE_VERSION: "8.4" # must match gradle-wrapper.properties | |||
JAVA_BUILD_IMAGE_VERSION: "v25.01" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the automation related to the tag update. I can track it as KLTO if you want?
.gitlab-ci.yml
Outdated
DEPENDENCY_CACHE_POLICY: pull | ||
script: | ||
- ./gradlew clean :dd-java-agent:shadowJar :dd-trace-api:jar :dd-trace-ot:shadowJar $GRADLE_ARGS | ||
- ./gradlew resolveAndLockAll --write-locks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the lock expected to be disabled here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, IDK. I'm just following what was done in CircleCI. I found the default build job in circleci has this line so I added it to the Gitlab build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are distinct pipelines:
- weekly builds
- nightly builds
- PR check builds
We want to update the lock only for nightly builds. If we do it for all the builds, the locks are no more useful in CI anymore (and devs will have a different builds than CI too).
Can you re-introduce this behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. resolveAndLockAll
now only runs as part of nightly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the migration
I added a "required" gitlab job to make it easier to Github PR required jobs
Should I add it already to the required checks? How would it behave for branches that don't have migrated yet?
What Does This Do
Migrate
spotless
,muzzle
, andtest-published-artifacts
jobs from CircleCI to GitlabMotivation
Eventually, all CI is going to be migrated off of CircleCI. These are some of the easier jobs that can be moved now.
Additional Notes
With a parallelism of 8, muzzle takes ~4-5 minutes to complete.
I added a "required" gitlab job to make it easier to Github PR required jobs