Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate spotless, muzzle, and test-published-artifacts from CircleCI to Gitlab #8385

Merged
merged 9 commits into from
Feb 20, 2025

Conversation

randomanderson
Copy link
Contributor

What Does This Do

Migrate spotless, muzzle, and test-published-artifacts jobs from CircleCI to Gitlab

Motivation

Eventually, all CI is going to be migrated off of CircleCI. These are some of the easier jobs that can be moved now.

Additional Notes

With a parallelism of 8, muzzle takes ~4-5 minutes to complete.

I added a "required" gitlab job to make it easier to Github PR required jobs

@randomanderson randomanderson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Feb 13, 2025
@randomanderson randomanderson requested a review from a team as a code owner February 13, 2025 18:13
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/gitlab-migrate-pt1
git_commit_date 1739977713 1739980428
git_commit_sha 27b2d68 6e897a1
release_version 1.47.0-SNAPSHOT~27b2d685cd 1.47.0-SNAPSHOT~6e897a1a20
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739982998 1739982998
ci_job_id 814237027 814237027
ci_pipeline_id 56309811 56309811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hje1ddpw-project-304-concurrent-0-zjy8cowr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hje1ddpw-project-304-concurrent-0-zjy8cowr 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048276
Total [baseline] (8.661 s) : 0, 8660690
Agent [candidate] (1.039 s) : 0, 1039291
Total [candidate] (8.643 s) : 0, 8643239
section iast
Agent [baseline] (1.168 s) : 0, 1168130
Total [baseline] (9.225 s) : 0, 9224780
Agent [candidate] (1.171 s) : 0, 1171410
Total [candidate] (9.221 s) : 0, 9220868
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.191 s) : 0, 1190643
Total [baseline] (9.273 s) : 0, 9273415
Agent [candidate] (1.171 s) : 0, 1170574
Total [candidate] (9.238 s) : 0, 9238413
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176321
Total [baseline] (9.208 s) : 0, 9208136
Agent [candidate] (1.167 s) : 0, 1167084
Total [candidate] (9.21 s) : 0, 9210485
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.168 s 119.853 ms (11.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.191 s 142.367 ms (13.6%)
Agent iast_TELEMETRY_OFF 1.176 s 128.045 ms (12.2%)
Total tracing 8.661 s -
Total iast 9.225 s 564.09 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.273 s 612.724 ms (7.1%)
Total iast_TELEMETRY_OFF 9.208 s 547.446 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.171 s 132.119 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 131.283 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.167 s 127.793 ms (12.3%)
Total tracing 8.643 s -
Total iast 9.221 s 577.629 ms (6.7%)
Total iast_HARDCODED_SECRET_DISABLED 9.238 s 595.175 ms (6.9%)
Total iast_TELEMETRY_OFF 9.21 s 567.246 ms (6.6%)
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.446 ms) : 0, 723446
BytebuddyAgent [candidate] (716.862 ms) : 0, 716862
GlobalTracer [baseline] (240.765 ms) : 0, 240765
GlobalTracer [candidate] (239.547 ms) : 0, 239547
AppSec [baseline] (55.718 ms) : 0, 55718
AppSec [candidate] (55.473 ms) : 0, 55473
Remote Config [baseline] (696.099 µs) : 0, 696
Remote Config [candidate] (699.07 µs) : 0, 699
Telemetry [baseline] (12.32 ms) : 0, 12320
Telemetry [candidate] (11.581 ms) : 0, 11581
section iast
BytebuddyAgent [baseline] (834.641 ms) : 0, 834641
BytebuddyAgent [candidate] (836.886 ms) : 0, 836886
GlobalTracer [baseline] (229.962 ms) : 0, 229962
GlobalTracer [candidate] (230.134 ms) : 0, 230134
AppSec [baseline] (56.805 ms) : 0, 56805
AppSec [candidate] (56.983 ms) : 0, 56983
Remote Config [baseline] (617.002 µs) : 0, 617
Remote Config [candidate] (603.806 µs) : 0, 604
Telemetry [baseline] (8.57 ms) : 0, 8570
Telemetry [candidate] (8.687 ms) : 0, 8687
IAST [baseline] (22.374 ms) : 0, 22374
IAST [candidate] (22.885 ms) : 0, 22885
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (850.53 ms) : 0, 850530
BytebuddyAgent [candidate] (836.216 ms) : 0, 836216
GlobalTracer [baseline] (233.046 ms) : 0, 233046
GlobalTracer [candidate] (229.939 ms) : 0, 229939
AppSec [baseline] (58.387 ms) : 0, 58387
AppSec [candidate] (57.032 ms) : 0, 57032
Remote Config [baseline] (646.128 µs) : 0, 646
Remote Config [candidate] (606.397 µs) : 0, 606
Telemetry [baseline] (9.015 ms) : 0, 9015
Telemetry [candidate] (8.674 ms) : 0, 8674
IAST [baseline] (23.529 ms) : 0, 23529
IAST [candidate] (22.882 ms) : 0, 22882
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (839.71 ms) : 0, 839710
BytebuddyAgent [candidate] (833.776 ms) : 0, 833776
GlobalTracer [baseline] (231.808 ms) : 0, 231808
GlobalTracer [candidate] (230.036 ms) : 0, 230036
AppSec [baseline] (53.787 ms) : 0, 53787
AppSec [candidate] (52.07 ms) : 0, 52070
Remote Config [baseline] (641.633 µs) : 0, 642
Remote Config [candidate] (615.904 µs) : 0, 616
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.551 ms) : 0, 8551
IAST [baseline] (26.369 ms) : 0, 26369
IAST [candidate] (26.817 ms) : 0, 26817
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052185
Total [baseline] (10.445 s) : 0, 10445237
Agent [candidate] (1.049 s) : 0, 1048829
Total [candidate] (10.452 s) : 0, 10451684
section appsec
Agent [baseline] (1.182 s) : 0, 1181634
Total [baseline] (10.74 s) : 0, 10740074
Agent [candidate] (1.181 s) : 0, 1180845
Total [candidate] (10.729 s) : 0, 10728501
section iast
Agent [baseline] (1.176 s) : 0, 1176014
Total [baseline] (10.956 s) : 0, 10955871
Agent [candidate] (1.179 s) : 0, 1179245
Total [candidate] (10.988 s) : 0, 10988500
section profiling
Agent [baseline] (1.26 s) : 0, 1260373
Total [baseline] (10.799 s) : 0, 10799361
Agent [candidate] (1.261 s) : 0, 1260576
Total [candidate] (10.853 s) : 0, 10853148
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.182 s 129.449 ms (12.3%)
Agent iast 1.176 s 123.829 ms (11.8%)
Agent profiling 1.26 s 208.188 ms (19.8%)
Total tracing 10.445 s -
Total appsec 10.74 s 294.836 ms (2.8%)
Total iast 10.956 s 510.634 ms (4.9%)
Total profiling 10.799 s 354.124 ms (3.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.049 s -
Agent appsec 1.181 s 132.016 ms (12.6%)
Agent iast 1.179 s 130.416 ms (12.4%)
Agent profiling 1.261 s 211.747 ms (20.2%)
Total tracing 10.452 s -
Total appsec 10.729 s 276.817 ms (2.6%)
Total iast 10.988 s 536.816 ms (5.1%)
Total profiling 10.853 s 401.464 ms (3.8%)
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.545 ms) : 0, 724545
BytebuddyAgent [candidate] (721.887 ms) : 0, 721887
GlobalTracer [baseline] (242.815 ms) : 0, 242815
GlobalTracer [candidate] (240.772 ms) : 0, 240772
AppSec [baseline] (56.208 ms) : 0, 56208
AppSec [candidate] (55.931 ms) : 0, 55931
Remote Config [baseline] (703.666 µs) : 0, 704
Remote Config [candidate] (708.825 µs) : 0, 709
Telemetry [baseline] (12.5 ms) : 0, 12500
Telemetry [candidate] (14.335 ms) : 0, 14335
section appsec
BytebuddyAgent [baseline] (733.503 ms) : 0, 733503
BytebuddyAgent [candidate] (733.676 ms) : 0, 733676
GlobalTracer [baseline] (236.376 ms) : 0, 236376
GlobalTracer [candidate] (236.226 ms) : 0, 236226
AppSec [baseline] (176.945 ms) : 0, 176945
AppSec [candidate] (176.112 ms) : 0, 176112
Remote Config [baseline] (658.983 µs) : 0, 659
Remote Config [candidate] (659.795 µs) : 0, 660
Telemetry [baseline] (8.233 ms) : 0, 8233
Telemetry [candidate] (8.291 ms) : 0, 8291
IAST [baseline] (21.399 ms) : 0, 21399
IAST [candidate] (21.404 ms) : 0, 21404
section iast
BytebuddyAgent [baseline] (839.312 ms) : 0, 839312
BytebuddyAgent [candidate] (842.672 ms) : 0, 842672
GlobalTracer [baseline] (231.219 ms) : 0, 231219
GlobalTracer [candidate] (231.369 ms) : 0, 231369
AppSec [baseline] (57.874 ms) : 0, 57874
AppSec [candidate] (57.535 ms) : 0, 57535
Remote Config [baseline] (624.066 µs) : 0, 624
Remote Config [candidate] (622.928 µs) : 0, 623
Telemetry [baseline] (8.94 ms) : 0, 8940
Telemetry [candidate] (8.763 ms) : 0, 8763
IAST [baseline] (22.76 ms) : 0, 22760
IAST [candidate] (22.971 ms) : 0, 22971
section profiling
ProfilingAgent [baseline] (96.24 ms) : 0, 96240
ProfilingAgent [candidate] (95.859 ms) : 0, 95859
BytebuddyAgent [baseline] (707.106 ms) : 0, 707106
BytebuddyAgent [candidate] (708.77 ms) : 0, 708770
GlobalTracer [baseline] (349.834 ms) : 0, 349834
GlobalTracer [candidate] (349.236 ms) : 0, 349236
AppSec [baseline] (55.443 ms) : 0, 55443
AppSec [candidate] (54.568 ms) : 0, 54568
Remote Config [baseline] (667.862 µs) : 0, 668
Remote Config [candidate] (662.417 µs) : 0, 662
Telemetry [baseline] (8.958 ms) : 0, 8958
Telemetry [candidate] (8.977 ms) : 0, 8977
Profiling [baseline] (96.265 ms) : 0, 96265
Profiling [candidate] (95.883 ms) : 0, 95883
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-19T16:04:30 2025-02-19T16:11:36
git_branch master landerson/gitlab-migrate-pt1
git_commit_date 1739977713 1739980428
git_commit_sha 27b2d68 6e897a1
release_version 1.47.0-SNAPSHOT~27b2d685cd 1.47.0-SNAPSHOT~6e897a1a20
start_time 2025-02-19T16:04:16 2025-02-19T16:11:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1739981855 1739981855
ci_job_id 814237028 814237028
ci_pipeline_id 56309811 56309811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-b9ajvw1j-project-304-concurrent-0-fmcmvr09 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-b9ajvw1j-project-304-concurrent-0-fmcmvr09 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.07 µs) : 363, 403
.   : milestone, 383,
iast (521.161 µs) : 498, 544
.   : milestone, 521,
iast_FULL (733.08 µs) : 711, 755
.   : milestone, 733,
iast_GLOBAL (564.563 µs) : 543, 587
.   : milestone, 565,
iast_HARDCODED_SECRET_DISABLED (513.225 µs) : 491, 536
.   : milestone, 513,
iast_INACTIVE (469.015 µs) : 448, 490
.   : milestone, 469,
iast_TELEMETRY_OFF (511.164 µs) : 488, 535
.   : milestone, 511,
tracing (457.427 µs) : 437, 478
.   : milestone, 457,
section candidate
no_agent (382.487 µs) : 363, 402
.   : milestone, 382,
iast (517.527 µs) : 496, 539
.   : milestone, 518,
iast_FULL (736.954 µs) : 715, 759
.   : milestone, 737,
iast_GLOBAL (571.34 µs) : 548, 594
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (523.655 µs) : 500, 547
.   : milestone, 524,
iast_INACTIVE (467.018 µs) : 446, 488
.   : milestone, 467,
iast_TELEMETRY_OFF (508.425 µs) : 485, 532
.   : milestone, 508,
tracing (465.703 µs) : 445, 487
.   : milestone, 466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.07 µs [363.257 µs, 402.883 µs] -
iast 521.161 µs [498.358 µs, 543.964 µs] 138.091 µs (36.0%)
iast_FULL 733.08 µs [711.203 µs, 754.957 µs] 350.01 µs (91.4%)
iast_GLOBAL 564.563 µs [542.577 µs, 586.548 µs] 181.493 µs (47.4%)
iast_HARDCODED_SECRET_DISABLED 513.225 µs [490.89 µs, 535.559 µs] 130.155 µs (34.0%)
iast_INACTIVE 469.015 µs [447.753 µs, 490.277 µs] 85.945 µs (22.4%)
iast_TELEMETRY_OFF 511.164 µs [487.748 µs, 534.58 µs] 128.094 µs (33.4%)
tracing 457.427 µs [436.772 µs, 478.081 µs] 74.357 µs (19.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.487 µs [362.872 µs, 402.102 µs] -
iast 517.527 µs [495.609 µs, 539.445 µs] 135.039 µs (35.3%)
iast_FULL 736.954 µs [715.134 µs, 758.773 µs] 354.466 µs (92.7%)
iast_GLOBAL 571.34 µs [548.26 µs, 594.42 µs] 188.853 µs (49.4%)
iast_HARDCODED_SECRET_DISABLED 523.655 µs [499.963 µs, 547.346 µs] 141.167 µs (36.9%)
iast_INACTIVE 467.018 µs [445.78 µs, 488.256 µs] 84.531 µs (22.1%)
iast_TELEMETRY_OFF 508.425 µs [484.523 µs, 532.326 µs] 125.937 µs (32.9%)
tracing 465.703 µs [444.639 µs, 486.767 µs] 83.216 µs (21.8%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1393
.   : milestone, 1374,
appsec (1.751 ms) : 1728, 1775
.   : milestone, 1751,
appsec_no_iast (1.792 ms) : 1769, 1815
.   : milestone, 1792,
iast (1.507 ms) : 1483, 1531
.   : milestone, 1507,
profiling (1.526 ms) : 1500, 1551
.   : milestone, 1526,
tracing (1.494 ms) : 1469, 1520
.   : milestone, 1494,
section candidate
no_agent (1.374 ms) : 1354, 1394
.   : milestone, 1374,
appsec (1.756 ms) : 1733, 1780
.   : milestone, 1756,
appsec_no_iast (1.758 ms) : 1730, 1786
.   : milestone, 1758,
iast (1.531 ms) : 1506, 1555
.   : milestone, 1531,
profiling (1.522 ms) : 1498, 1546
.   : milestone, 1522,
tracing (1.473 ms) : 1448, 1498
.   : milestone, 1473,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.354 ms, 1.393 ms] -
appsec 1.751 ms [1.728 ms, 1.775 ms] 377.337 µs (27.5%)
appsec_no_iast 1.792 ms [1.769 ms, 1.815 ms] 418.398 µs (30.5%)
iast 1.507 ms [1.483 ms, 1.531 ms] 132.822 µs (9.7%)
profiling 1.526 ms [1.5 ms, 1.551 ms] 151.928 µs (11.1%)
tracing 1.494 ms [1.469 ms, 1.52 ms] 120.627 µs (8.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.374 ms [1.354 ms, 1.394 ms] -
appsec 1.756 ms [1.733 ms, 1.78 ms] 382.145 µs (27.8%)
appsec_no_iast 1.758 ms [1.73 ms, 1.786 ms] 384.011 µs (27.9%)
iast 1.531 ms [1.506 ms, 1.555 ms] 156.712 µs (11.4%)
profiling 1.522 ms [1.498 ms, 1.546 ms] 148.027 µs (10.8%)
tracing 1.473 ms [1.448 ms, 1.498 ms] 98.944 µs (7.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master landerson/gitlab-migrate-pt1
git_commit_date 1739977713 1739980428
git_commit_sha 27b2d68 6e897a1
release_version 1.47.0-SNAPSHOT~27b2d685cd 1.47.0-SNAPSHOT~6e897a1a20
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1739982546 1739982546
ci_job_id 814237029 814237029
ci_pipeline_id 56309811 56309811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ze2nslu5-project-304-concurrent-0-q3a1pf5h 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ze2nslu5-project-304-concurrent-0-q3a1pf5h 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (2.362 ms) : 2319, 2405
.   : milestone, 2362,
iast (2.123 ms) : 2068, 2178
.   : milestone, 2123,
iast_GLOBAL (2.157 ms) : 2102, 2213
.   : milestone, 2157,
profiling (1.962 ms) : 1919, 2005
.   : milestone, 1962,
tracing (1.951 ms) : 1909, 1994
.   : milestone, 1951,
section candidate
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.351 ms) : 2307, 2394
.   : milestone, 2351,
iast (2.106 ms) : 2051, 2161
.   : milestone, 2106,
iast_GLOBAL (2.161 ms) : 2105, 2216
.   : milestone, 2161,
profiling (1.976 ms) : 1933, 2020
.   : milestone, 1976,
tracing (1.937 ms) : 1895, 1979
.   : milestone, 1937,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.464 ms, 1.487 ms] -
appsec 2.362 ms [2.319 ms, 2.405 ms] 886.591 µs (60.1%)
iast 2.123 ms [2.068 ms, 2.178 ms] 647.487 µs (43.9%)
iast_GLOBAL 2.157 ms [2.102 ms, 2.213 ms] 682.007 µs (46.2%)
profiling 1.962 ms [1.919 ms, 2.005 ms] 486.886 µs (33.0%)
tracing 1.951 ms [1.909 ms, 1.994 ms] 475.929 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.351 ms [2.307 ms, 2.394 ms] 878.956 µs (59.7%)
iast 2.106 ms [2.051 ms, 2.161 ms] 634.013 µs (43.1%)
iast_GLOBAL 2.161 ms [2.105 ms, 2.216 ms] 688.782 µs (46.8%)
profiling 1.976 ms [1.933 ms, 2.02 ms] 504.301 µs (34.3%)
tracing 1.937 ms [1.895 ms, 1.979 ms] 465.136 µs (31.6%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~6e897a1a20, baseline=1.47.0-SNAPSHOT~27b2d685cd
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.947 s) : 14947000, 14947000
.   : milestone, 14947000,
appsec (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
iast (18.993 s) : 18993000, 18993000
.   : milestone, 18993000,
iast_GLOBAL (17.613 s) : 17613000, 17613000
.   : milestone, 17613000,
profiling (15.219 s) : 15219000, 15219000
.   : milestone, 15219000,
tracing (15.108 s) : 15108000, 15108000
.   : milestone, 15108000,
section candidate
no_agent (15.285 s) : 15285000, 15285000
.   : milestone, 15285000,
appsec (15.034 s) : 15034000, 15034000
.   : milestone, 15034000,
iast (18.572 s) : 18572000, 18572000
.   : milestone, 18572000,
iast_GLOBAL (18.034 s) : 18034000, 18034000
.   : milestone, 18034000,
profiling (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
tracing (15.262 s) : 15262000, 15262000
.   : milestone, 15262000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.947 s [14.947 s, 14.947 s] -
appsec 15.085 s [15.085 s, 15.085 s] 138.0 ms (0.9%)
iast 18.993 s [18.993 s, 18.993 s] 4.046 s (27.1%)
iast_GLOBAL 17.613 s [17.613 s, 17.613 s] 2.666 s (17.8%)
profiling 15.219 s [15.219 s, 15.219 s] 272.0 ms (1.8%)
tracing 15.108 s [15.108 s, 15.108 s] 161.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.285 s [15.285 s, 15.285 s] -
appsec 15.034 s [15.034 s, 15.034 s] -251.0 ms (-1.6%)
iast 18.572 s [18.572 s, 18.572 s] 3.287 s (21.5%)
iast_GLOBAL 18.034 s [18.034 s, 18.034 s] 2.749 s (18.0%)
profiling 15.448 s [15.448 s, 15.448 s] 163.0 ms (1.1%)
tracing 15.262 s [15.262 s, 15.262 s] -23.0 ms (-0.2%)

@@ -23,15 +23,24 @@ variables:
DEPENDENCY_CACHE_POLICY: pull
BUILD_CACHE_POLICY: pull
GRADLE_VERSION: "8.4" # must match gradle-wrapper.properties
JAVA_BUILD_IMAGE_VERSION: "v25.01"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the automation related to the tag update. I can track it as KLTO if you want?

.gitlab-ci.yml Outdated
DEPENDENCY_CACHE_POLICY: pull
script:
- ./gradlew clean :dd-java-agent:shadowJar :dd-trace-api:jar :dd-trace-ot:shadowJar $GRADLE_ARGS
- ./gradlew resolveAndLockAll --write-locks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the lock expected to be disabled here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, IDK. I'm just following what was done in CircleCI. I found the default build job in circleci has this line so I added it to the Gitlab build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are distinct pipelines:

  • weekly builds
  • nightly builds
  • PR check builds

We want to update the lock only for nightly builds. If we do it for all the builds, the locks are no more useful in CI anymore (and devs will have a different builds than CI too).

Can you re-introduce this behavior?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. resolveAndLockAll now only runs as part of nightly

@randomanderson randomanderson enabled auto-merge (squash) February 19, 2025 15:53
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the migration

I added a "required" gitlab job to make it easier to Github PR required jobs

Should I add it already to the required checks? How would it behave for branches that don't have migrated yet?

@randomanderson randomanderson merged commit 74ee62c into master Feb 20, 2025
211 checks passed
@randomanderson randomanderson deleted the landerson/gitlab-migrate-pt1 branch February 20, 2025 08:45
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants