-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: goroutineswait saw-stop mechanism #942
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1201075
profiler: goroutineswait saw-stop mechanism
felixge 768a8b3
Rename test
felixge 2538e33
Improve error message
felixge 2e95053
Clarify intend for extra channel
felixge 1a856f4
Rename stopped to stopping
felixge d73a43d
Merge branch 'v1' into felix.geisendoerfer/goroutineswait-sawstop
knusbaum 6815d9d
Merge branch 'v1' into felix.geisendoerfer/goroutineswait-sawstop
felixge 58e2b1d
Merge branch 'v1' into felix.geisendoerfer/goroutineswait-sawstop
felixge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of
launched
? It looks to me like if you removed it, this would function the same way, since the goroutines would all block onstopped
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intend behind
launched
is to ensure that the goroutines have started executing beforespawnGoroutines()
returns. Withoutlaunched
this invariant would be subject to a race condition.In practice
launched
could be removed without repercussions because the go runtime immediately registers newly created goroutines as_Grunnable
. That being said, this behavior seems to be an implementation detail that isn't covered by the language specification. I.e. a future version of Go might decide to put the goroutines into a new_Glaunchable
state that isn't included inruntime.NumGoroutines()
. Solaunched
could prevent our test from breaking in the future.That being said, I don't expect the runtime details of this to change anytime soon, so I don't feel strongly about it. I can remove the
launched
if you like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. That makes sense and seems to be a good solution.
My only comment is that it does not seem obvious why this code is like it is unless you know the go runtime internals. It might be good to make a small comment here about
launched
and how we need the goroutines to be running beforespawnGoroutines
returns.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, PTAL at 2e95053 to see if this does a good enough job in clarifying the intend.